1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 67C3A431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 15:10:56 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.7 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id gb-+Z-p0RWFp for <notmuch@notmuchmail.org>;
\r
18 Wed, 1 Feb 2012 15:10:55 -0800 (PST)
\r
19 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
20 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 94A85431FAE
\r
23 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 15:10:55 -0800 (PST)
\r
24 Received: by bke11 with SMTP id 11so1704261bke.26
\r
25 for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 15:10:54 -0800 (PST)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
27 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
28 :message-id:mime-version:content-type;
\r
29 bh=giMSz03e1r97jklaFOlGh2vO5h+83S950ZSm1hM3dDs=;
\r
30 b=fkcpmdejn4TP0sI31+jOhc1cXbO8BEiBC8riGr+Bdcgq4Nm4uR+a6vrCZY62aW2xXm
\r
31 T/Kx3ImhqcB143r8llsxvqL5Fydv89ktUM5Sv/ltDK7Ca4hZB8kAqf1/Cgwzh0gaBgUp
\r
32 ppmaCdTl9mfjulm1CUzXgUoAYKGJqa4oZlFF0=
\r
33 Received: by 10.205.120.138 with SMTP id fy10mr203832bkc.118.1328137854030;
\r
34 Wed, 01 Feb 2012 15:10:54 -0800 (PST)
\r
35 Received: from localhost ([91.144.186.21])
\r
36 by mx.google.com with ESMTPS id ga13sm1243001bkc.5.2012.02.01.15.10.52
\r
37 (version=TLSv1/SSLv3 cipher=OTHER);
\r
38 Wed, 01 Feb 2012 15:10:52 -0800 (PST)
\r
39 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
40 To: Pieter Praet <pieter@praet.org>
\r
41 Subject: Re: [PATCH] test: replace occurrences of $PWD with vars that are more
\r
43 In-Reply-To: <1328128641-31155-1-git-send-email-pieter@praet.org>
\r
44 References: <87ipjqb8c1.fsf@praet.org>
\r
45 <1328128641-31155-1-git-send-email-pieter@praet.org>
\r
46 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Thu, 02 Feb 2012 03:09:39 +0400
\r
49 Message-ID: <878vkmm9qk.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Wed, 01 Feb 2012 23:10:56 -0000
\r
67 On Wed, 1 Feb 2012 21:37:21 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
68 > Thanks to Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
69 > for pointing this out: id:"87d39ymyb4.fsf@gmail.com"
\r
72 Looks good to me. Minor comments below.
\r
75 > test/new | 6 +++---
\r
76 > 2 files changed, 4 insertions(+), 4 deletions(-)
\r
78 > diff --git a/test/emacs b/test/emacs
\r
79 > index 17129b7..9c9d0b4 100755
\r
82 > @@ -266,7 +266,7 @@ From: Notmuch Test Suite <test_suite@notmuchmail.org>
\r
83 > To: user@example.com
\r
84 > Subject: Re: Testing message sent via SMTP
\r
85 > In-Reply-To: <XXX>
\r
86 > -Fcc: $(pwd)/mail/sent
\r
87 > +Fcc: ${MAIL_DIR}/sent
\r
88 > --text follows this line--
\r
89 > On 01 Jan 2000 12:00:00 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
\r
90 > > This is a test that messages are sent via SMTP
\r
91 > diff --git a/test/new b/test/new
\r
92 > index 49f390d..1b24c84 100755
\r
95 > @@ -117,10 +117,10 @@ test_expect_equal "$output" "No new mail. Removed 3 messages."
\r
96 > test_begin_subtest "New symlink to directory"
\r
98 > rm -rf "${MAIL_DIR}"/.notmuch
\r
99 > -mv "${MAIL_DIR}" "$PWD"/actual_maildir
\r
100 > +mv "${MAIL_DIR}" "${TMP_DIRECTORY}"/actual_maildir
\r
102 I would prefer to put the whole second argument inside the quotes, not
\r
106 > mkdir "${MAIL_DIR}"
\r
107 > -ln -s "$PWD"/actual_maildir "${MAIL_DIR}"/symlink
\r
108 > +ln -s "${TMP_DIRECTORY}"/actual_maildir "${MAIL_DIR}"/symlink
\r
113 > output=$(NOTMUCH_NEW)
\r
114 > test_expect_equal "$output" "Added 1 new message to the database."
\r
115 > @@ -128,7 +128,7 @@ test_expect_equal "$output" "Added 1 new message to the database."
\r
117 > test_begin_subtest "New symlink to a file"
\r
119 > -external_msg_filename="$PWD"/external/"$(basename "$gen_msg_filename")"
\r
120 > +external_msg_filename="${TMP_DIRECTORY}"/external/"$(basename "$gen_msg_filename")"
\r
122 And here as well. The quotes around "/external/" can just be removed.
\r
127 > mkdir -p "$(dirname "$external_msg_filename")"
\r
128 > mv "$gen_msg_filename" "$external_msg_filename"
\r
129 > ln -s "$external_msg_filename" "$gen_msg_filename"
\r