1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 413F6431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 09:33:50 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id XTeGTcmVfnUs for <notmuch@notmuchmail.org>;
\r
17 Sun, 18 Nov 2012 09:33:49 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9DF11431FAF
\r
22 for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 09:33:49 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Ta8kd-0005IY-RW; Sun, 18 Nov 2012 17:33:48 +0000
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1Ta8kd-0003v9-H9; Sun, 18 Nov 2012 17:33:47 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 05/18] insert: move file from Maildir tmp to new
\r
34 In-Reply-To: <1343223767-9812-5-git-send-email-novalazy@gmail.com>
\r
35 References: <1343223767-9812-1-git-send-email-novalazy@gmail.com>
\r
36 <1343223767-9812-5-git-send-email-novalazy@gmail.com>
\r
37 User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Sun, 18 Nov 2012 17:33:46 +0000
\r
40 Message-ID: <87haomq0hx.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 93.97.24.31
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: c96fb93cd9072194f917a485709869ec (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: -1.8
\r
47 X-SpamAssassin-SpamBar: -
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored -1.8 points.
\r
52 Summary of the scoring:
\r
53 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
55 * [138.37.6.40 listed in list.dnswl.org]
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * 0.5 AWL AWL: From: address is in the auto white-list
\r
59 X-QM-Scan-Virus: ClamAV says the message is clean
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Sun, 18 Nov 2012 17:33:50 -0000
\r
74 On Wed, 25 Jul 2012, Peter Wang <novalazy@gmail.com> wrote:
\r
75 > Atomically move the new message file from the Maildir 'tmp' directory
\r
78 > notmuch-insert.c | 18 ++++++++++++++++++
\r
79 > 1 files changed, 18 insertions(+), 0 deletions(-)
\r
81 > diff --git a/notmuch-insert.c b/notmuch-insert.c
\r
82 > index 340f7e4..bab1fed 100644
\r
83 > --- a/notmuch-insert.c
\r
84 > +++ b/notmuch-insert.c
\r
85 > @@ -75,6 +75,20 @@ maildir_open_tmp (void *ctx, const char *dir, char **tmppath, char **newpath)
\r
88 > static notmuch_bool_t
\r
89 > +maildir_move_to_new (const char *tmppath, const char *newpath)
\r
91 > + /* We follow the Dovecot recommendation to simply use rename()
\r
92 > + * instead of link() and unlink().
\r
94 > + if (rename (tmppath, newpath) == 0) {
\r
98 Do we want to overwrite an existing message with this name? As far as I
\r
99 can see rename does overwrite and link would not: was that why rename is
\r
100 better than link/unlink?
\r
102 I would prefer not to overwrite but maybe there is a reason we need to.
\r
103 Would a possible alternative be to loop when finding a tmp file until
\r
104 both the tmp file and the new file do not exist?
\r
112 > + fprintf (stderr, "Error: rename() failed: %s\n", strerror (errno));
\r
116 > +static notmuch_bool_t
\r
117 > copy_fd_data (int fdin, int fdout)
\r
120 > @@ -132,6 +146,10 @@ insert_message (void *ctx, notmuch_database_t *notmuch, int fdin,
\r
125 > + ret = maildir_move_to_new (tmppath, newpath);
\r
129 > unlink (tmppath);
\r
134 > _______________________________________________
\r
135 > notmuch mailing list
\r
136 > notmuch@notmuchmail.org
\r
137 > http://notmuchmail.org/mailman/listinfo/notmuch
\r