1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 20535431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 4 Sep 2012 23:48:57 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id JM7ZX-MH-Lqw for <notmuch@notmuchmail.org>;
\r
16 Tue, 4 Sep 2012 23:48:52 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id C03DE431FAF
\r
19 for <notmuch@notmuchmail.org>; Tue, 4 Sep 2012 23:48:52 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id CEF601000E5;
\r
22 Wed, 5 Sep 2012 09:48:58 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] emacs: Add customization group for replying
\r
26 In-Reply-To: <87zk55n44x.fsf@steelpick.2x.cz>
\r
27 References: <1343311113-22171-1-git-send-email-sojkam1@fel.cvut.cz>
\r
28 <87vcfu2qap.fsf@steelpick.2x.cz>
\r
29 <m2ligqnoap.fsf@guru.guru-group.fi>
\r
30 <87zk55n44x.fsf@steelpick.2x.cz>
\r
31 User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Wed, 05 Sep 2012 09:48:58 +0300
\r
37 Message-ID: <m21uih6k2t.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Wed, 05 Sep 2012 06:48:57 -0000
\r
54 On Tue, Sep 04 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
56 > On Tue, Sep 04 2012, Tomi Ollila wrote:
\r
57 >> On Tue, Sep 04 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
59 >>> On Thu, Jul 26 2012, Michal Sojka wrote:
\r
60 >>>> When one wants to customize the format of reply message, there nothing
\r
61 >>>> to tell the user how to do it. Without knowing that construction of
\r
62 >>>> reply buffer is actually implemented in the message package, it seems
\r
63 >>>> that replying cannot be customized.
\r
65 >>>> Because I was getting annoyed by the empty line the between citation
\r
66 >>>> line and the quoted message, I figured out that changing this is fairly
\r
67 >>>> easy when one knows what to customize.
\r
69 >>>> This patch adds notmuch-reply customization group that that contains
\r
70 >>>> references to the relevant customization options. The new group is easy
\r
71 >>>> to find as it is shown as a result of running "M-x customize-group RET
\r
76 >>> Any objections against applying?
\r
78 >> Nobody dares to say anything due to infamiliriaty of this spesific case ;/.
\r
80 >> I could not find any reference this has been made before.
\r
82 > It's at least documented at
\r
83 > http://www.gnu.org/software/emacs/manual/html_node/elisp/Group-Definitions.html
\r
85 > The argument members is a list specifying an initial set of
\r
86 > customization items to be members of the group. However, most often
\r
87 > members is nil, and you specify the group's members by using the
\r
88 > :group keyword when defining those members.
\r
90 >> I could not find any discussion about this issue.
\r
92 >> With little effort I could not extract the customization tree to
\r
93 >> stdout I could have attempted to grep whether there is same variable
\r
96 > I tried to grep emacs sources and found the following:
\r
98 > (defgroup message '((user-mail-address custom-variable)
\r
99 > (defgroup gnus-message '((message custom-group))
\r
100 > (defgroup ps-print-printer '((lpr custom-group))
\r
101 > (defgroup customize '((widgets custom-group))
\r
102 > (defgroup font-lock '((jit-lock custom-group))
\r
104 > At least the first line corresponds exactly to what is proposed in my
\r
110 I was looking whether the same customization variable has been put
\r
111 into multiple groups (now those are also in message-insertion group like
\r
112 you have in your patch). (So far) I haven't seen that to be done
\r
113 (not that it forbids doing so, just that there aren't issues about that).
\r
115 >From consistency point of view all the customization variables in notmuch
\r
116 groups start with "notmuch-" and these "message-" breaks this... An
\r
117 alternative to the above could be the following:
\r
119 (defgroup notmuch-reply
\r
120 '((notmuch-message-replied-tags custom-variable)
\r
121 (message-insertion custom-group))
\r
124 I.e. first moving notmuch-message-replied-tags to this new group
\r
125 and (only) referencing the message-insertion group from notmuch-reply
\r
126 group (the message-citation-line-format & message-citation-line-function
\r
127 are the first variables in message-insertion group, which is nice).
\r
projects / notmuch-archives.git / blob