1 Return-Path: <doctormo@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C79E3429E26
\r
6 for <notmuch@notmuchmail.org>; Thu, 8 Sep 2011 19:54:27 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 1OaLbwxOFsbD for <notmuch@notmuchmail.org>;
\r
17 Thu, 8 Sep 2011 19:54:26 -0700 (PDT)
\r
18 Received: from mail-qw0-f43.google.com (mail-qw0-f43.google.com
\r
19 [209.85.216.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 34637431FD0
\r
22 for <notmuch@notmuchmail.org>; Thu, 8 Sep 2011 19:54:26 -0700 (PDT)
\r
23 Received: by qwm42 with SMTP id 42so1228717qwm.2
\r
24 for <notmuch@notmuchmail.org>; Thu, 08 Sep 2011 19:54:24 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=subject:from:to:cc:in-reply-to:references:content-type:date
\r
27 :message-id:mime-version:x-mailer:content-transfer-encoding;
\r
28 bh=G5NZ/81baRoGsTBjUVAh+bu9mz9QT+LFLt+dMoge8fY=;
\r
29 b=o3/9S/iOWlsXvwOB5nE9ghtn92U6giPS9MYtftF9dH5bAJElyYD1oloFqvhbBKsQhU
\r
30 VU3k+Mfr2cuTNd/ci6DWywSju+F+i4IUh3nsJwOdnde6rlRcB9v91+t2BgOGvaBAmkyB
\r
31 S1H9rYFX6uggIG/eNBb/e6D+UAnD1GRsLtA5I=
\r
32 Received: by 10.224.210.134 with SMTP id gk6mr1112299qab.12.1315536864305;
\r
33 Thu, 08 Sep 2011 19:54:24 -0700 (PDT)
\r
34 Received: from [192.168.1.190] (pool-68-163-190-45.bos.east.verizon.net.
\r
36 by mx.google.com with ESMTPS id dx7sm4617250qab.11.2011.09.08.19.54.22
\r
37 (version=SSLv3 cipher=OTHER); Thu, 08 Sep 2011 19:54:23 -0700 (PDT)
\r
38 Subject: Re: Patch: Flush and Reopen
\r
39 From: Martin Owens <doctormo@gmail.com>
\r
40 To: Austin Clements <amdragon@mit.edu>
\r
42 <CAH-f9WtuYYuksfTHL1ZMmoRF6kyL7iFu9BXDzGn-wWGniSvf9w@mail.gmail.com>
\r
43 References: <1315445674.32058.183.camel@delen>
\r
44 <CAH-f9WtuYYuksfTHL1ZMmoRF6kyL7iFu9BXDzGn-wWGniSvf9w@mail.gmail.com>
\r
45 Content-Type: text/plain; charset="UTF-8"
\r
46 Date: Thu, 08 Sep 2011 22:54:21 -0400
\r
47 Message-ID: <1315536861.2435.34.camel@delen>
\r
49 X-Mailer: Evolution 2.30.3
\r
50 Content-Transfer-Encoding: 7bit
\r
51 Cc: Paul Tagliamonte <paultag@ubuntu.com>,
\r
52 Notmuch developer list <notmuch@notmuchmail.org>
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Fri, 09 Sep 2011 02:54:27 -0000
\r
69 Thanks for the review :-) I'll attempt to fix some of the style
\r
70 guidelines, but see below.
\r
72 On Thu, 2011-09-08 at 22:42 -0400, Austin Clements wrote:
\r
73 > Did you mean to change this?
\r
75 This fails to build on Ubuntu maverick with the extra .3 and I see no
\r
76 reason to have that sub-minor version. Pushing it in would probably be
\r
77 useful unless there is a real reason.
\r
79 > This cast will fail. Shouldn't this just be a wrapper around
\r
80 > notmuch->xapian_db->reopen?
\r
82 I'm a python programmer, c wrappers are beyond me unfortunately. Your
\r
83 help implementing that would be really good.
\r
85 Best regards, Martin Owens
\r