1 Return-Path: <polatel@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 031F2431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 23 Apr 2012 07:04:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 7pVdRP1tC2ED for <notmuch@notmuchmail.org>;
\r
17 Mon, 23 Apr 2012 07:04:46 -0700 (PDT)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D608D431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 23 Apr 2012 07:04:45 -0700 (PDT)
\r
23 Received: by bkcjm2 with SMTP id jm2so2098329bkc.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 23 Apr 2012 07:04:43 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=aPPfBs8sjhjRzpppRYKZ0CgbdTShcjf3mOXmxAh2aso=;
\r
30 b=ji4cApa19MYC404FS7wZOLuzRLWCiuLFcFLUuw9MwBVwp19WSuzazUMAdXxi/SA6zY
\r
31 q5+4dC/SkpTNlDFZFSMsa3JVMOKpgiO51o90bsGM60Oq321GTg3JHtp9V1alNLimCGZn
\r
32 1sVXuvRmw4gKwPE9v3rway3MZO2WSFsBZYOjJc9pJFV8PIaNzD2IIdC824nusewAag1j
\r
33 ZQuBYsJVPlMmaNHvyCJBHrOFfeoBQYZdyPLwtl5U7c3Ckvne9ZnCmSp2l5laLvnjhLCS
\r
34 D+OmfMI9OqS1zwy/uvOp8I6DiwcN1Nhut/AuluschsL+u9gjWu7WdLtG5Gm3qWIvrj8C
\r
37 Received: by 10.204.154.133 with SMTP id o5mr5146445bkw.100.1335189883129;
\r
38 Mon, 23 Apr 2012 07:04:43 -0700 (PDT)
\r
39 Sender: polatel@gmail.com
\r
40 Received: by 10.204.123.73 with HTTP; Mon, 23 Apr 2012 07:04:43 -0700 (PDT)
\r
41 In-Reply-To: <1335185032-13075-1-git-send-email-felipe.contreras@gmail.com>
\r
42 References: <1335185032-13075-1-git-send-email-felipe.contreras@gmail.com>
\r
43 Date: Mon, 23 Apr 2012 17:04:43 +0300
\r
44 X-Google-Sender-Auth: WwD-_Gj6-IaQEn68VdSYjc7dU0M
\r
46 <CADv3eywAvyMuh3vWLwyuf0Ui_kskwp9875pGxCR1GTm7deN9Pg@mail.gmail.com>
\r
47 Subject: Re: [PATCH] ruby: make sure the database is closed
\r
48 From: Ali Polatel <alip@exherbo.org>
\r
49 To: Felipe Contreras <felipe.contreras@gmail.com>
\r
50 Content-Type: text/plain; charset=ISO-8859-1
\r
51 Content-Transfer-Encoding: quoted-printable
\r
52 Cc: notmuch@notmuchmail.org
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Mon, 23 Apr 2012 14:04:47 -0000
\r
67 2012/4/23 Felipe Contreras <felipe.contreras@gmail.com>:
\r
68 > If the Ruby code does not manually close the database, we need to make
\r
69 > sure it's closed when garbage collected.
\r
71 > In Ruby, users are not _required_ to close, the garbage collector should
\r
72 > take care of that.
\r
74 > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
\r
76 > =A0bindings/ruby/database.c | =A0 =A08 +++++++-
\r
77 > =A01 file changed, 7 insertions(+), 1 deletion(-)
\r
79 > diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c
\r
80 > index 982fd59..7b2ed47 100644
\r
81 > --- a/bindings/ruby/database.c
\r
82 > +++ b/bindings/ruby/database.c
\r
83 > @@ -20,10 +20,16 @@
\r
85 > =A0#include "defs.h"
\r
88 > +database_free (void *p)
\r
90 > + =A0 =A0notmuch_database_close (p);
\r
94 > =A0notmuch_rb_database_alloc (VALUE klass)
\r
96 > - =A0 =A0return Data_Wrap_Struct (klass, NULL, NULL, NULL);
\r
97 > + =A0 =A0return Data_Wrap_Struct (klass, NULL, database_free, NULL);
\r
105 I'd rather not do this.
\r
106 Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324
\r