1 Return-Path: <dkg@fifthhorseman.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id E26F66DE178F
\r
6 for <notmuch@notmuchmail.org>; Fri, 15 Jan 2016 11:12:00 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.025 tagged_above=-999 required=5
\r
12 tests=[AWL=-0.025] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id RpBJSWAXJMlN for <notmuch@notmuchmail.org>;
\r
16 Fri, 15 Jan 2016 11:11:59 -0800 (PST)
\r
17 Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 4551D6DE0A87
\r
19 for <notmuch@notmuchmail.org>; Fri, 15 Jan 2016 11:11:59 -0800 (PST)
\r
20 Received: from fifthhorseman.net (unknown [38.109.115.130])
\r
21 by che.mayfirst.org (Postfix) with ESMTPSA id D0D00F984;
\r
22 Fri, 15 Jan 2016 14:11:55 -0500 (EST)
\r
23 Received: by fifthhorseman.net (Postfix, from userid 1000)
\r
24 id 474F72002F; Fri, 15 Jan 2016 11:11:55 -0800 (PST)
\r
25 From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
\r
26 To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,
\r
27 Notmuch Mail <notmuch@notmuchmail.org>
\r
28 Subject: Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t
\r
29 In-Reply-To: <m21taqbnt8.fsf@guru.guru-group.fi>
\r
30 References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net>
\r
31 <1449718786-28000-8-git-send-email-dkg@fifthhorseman.net>
\r
32 <m21tas7ifa.fsf@guru.guru-group.fi> <87mvtgfws4.fsf@alice.fifthhorseman.net>
\r
33 <87d1ubdu0k.fsf@zancas.localnet> <m24mfmbolm.fsf@guru.guru-group.fi>
\r
34 <m21taqbnt8.fsf@guru.guru-group.fi>
\r
35 User-Agent: Notmuch/0.21+66~g8c19a9a (http://notmuchmail.org) Emacs/24.5.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Fri, 15 Jan 2016 14:11:55 -0500
\r
38 Message-ID: <871t9i7j44.fsf@alice.fifthhorseman.net>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.20
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Fri, 15 Jan 2016 19:12:01 -0000
\r
55 On Sun 2015-12-13 06:17:07 -0500, Tomi Ollila wrote:
\r
56 > Actually now that I sent this mail it kept rolling on my mind... If anyone
\r
57 > else than me (and libgpgme?) thinks that '.' should not be in search path
\r
60 fwiw, i agree that . should *not* be in the search path.
\r
62 > if (getenv("PATH") == NULL) {
\r
64 > setenv("PATH", "/bin:/usr/bin", 1); // XXX *BSD configurability //
\r
66 > else path_set = false;
\r
68 > ... g_find_program_in_path("gpg2")
\r
69 > ... g_find_program_in_path("gpg")
\r
74 I'm game for something like this, but i've got a queue of patches i'm
\r
75 about to send that would provide a different place to make this change,
\r
76 so i'm not making it now. please keep this in mind, though :)
\r
78 > I also thought of examining the return value starting with ./ but
\r
79 > (current or) future version of g_find_program_in_path() might
\r
80 > canonicalize the returned path...
\r
82 i'm not sure what this suggestion means -- do you mean checking to see
\r
83 whether the returned value started with ./ ? If so, I agree that this
\r
84 seems like a not very robust way to protect against this problem.
\r
86 Should we maybe also be reporting this as a bug against
\r
87 g_find_program_in_path ?
\r