1 Return-Path: <bremner@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AB06F431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 19:35:08 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id eJS4H4iTyBEm for <notmuch@notmuchmail.org>;
\r
16 Mon, 10 Dec 2012 19:35:08 -0800 (PST)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 08044431FAE
\r
21 for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 19:35:07 -0800 (PST)
\r
22 Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([142.167.90.129] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa
\r
25 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
26 (envelope-from <bremner@tethera.net>)
\r
27 id 1TiGcb-0000gD-08; Mon, 10 Dec 2012 23:35:06 -0400
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
29 (envelope-from <bremner@tethera.net>)
\r
30 id 1TiGcV-0007ki-Fq; Mon, 10 Dec 2012 23:34:59 -0400
\r
31 From: david@tethera.net
\r
32 To: notmuch@notmuchmail.org
\r
33 Subject: [PATCH] _notmuch_message_index_file: unref (free) address lists from
\r
35 Date: Mon, 10 Dec 2012 23:33:40 -0400
\r
36 Message-Id: <1355196820-29734-1-git-send-email-david@tethera.net>
\r
37 X-Mailer: git-send-email 1.7.10.4
\r
38 In-Reply-To: <1355188740-6663-1-git-send-email-david@tethera.net>
\r
39 References: <1355188740-6663-1-git-send-email-david@tethera.net>
\r
41 Cc: David Bremner <bremner@debian.org>
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Tue, 11 Dec 2012 03:35:08 -0000
\r
56 From: David Bremner <bremner@debian.org>
\r
58 Apparently as of GMime 2.4, you don't need to call
\r
59 internet_address_list_destroy anymore, but you still need to call
\r
60 g_object_unref (from the GMime Changelog).
\r
62 On the medium performance corpus, valgrind shows "possibly lost"
\r
63 leakage in "notmuch new" dropping from 7M to 300k.
\r
65 lib/index.cc | 12 +++++++++---
\r
66 1 file changed, 9 insertions(+), 3 deletions(-)
\r
68 diff --git a/lib/index.cc b/lib/index.cc
\r
69 index da0e6ce..a2edd6d 100644
\r
72 @@ -484,12 +484,18 @@ mboxes is deprecated and may be removed in the future.\n", filename);
\r
75 from = g_mime_message_get_sender (mime_message);
\r
76 - addresses = internet_address_list_parse_string (from);
\r
78 - _index_address_list (message, "from", addresses);
\r
79 + addresses = internet_address_list_parse_string (from);
\r
81 + _index_address_list (message, "from", addresses);
\r
82 + g_object_unref (addresses);
\r
85 addresses = g_mime_message_get_all_recipients (mime_message);
\r
86 - _index_address_list (message, "to", addresses);
\r
88 + _index_address_list (message, "to", addresses);
\r
89 + g_object_unref (addresses);
\r
92 subject = g_mime_message_get_subject (mime_message);
\r
93 _notmuch_message_gen_terms (message, "subject", subject);
\r