1 Return-Path: <bremner@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A87B1431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 11 Mar 2012 18:30:25 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id y8NYMOASnA8L for <notmuch@notmuchmail.org>;
\r
16 Sun, 11 Mar 2012 18:30:24 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6859B431FAE
\r
21 for <notmuch@notmuchmail.org>; Sun, 11 Mar 2012 18:30:24 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([142.166.230.117] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
\r
25 (Exim 4.72) (envelope-from <bremner@tethera.net>)
\r
26 id 1S6u5d-0000qA-3G; Sun, 11 Mar 2012 22:30:23 -0300
\r
27 Received: from bremner by zancas.localnet with local (Exim 4.77)
\r
28 (envelope-from <bremner@tethera.net>)
\r
29 id 1S6u5X-00008S-Ov; Sun, 11 Mar 2012 22:30:15 -0300
\r
30 From: David Bremner <david@tethera.net>
\r
31 To: notmuch@notmuchmail.org
\r
32 Subject: [PATCH] build: Require gmime >= 2.6.7
\r
33 Date: Sun, 11 Mar 2012 22:29:46 -0300
\r
34 Message-Id: <1331515786-485-1-git-send-email-david@tethera.net>
\r
35 X-Mailer: git-send-email 1.7.9.1
\r
36 In-Reply-To: <1329852935-3019-1-git-send-email-schnouki@schnouki.net>
\r
37 References: <1329852935-3019-1-git-send-email-schnouki@schnouki.net>
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Mon, 12 Mar 2012 01:30:25 -0000
\r
53 From: Thomas Jost <schnouki@schnouki.net>
\r
55 gmime-2.6 had a bug [1] which made it impossible to tell why a signature
\r
56 verification failed when the signer key was unavailable (empty "sigstatus" field
\r
57 in the JSON output). Since 00b5623d the corresponding test is marked as broken
\r
58 when using gmime-2.6 (2.4 is fine).
\r
60 This bug has been fixed in gmime 2.6.5, which is now the minimal gmime-2.6
\r
61 version required for building notmuch (gmime-2.4 is still available). As a
\r
62 consequence the version check in test/crypto can be removed.
\r
66 Although less unambigously a bug, Gmime 2.6 prior to 2.6.7 also was
\r
67 more strict about parsing, and rejected messages with initial "From "
\r
68 headers. This restriction is relaxed in [2]. For reasons explained in [3],
\r
69 we want to keep this more relaxed parsing for now.
\r
71 [1] https://bugzilla.gnome.org/show_bug.cgi?id=668085
\r
73 [2] http://git.gnome.org/browse/gmime/commit/?id=d311f576baf750476e06e9a1367a2dc1793ea7eb
\r
75 [3] id:"1331385931-1610-1-git-send-email-david@tethera.net"
\r
78 As an alternative to applying [3], I could apply this modified version of
\r
84 2 files changed, 3 insertions(+), 3 deletions(-)
\r
86 diff --git a/configure b/configure
\r
87 index dedb7d8..ee0ae73 100755
\r
90 @@ -273,9 +273,11 @@ if [ ${have_xapian} = "0" ]; then
\r
91 errors=$((errors + 1))
\r
94 +# If using GMime 2.6, we need to have a version >= 2.6.5 to avoid a
\r
95 +# crypto bug. We need 2.6.7 for permissive "From " header handling.
\r
96 printf "Checking for GMime development files... "
\r
98 -for gmimepc in gmime-2.6 gmime-2.4; do
\r
99 +for gmimepc in 'gmime-2.6 >= 2.6.7' gmime-2.4; do
\r
100 if pkg-config --exists $gmimepc; then
\r
101 printf "Yes ($gmimepc).\n"
\r
103 diff --git a/test/crypto b/test/crypto
\r
104 index 1dbb60a..6723ef8 100755
\r
107 @@ -104,8 +104,6 @@ test_expect_equal \
\r
110 test_begin_subtest "signature verification with signer key unavailable"
\r
111 -# this is broken with current versions of gmime-2.6
\r
112 -(ldd $(which notmuch) | grep -Fq gmime-2.6) && test_subtest_known_broken
\r
113 # move the gnupghome temporarily out of the way
\r
114 mv "${GNUPGHOME}"{,.bak}
\r
115 output=$(notmuch show --format=json --verify subject:"test signed message 001" \
\r