1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 17857431FDC
\r
6 for <notmuch@notmuchmail.org>; Sun, 8 Dec 2013 11:06:44 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 659z2WLykC4b for <notmuch@notmuchmail.org>;
\r
16 Sun, 8 Dec 2013 11:06:20 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 529D2431FD6
\r
19 for <notmuch@notmuchmail.org>; Sun, 8 Dec 2013 11:06:20 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id DDC1110005D;
\r
22 Sun, 8 Dec 2013 21:06:15 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 4/4] test: give unique timestamps to messages
\r
26 In-Reply-To: <1386517946-22054-5-git-send-email-david@tethera.net>
\r
27 References: <1386517946-22054-1-git-send-email-david@tethera.net>
\r
28 <1386517946-22054-5-git-send-email-david@tethera.net>
\r
29 User-Agent: Notmuch/0.17~rc1+17~ga2e1a2f (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Sun, 08 Dec 2013 21:06:15 +0200
\r
35 Message-ID: <m28uvvnowo.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sun, 08 Dec 2013 19:06:44 -0000
\r
52 On Sun, Dec 08 2013, David Bremner <david@tethera.net> wrote:
\r
54 > The choice of decreasing timestamps is a hack which reduces the number
\r
55 > of existing tests which fail. This can be changed to increasing
\r
56 > if/when somebody wants update another 47 tests.
\r
58 > test/excludes | 4 ++--
\r
59 > test/test-lib.sh | 2 +-
\r
60 > 2 files changed, 3 insertions(+), 3 deletions(-)
\r
62 > diff --git a/test/excludes b/test/excludes
\r
63 > index f1ae9ea..8bbbc2d 100755
\r
64 > --- a/test/excludes
\r
65 > +++ b/test/excludes
\r
66 > @@ -67,7 +67,7 @@ thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inb
\r
67 > test_begin_subtest "Search, don't exclude \"deleted\" messages when --exclude=flag specified"
\r
68 > output=$(notmuch search --exclude=flag subject:deleted | notmuch_search_sanitize)
\r
69 > test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)
\r
70 > -thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inbox unread)"
\r
71 > +thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Deleted (deleted inbox unread)"
\r
73 > test_begin_subtest "Search, don't exclude \"deleted\" messages from search if not configured"
\r
74 > notmuch config set search.exclude_tags
\r
75 > @@ -152,7 +152,7 @@ ${matching_message_ids[5]}"
\r
76 > test_begin_subtest "Search, exclude=flag (thread summary)"
\r
77 > output=$(notmuch search --exclude=flag tag:test | notmuch_search_sanitize)
\r
78 > test_expect_equal "$output" "thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: single match: reply 2 (deleted inbox test unread)
\r
79 > -thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: double match: reply 4 (deleted inbox test unread)
\r
80 > +thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: double match: reply 2 (deleted inbox test unread)
\r
81 > thread:XXX 2001-01-05 [0/6] Notmuch Test Suite; Some messages excluded: single excluded match: reply 3 (deleted inbox test unread)
\r
82 > thread:XXX 2001-01-05 [1/6] Notmuch Test Suite; Some messages excluded: single non-excluded match: reply 4 (deleted inbox test unread)
\r
83 > thread:XXX 2001-01-05 [1/6] Notmuch Test Suite; No messages excluded: single match: reply 3 (inbox test unread)"
\r
84 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
85 > index d238c66..792e477 100644
\r
86 > --- a/test/test-lib.sh
\r
87 > +++ b/test/test-lib.sh
\r
88 > @@ -356,7 +356,7 @@ generate_message ()
\r
91 > if [ -z "${template[date]}" ]; then
\r
92 > - template[date]="Fri, 05 Jan 2001 15:43:57 +0000"
\r
93 > + template[date]=$(date -Ru -d@$((978709437 - gen_msg_cnt)))
\r
95 I am afraid this is not portable (although not sure). This could work:
\r
97 _s=$((3599 - gen_msg_cnt))
\r
98 template[date]="Fri, 05 Jan 2001 15:$((_s / 60)):$((_s % 60)) +0000"
\r
102 > additional_headers=""
\r
104 Tomi (comments in hurry, after more careful examination done earlyer :)
\r