1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AD88A431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 3 Dec 2013 09:29:42 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MciZTFxFf+oi for <notmuch@notmuchmail.org>;
\r
16 Tue, 3 Dec 2013 09:29:32 -0800 (PST)
\r
17 Received: from mail-la0-f49.google.com (mail-la0-f49.google.com
\r
18 [209.85.215.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6B83B431FAF
\r
21 for <notmuch@notmuchmail.org>; Tue, 3 Dec 2013 09:29:32 -0800 (PST)
\r
22 Received: by mail-la0-f49.google.com with SMTP id er20so9127527lab.22
\r
23 for <notmuch@notmuchmail.org>; Tue, 03 Dec 2013 09:29:30 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=AyxMUfch6hzCTdfTip7ttrxAP1UixqxujwYXYX6qSUo=;
\r
29 b=C7ua/2jP7txnbeVwxQVtMR+6saU3sbDaRem+/O9kVMbla3qRoqs2WTIvti4BTBrXZR
\r
30 vqtBAjdrDWCOYIqRdHaRmd1sUnBuWx8HSXkokRgQka4ERbF37pkLpjkHJCiVUxkBwVrL
\r
31 brP8Ld5MaP27I4vvrpXVziDh87stVf5e0Va7OEnh2nJ8cE8SoDUq/vORzlKSSQnDU8qW
\r
32 Af1HDVH163TZHRaWAVVMRRgjG6BAyypAjZoLIcmZg4EDP9qRNMvSjNhLv1LQzFGhzE/h
\r
33 OpNym0Wnijs+FkC6YBvAb1jfJ0Imdam/zMoufuDQ0INyPK1m8h2EbGWZRHjst2GgyLRz
\r
36 ALoCoQkc00zllFj9997RNzx/8ISf2CDEJbJ5VjyUsBxOYmfQzfJs2zVGodFHIr1KixA7NB4AGerB
\r
37 X-Received: by 10.152.242.8 with SMTP id wm8mr76322lac.76.1386091770646;
\r
38 Tue, 03 Dec 2013 09:29:30 -0800 (PST)
\r
39 Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.
\r
40 [88.195.111.91]) by mx.google.com with ESMTPSA id
\r
41 ld10sm17458298lab.8.2013.12.03.09.29.28 for <multiple recipients>
\r
42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
43 Tue, 03 Dec 2013 09:29:29 -0800 (PST)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,
\r
46 notmuch@notmuchmail.org
\r
47 Subject: Re: [PATCH 2/2] lib: introduce notmuch_database_new for initializing
\r
49 In-Reply-To: <m2iov6m3c7.fsf@guru.guru-group.fi>
\r
50 References: <cover.1385903109.git.jani@nikula.org>
\r
51 <fc7ecd990e55fcfba17de4d71e8823c98760f9ce.1385903109.git.jani@nikula.org>
\r
52 <87wqjm2m2q.fsf@zancas.localnet>
\r
53 <m2iov6m3c7.fsf@guru.guru-group.fi>
\r
54 User-Agent: Notmuch/0.16+145~gebbaa94 (http://notmuchmail.org) Emacs/24.3.1
\r
55 (x86_64-pc-linux-gnu)
\r
56 Date: Tue, 03 Dec 2013 19:29:25 +0200
\r
57 Message-ID: <871u1tyhai.fsf@nikula.org>
\r
59 Content-Type: text/plain
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Tue, 03 Dec 2013 17:29:42 -0000
\r
74 On Tue, 03 Dec 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
75 > On Tue, Dec 03 2013, David Bremner <david@tethera.net> wrote:
\r
77 >> The first patch looks ok. I like the new API overall.
\r
79 >> As far as breaking contrib/notmuch-deliver, I'd rather fix
\r
80 >> notmuch-insert than put effort into notmuch-deliver at this point. I
\r
81 >> guess it could be a rough transition for people running notmuch-deliver
\r
84 >> Jani Nikula <jani@nikula.org> writes:
\r
87 >>> + * XXX: error handling should clean up *all* state created!
\r
89 >> is this a warning to future hackers or some current problem?
\r
91 >>> notmuch_status_t
\r
92 >>> -notmuch_database_open (const char *path,
\r
93 >>> - notmuch_database_mode_t mode,
\r
94 >>> - notmuch_database_t **database)
\r
95 >>> +notmuch_database_open (notmuch_database_t *notmuch, const char *path,
\r
96 >>> + notmuch_database_mode_t mode)
\r
98 >>> +/* Initialize a new, empty database handle.
\r
101 >> I wondered about making the new documentation adhere to doxygen?
\r
104 >>> + if (notmuch_database_open (notmuch,
\r
105 >>> + notmuch_config_get_database_path (config),
\r
106 >>> + NOTMUCH_DATABASE_MODE_READ_ONLY))
\r
108 >> Would it make any sense to migrate the mode argument to an option
\r
109 >> setting while we're messing with the API?
\r
111 > if that, then also database_path to options ?
\r
113 See my reply to David.
\r
115 > I also like this suggestion best of all seen so far, but what if:
\r
117 > #define NOTMUCH_MAJOR_VERSION 0
\r
118 > #define NOTMUCH_MINOR_VERSION 17
\r
119 > -#define NOTMUCH_MICRO_VERSION 0
\r
120 > +#define NOTMUCH_MICRO_VERSION 90
\r
122 > until changed API/ABI is set into stone (i.e. 0.18.0 at freeze time).
\r
124 That would require the user to conditional build with:
\r
126 #if NOTMUCH_CHECK_VERSION(0, 17, 90)
\r
127 /* building against post-0.17 git master or released 0.18 */
\r
129 /* building against 0.17 */
\r
132 instead of the IMHO more natural and accurate:
\r
134 #if NOTMUCH_CHECK_VERSION(0, 18, 0)
\r
135 /* building against post-0.17 git master or released 0.18 */
\r
137 /* building against 0.17 */
\r