1 Return-Path: <imain@redhat.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1032C431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 6 Oct 2014 21:17:07 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id OCITKx3T+46O for <notmuch@notmuchmail.org>;
\r
16 Mon, 6 Oct 2014 21:16:59 -0700 (PDT)
\r
17 Received: from cmta19.telus.net (cmta19.telus.net [209.171.16.92])
\r
18 by olra.theworths.org (Postfix) with ESMTP id ACB04431FAE
\r
19 for <notmuch@notmuchmail.org>; Mon, 6 Oct 2014 21:16:59 -0700 (PDT)
\r
20 Received: from ovo.mains.priv ([207.102.88.62]) by cmta19.telus.net with TELUS
\r
21 id 04Gw1p00A1LiWEf014GwRu; Mon, 06 Oct 2014 22:16:58 -0600
\r
22 X-Authority-Analysis: v=2.0 cv=fJznK+me c=1 sm=2
\r
23 a=EcQDfIwDZEqJA1f7rVUV8Q==:17 a=S-IsBHyFrF4A:10 a=IkcTkHD0fZMA:10
\r
24 a=tsa3CZZnAAAA:8 a=YrYOZUNBYV6lC7RO51gA:9 a=QEXdDO2ut3YA:10
\r
25 a=P87eogJZi2UA:10 a=EcQDfIwDZEqJA1f7rVUV8Q==:117
\r
26 X-Telus-Outbound-IP: 207.102.88.62
\r
27 Received: from ovo.mains.priv (localhost.localdomain [127.0.0.1])
\r
28 by ovo.mains.priv (8.14.8/8.14.8) with ESMTP id s974Grn9032621;
\r
29 Mon, 6 Oct 2014 21:16:53 -0700
\r
30 Received: (from imain@localhost)
\r
31 by ovo.mains.priv (8.14.8/8.14.8/Submit) id s974GqdY032620;
\r
32 Mon, 6 Oct 2014 21:16:52 -0700
\r
33 X-Authentication-Warning: ovo.mains.priv: imain set sender to imain@redhat.com
\r
35 Date: Mon, 06 Oct 2014 21:16:52 -0700
\r
36 From: Ian Main <imain@stemwinder.org>
\r
37 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
38 Message-ID: <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch>
\r
39 In-Reply-To: <m27g0dt5lk.fsf@guru.guru-group.fi>
\r
40 References: <1412617904-27252-1-git-send-email-imain@stemwinder.org>
\r
41 <1412619036-29203-1-git-send-email-imain@stemwinder.org>
\r
42 <m27g0dt5lk.fsf@guru.guru-group.fi>
\r
43 Subject: Re: [PATCH] VIM: Make an option to save sent mail locally
\r
45 Content-Type: text/plain;
\r
47 Content-Transfer-Encoding: 7bit
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Tue, 07 Oct 2014 04:17:07 -0000
\r
63 > On Mon, Oct 06 2014, Ian Main <imain@stemwinder.org> wrote:
\r
65 > > Add an option to use 'notmuch insert' to save your sent mail.
\r
68 > > Add -inbox as well.
\r
70 > > vim/notmuch.vim | 17 +++++++++++++++++
\r
71 > > 1 file changed, 17 insertions(+)
\r
73 > > diff --git a/vim/notmuch.vim b/vim/notmuch.vim
\r
74 > > index 331e930..a9044c4 100644
\r
75 > > --- a/vim/notmuch.vim
\r
76 > > +++ b/vim/notmuch.vim
\r
77 > > @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y'
\r
78 > > let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S'
\r
79 > > let s:notmuch_reader_default = 'mutt -f %s'
\r
80 > > let s:notmuch_sendmail_default = 'sendmail'
\r
81 > > +let s:notmuch_save_sent_locally_default = 1
\r
82 > > let s:notmuch_folders_count_threads_default = 0
\r
84 > > function! s:new_file_buffer(type, fname)
\r
85 > > @@ -108,6 +109,18 @@ EOF
\r
90 > AFAIU looks mmm. readable ;)
\r
93 > > + if g:notmuch_save_sent_locally
\r
94 > > + let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox')
\r
96 > as this is (looks like) shell invocation, this could be in format
\r
98 > let out = system('notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)
\r
100 You are right, that's better.
\r
104 > let out = system('exec notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)
\r
106 > (well, the latter would be out of the status quo)
\r
108 > Ok, I looked a bit into the notmuch.vim -code, and noticed sometimes
\r
109 > system() command lines use "notmuch" and sometimes g:notmuch_cmd
\r
110 > -- I think the latter should be used in new code and the previous ones
\r
113 > i.e. system ( g:notmuch_cmd . ' insert ... ' < . fname)
\r
115 > Totally untested from my part...
\r
117 > When the change alike this lands to the notmuch repository this needs NEWS
\r
118 > item which informs that from now sent mails are notmuch-inserted to
\r
119 > user's mail store (as this seems to be the default...) -- well, let's see
\r
120 > that when there are real reviewers (i.e. those who are interested to and can
\r
123 Also a good suggestion. From what I see they always use 'notmuch' straight up
\r
124 which is probably a reasonable assumption. I do think the actual init code for
\r
125 vim could have a few more checks, such as verifying that 'notmuch' is in $PATH
\r
128 Thanks for the review!! I'll send out a new rev tomorrow - very tired right now.
\r