1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 25043431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 09:03:53 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id dfn02u-yn0SJ for <notmuch@notmuchmail.org>;
\r
16 Wed, 18 Apr 2012 09:03:48 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 476AF431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 09:03:48 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 2C46068056; Wed, 18 Apr 2012 19:03:45 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Felipe Contreras <felipe.contreras@gmail.com>
\r
24 Subject: Re: [PATCH] vim: simplify build
\r
26 <CAMP44s0icH2UfnmFJ9=DDGKUzs4jNLHdnHBZ9Yxnd-Ka2nor_A@mail.gmail.com>
\r
27 References: <1334751115-7216-1-git-send-email-felipe.contreras@gmail.com>
\r
28 <m2ty0hxk0p.fsf@guru.guru-group.fi>
\r
29 <CAMP44s3wmEnP=iMQY0gvNKPNAQnMVgCGmkqqaD+L3Fd8nhnMGQ@mail.gmail.com>
\r
30 <871unlgk7h.fsf@zancas.localnet>
\r
31 <m2sjg1dp51.fsf@guru.guru-group.fi>
\r
32 <CAMP44s0icH2UfnmFJ9=DDGKUzs4jNLHdnHBZ9Yxnd-Ka2nor_A@mail.gmail.com>
\r
33 User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1
\r
34 (x86_64-unknown-linux-gnu)
\r
35 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
36 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
37 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
38 Date: Wed, 18 Apr 2012 19:03:44 +0300
\r
39 Message-ID: <m2ty0huivz.fsf@guru.guru-group.fi>
\r
41 Content-Type: text/plain; charset=utf-8
\r
42 Content-Transfer-Encoding: quoted-printable
\r
43 Cc: notmuch@notmuchmail.org
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Wed, 18 Apr 2012 16:03:53 -0000
\r
58 On Wed, Apr 18 2012, Felipe Contreras <felipe.contreras@gmail.com> wrote:
\r
60 > On Wed, Apr 18, 2012 at 6:40 PM, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
61 >> On Wed, Apr 18 2012, David Bremner <david@tethera.net> wrote:
\r
63 >>> Felipe Contreras <felipe.contreras@gmail.com> writes:
\r
64 >>>>> If this is not an issue, then LGTM.
\r
66 >>>> I don't know, I have always used $(PWD), unless anybody else prefers
\r
67 >>>> $(CURDIR), I'll push that.
\r
69 >>> I think CURDIR is better; if only because it is the standard (GNU) make
\r
70 >>> way of doing things [1]. =C2=A0I'm not sure if there is a functional
\r
71 >>> difference or not. At least CURDIR definitely works with make -C [2]
\r
73 >> I read some web pages and then did an experiment; GNU make (v 3.77+)
\r
74 >> has builtin variable $(CURDIR). $(PWD) gets value from environment:
\r
76 >> doing the following:
\r
78 >> $ cat > foo.mk <<EOF
\r
80 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0pwd=3D`pwd`; echo $pwd
\r
81 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0echo $(CURDIR)
\r
82 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0echo $(PWD)
\r
84 >> $ PWD=3D make -f foo.mk
\r
85 >> pwd=3D`pwd`; echo $pwd
\r
87 > Agh! Complete confusion. Add an '@' before echo =3D/
\r
89 Actually I wonder where one '$' was lose in line pwd=3D`pwd`; echo $$pwd
\r
91 >> So, most portable option would be using pwd=3D`pwd`; echo $pwd
\r
92 >> construct in the makefile. Next option would be using $(CURDIR)
\r
93 >> and it works with -C (and with original bourne shell which does
\r
94 >> not manage $PWD). That is GNU make (v 3.77+) spesific but the makefiles
\r
95 >> use GNU make constructs elsewhere too.
\r
97 > I think `pwd` is overkill. I vote for $(CURDIR), although $$PWD
\r
98 > wouldn't be bad either.
\r
100 So, $(CURDIR) has 3 votes :D
\r