70/6b9416422be47e44da66d8f84d17f0e04ea68f

   1 Return-Path: <kfogel@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 012E7431FAF\r
   6         for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 11:18:35 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.699\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
  13         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id ZkhlBvtnOVzc for <notmuch@notmuchmail.org>;\r
  17         Sat,  5 Jul 2014 11:18:27 -0700 (PDT)\r
  18 Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com\r
  19         [209.85.160.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id DF1FF431FB6\r
  22         for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 11:18:26 -0700 (PDT)\r
  23 Received: by mail-yk0-f180.google.com with SMTP id 131so1084496ykp.39\r
  24         for <notmuch@notmuchmail.org>; Sat, 05 Jul 2014 11:18:26 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
  26         h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to\r
  27         :message-id:user-agent:mime-version:content-type;\r
  28         bh=ZaHBGawieH2CY3uvXtQ0xHZCGYY4BRSt4HhwLJeUmFM=;\r
  29         b=gE2efH3xZEzUQK7NOurHJzEABSPbqLQqh5NDQK0LkBLoN4HnqMJcIGsd8u0EZmC7rL\r
  30         QY1a0XNR6Jxbw9QFjKGXJlAPILcRSIdJLiDExLNUGbPCOiekpl4bsGAzM9PSsfwMmH3F\r
  31         H8xmnSifhqNIC+NwishAnZCYAWh974DOtYFFI6PaifURFYoSWnT+xThBEYDxiJFFRD9r\r
  32         9S59W4j2uz9Q2TWYEPupO/a6ZMhMb4l/KTdkEGNOp+SnBdBcxCGQ2BNUIk6HD7VyDmIQ\r
  33         VSZK4miPFrB7b2zwyuf0ETMrH6M4oJnYXNCq9WeMlNJyB/N7ltqNCbbbCHqfwVSNj2Nk\r
  34         q+tA==\r
  35 X-Received: by 10.236.25.105 with SMTP id y69mr27170845yhy.33.1404584305188;\r
  36         Sat, 05 Jul 2014 11:18:25 -0700 (PDT)\r
  37 Received: from floss.red-bean.com ([2602:30a:2ea0:cc50:8ea9:82ff:febf:1dce])\r
  38         by mx.google.com with ESMTPSA id d44sm4648819yhh.13.2014.07.05.11.18.23\r
  39         for <multiple recipients>\r
  40         (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
  41         Sat, 05 Jul 2014 11:18:24 -0700 (PDT)\r
  42 Sender: Karl Fogel <kfogel@gmail.com>\r
  43 From: Karl Fogel <kfogel@red-bean.com>\r
  44 To: Sebastian Lipp <bacuh@riseup.net>\r
  45 Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
  46         notmuch-address.el.\r
  47 References: <87wqsfik5l.fsf@floss.red-bean.com>\r
  48         <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com>\r
  49         <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
  50         <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
  51         <m2hajgxli5.fsf@guru.guru-group.fi> <87vc7vgbym.fsf@zancas.localnet>\r
  52         <m2ehejykb1.fsf@guru.guru-group.fi>\r
  53         <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  54         <87oax6vt4u.fsf@ktab.red-bean.com>\r
  55         <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  56 Date: Sat, 05 Jul 2014 13:18:22 -0500\r
  57 In-Reply-To:\r
  58  <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  59         (Sebastian Lipp's message of "Fri, 04 Jul 2014 11:25:38 +0200")\r
  60 Message-ID: <87d2djr7o1.fsf@floss.red-bean.com>\r
  61 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)\r
  62 MIME-Version: 1.0\r
  63 Content-Type: text/plain\r
  64 Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 Reply-To: Karl Fogel <kfogel@red-bean.com>\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Sat, 05 Jul 2014 18:18:35 -0000\r
  79 \r
  80 Sebastian Lipp <bacuh@riseup.net> writes:\r
  81 >No, it happened by intention because what is "original" to you is not\r
  82 >part of my freshly cloned notmuch. So I thought good practise is to\r
  83 >construct *one* patch that brings the already fixed feature to the\r
  84 >notmuch codebase to keep it clean.\r
  85 >\r
  86 >If you like better, my next patch will only base Tomis and your\r
  87 >suggestions on top of the "original" patch.\r
  88 \r
  89 Oh, I had thought the changes were already in the notmuch tree.  Now I\r
  90 understand what you're saying, and yes, it makes sense.\r
  91 \r
  92 In general, supplying a log message with the patch with avoid such\r
  93 confusion.  If there is some prose expressing what the change is\r
  94 supposed to to, and giving any historical context (such as the mailing\r
  95 list thread starting from last year), then it will be easy for any\r
  96 reviewer to understand what the patch is intended to do, and check if it\r
  97 actually does that.\r
  98 \r
  99 Best,\r
 100 -Karl\r