1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1E972431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 8 Jun 2013 01:39:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ATRUZqM9ODHI for <notmuch@notmuchmail.org>;
\r
16 Sat, 8 Jun 2013 01:38:52 -0700 (PDT)
\r
17 Received: from mail-la0-f50.google.com (mail-la0-f50.google.com
\r
18 [209.85.215.50]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 2A02F431FAE
\r
21 for <notmuch@notmuchmail.org>; Sat, 8 Jun 2013 01:38:52 -0700 (PDT)
\r
22 Received: by mail-la0-f50.google.com with SMTP id dy20so2167767lab.37
\r
23 for <notmuch@notmuchmail.org>; Sat, 08 Jun 2013 01:38:49 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type:content-transfer-encoding
\r
28 :x-gm-message-state;
\r
29 bh=RV06Ozouq+uIlGc8sSydBwGQpBAo0z9G5anpOUtneZ4=;
\r
30 b=meiU9k83+5B8E4S+64jyeCXLhTmXWym9lEMnjSAYDYOUL14giXUzvrM/EeOC9WvAs4
\r
31 V1O9jEKTtJBk3jeJ08tihCu8fEotxU3TDsjQ0adGGv1QA9pJqlYZf3WPQy+opJU57HLR
\r
32 uZR/ubuQ30a3vu+1OIdpuLZQM+TTFv9ZOQ0DLp2JdvbxNxzR2caFXvM3OoUxrRmwADas
\r
33 6aBmsLuPnAYXyEAMf2C4NuKIZlGnVLmW2kTN4ax6CToDPBquwUFefdVkJdKzMLZZdfgp
\r
34 N037A9i5Ib2mpbLGDiqctKbnqKnDT7RWLwWYEwbsypBytQSKWSgWHh440DcmHngfIpXT
\r
36 X-Received: by 10.112.142.228 with SMTP id rz4mr2723193lbb.62.1370680729195;
\r
37 Sat, 08 Jun 2013 01:38:49 -0700 (PDT)
\r
38 Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi.
\r
40 by mx.google.com with ESMTPSA id i2sm819731lah.5.2013.06.08.01.38.47
\r
41 for <multiple recipients>
\r
42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
43 Sat, 08 Jun 2013 01:38:48 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH v2 1/1] cli: Guard deprecated g_type_init calls
\r
47 In-Reply-To: <1370630473-2033-1-git-send-email-tomi.ollila@iki.fi>
\r
48 References: <1370630473-2033-1-git-send-email-tomi.ollila@iki.fi>
\r
49 User-Agent: Notmuch/0.15.2+175~g44e86f1 (http://notmuchmail.org) Emacs/24.3.1
\r
50 (x86_64-pc-linux-gnu)
\r
51 Date: Sat, 08 Jun 2013 11:38:45 +0300
\r
52 Message-ID: <878v2lro8a.fsf@nikula.org>
\r
54 Content-Type: text/plain; charset=utf-8
\r
55 Content-Transfer-Encoding: quoted-printable
\r
57 ALoCoQmlpsJh+REXGxG6wdwZV3i5p9WV5IcIb1dLDSjV0YOLiOuhEtiAdeVUhHobDVKJ9UAiPMDW
\r
58 Cc: tomi.ollila@iki.fi
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Sat, 08 Jun 2013 08:39:00 -0000
\r
73 On Fri, 07 Jun 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
74 > g_type_init was deprecated in GLib 2.35.1. In order to compile
\r
75 > cleanly, guard these with a suitable #if.
\r
77 Looks good, tests pass.
\r
83 > (commit msg from https://bugs.freedesktop.org/attachment.cgi?id=3D73774 )
\r
86 > v2 of id:1370614090-1715-1-git-send-email-tomi.ollila@iki.fi
\r
88 > database.cc was not caught by my na=C3=AFve grep g_type_init **/*.c
\r
89 > (have to learn git grep !)
\r
91 > also added back one newline removed in v1
\r
93 > lib/database.cc | 2 ++
\r
95 > 2 files changed, 4 insertions(+)
\r
97 > diff --git a/lib/database.cc b/lib/database.cc
\r
98 > index 52ed618..5cc0765 100644
\r
99 > --- a/lib/database.cc
\r
100 > +++ b/lib/database.cc
\r
101 > @@ -649,7 +649,9 @@ notmuch_database_open (const char *path,
\r
104 > /* Initialize the GLib type system and threads */
\r
105 > +#if !GLIB_CHECK_VERSION(2, 35, 1)
\r
109 > /* Initialize gmime */
\r
110 > if (! initialized) {
\r
111 > diff --git a/notmuch.c b/notmuch.c
\r
112 > index 99ddd6d..45a73ce 100644
\r
115 > @@ -291,7 +291,9 @@ main (int argc, char *argv[])
\r
116 > local =3D talloc_new (NULL);
\r
119 > +#if !GLIB_CHECK_VERSION(2, 35, 1)
\r
123 > /* Globally default to the current output format version. */
\r
124 > notmuch_format_version =3D NOTMUCH_FORMAT_CUR;
\r
128 > _______________________________________________
\r
129 > notmuch mailing list
\r
130 > notmuch@notmuchmail.org
\r
131 > http://notmuchmail.org/mailman/listinfo/notmuch
\r