1 Return-Path: <stlman@poczta.fm>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D101D431FC0
\r
6 for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:54:23 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.001 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id iT9xvaR9TzK7 for <notmuch@notmuchmail.org>;
\r
17 Sat, 13 Dec 2014 13:54:20 -0800 (PST)
\r
18 Received: from smtpo.poczta.interia.pl (smtpo.poczta.interia.pl
\r
20 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id CD71B431FB6
\r
23 for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:54:19 -0800 (PST)
\r
24 X-Interia-R: Interia
\r
25 X-Interia-R-IP: 89.65.17.18
\r
26 X-Interia-R-Helo: <[192.168.0.13]>
\r
27 Received: from [192.168.0.13] (89-65-17-18.dynamic.chello.pl [89.65.17.18])
\r
28 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
\r
29 (No client certificate requested)
\r
30 by www.poczta.fm (INTERIA.PL) with ESMTPSA;
\r
31 Sat, 13 Dec 2014 22:54:13 +0100 (CET)
\r
32 Message-ID: <548CB582.4040807@poczta.fm>
\r
33 Date: Sat, 13 Dec 2014 22:54:10 +0100
\r
34 From: Lukasz Stelmach <stlman@poczta.fm>
\r
35 User-Agent: Mozilla/5.0 (X11; Linux x86_64;
\r
36 rv:24.0) Gecko/20100101 Thunderbird/24.8.0
\r
38 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
39 Subject: Re: [PATCH] emacs: do not change users' mail agent configuration
\r
40 References: <1418410466-26604-1-git-send-email-stlman@poczta.fm>
\r
41 <87k31vqn1h.fsf@nikula.org>
\r
42 In-Reply-To: <87k31vqn1h.fsf@nikula.org>
\r
43 X-Enigmail-Version: 1.6
\r
44 Content-Type: multipart/signed; micalg=pgp-sha1;
\r
45 protocol="application/pgp-signature";
\r
46 boundary="ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno"
\r
47 X-Interia-Antivirus: OK
\r
48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl;
\r
49 s=biztos; t=1418507657;
\r
50 bh=i7gIN3tSTyu21pHIMc2mVsl3au3iddZxzgKXHzzhUrI=;
\r
51 h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Message-ID:Date:From:
\r
52 User-Agent:MIME-Version:To:Subject:References:In-Reply-To:
\r
53 X-Enigmail-Version:Content-Type:X-Interia-Antivirus;
\r
54 b=BfBEkSdTnm96mUrPupzw7MjaiuCweld6/npVGJiSF3tEYxur08utj6iHea3GzoZ1b
\r
55 REmiItDG7HCy6vtqlUzAF+OtIKmYEAwgC5qztcPFK+Dycf6ZzvsM4IWZKlfbuHDEL+
\r
56 JjNBVNQcZ01L27k9ZOBc0IHd8KnFzBTCNozvZRdo=
\r
57 X-Mailman-Approved-At: Sun, 14 Dec 2014 02:51:22 -0800
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Sat, 13 Dec 2014 21:54:24 -0000
\r
72 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
\r
73 --ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno
\r
74 Content-Type: text/plain; charset=UTF-8
\r
75 Content-Transfer-Encoding: quoted-printable
\r
77 On 13.12.2014 22:04, Jani Nikula wrote:
\r
78 > On Fri, 12 Dec 2014, =C5=81ukasz Stelmach <stlman@poczta.fm> wrote:
\r
79 >> `mail-user-agent' is defined with defcustom and may be customised
\r
80 >> by users. It should not be set to arbitrary values in modules.
\r
84 >> To make use of that configuration value call `compose-mail' which
\r
85 >> starts user's preferred mail composition package as selected with
\r
86 >> the variable `mail-user-agent' instead of notmuch's hardcoded
\r
89 > So your proposed change is that `notmuch-mua-mail` should start
\r
90 > whichever mua the user has configured in `mail-user-agent` instead of
\r
91 > the notmuch mail composition window, as described in the function
\r
92 > documentation? I don't think I like that either.
\r
94 > Maybe we should let bind `mail-user-agent` instead?
\r
97 Actually `message-mail` isn't a "notmuch mail composition window" but
\r
98 rather a "mail composition window" implemented in message.el which is a
\r
99 part of Emacs. Even more, it is the default "mail composition window"
\r
100 in Emacs because the default value of `mail-user-agent`, as defined in
\r
101 simple.el, is `message-user-agent` (since Emacs 23.3 as described in a
\r
102 comment in `compose-mail` function therein) which causes to be launched b=
\r
106 TL;DR with the mail-user-agent variable set to the default value nothing
\r
107 changes for a notmuch user.
\r
110 >> NEWS | 10 ++++++++++
\r
111 >> emacs/notmuch-mua.el | 2 +-
\r
112 >> emacs/notmuch.el | 2 --
\r
113 >> 3 files changed, 11 insertions(+), 3 deletions(-)
\r
115 >> diff --git a/NEWS b/NEWS
\r
116 >> index 44e8d05..cf5b3c3 100644
\r
119 >> @@ -64,6 +64,16 @@ Added `notmuch address` subcommand
\r
123 >> +Fixed `mail-user-agent` handling
\r
125 >> + The value of the mail-user-agent variable is not forcibly set to
\r
126 >> + `notmuch-user-agent`, regardles of how a user has customised it,
\r
127 >> + everytime notmuch.el is loaded. This way, someone who used for exam=
\r
129 >> + Gnus has her MUA and notmuch just as a search engine, doesn't have =
\r
131 >> + configuration broken everytime notmuch.el is loaded. The user can n=
\r
133 >> + use her favourite mail composing package when replying messages in
\r
136 > I understand you're annoyed at the current behaviour, but please don't
\r
137 > pour that annoyance into notmuch NEWS. Thank you.
\r
139 It wasn't my intention. I wasn't even sure I should add to NEWS anything
\r
140 at all but the "Contributing" page says to update NEWS if a change is
\r
141 user visible. Considering what I wrote above, do you think it is visible?=
\r
150 >> Use the `j` key to access saved searches from anywhere in notmuch
\r
152 >> `j` is now globally bound to `notmuch-jump`, which provides fast,
\r
153 >> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
154 >> index 2c58886..f02c7b5 100644
\r
155 >> --- a/emacs/notmuch-mua.el
\r
156 >> +++ b/emacs/notmuch-mua.el
\r
157 >> @@ -263,7 +263,7 @@ OTHER-ARGS are passed through to `message-mail'."
\r
158 >> (push (cons 'From (concat
\r
159 >> (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) =
\r
162 >> - (apply #'message-mail to subject other-headers other-args)
\r
163 >> + (apply #'compose-mail to subject other-headers other-args)
\r
164 >> (message-sort-headers)
\r
165 >> (message-hide-headers)
\r
166 >> (set-buffer-modified-p nil)
\r
167 >> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
168 >> index 218486a..80cab57 100644
\r
169 >> --- a/emacs/notmuch.el
\r
170 >> +++ b/emacs/notmuch.el
\r
171 >> @@ -1037,8 +1037,6 @@ notmuch buffers exist, run `notmuch'."
\r
172 >> (switch-to-buffer first))
\r
175 >> -(setq mail-user-agent 'notmuch-user-agent)
\r
177 >> (provide 'notmuch)
\r
179 >> ;; After provide to avoid loops if notmuch was require'd via notmuch-=
\r
184 >> _______________________________________________
\r
185 >> notmuch mailing list
\r
186 >> notmuch@notmuchmail.org
\r
187 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r
192 By=C5=82o mi bardzo mi=C5=82o. Twoje oczy lubi=C4=85 mn=
\r
194 >=C5=81ukasz< i to mnie zgubi (c)SNL=
\r
197 REKLAMA: http://ars-fabrica.eu/ sklep z r=C4=99kodzie=C5=82em
\r
200 --ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno
\r
201 Content-Type: application/pgp-signature; name="signature.asc"
\r
202 Content-Description: OpenPGP digital signature
\r
203 Content-Disposition: attachment; filename="signature.asc"
\r
205 -----BEGIN PGP SIGNATURE-----
\r
207 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
\r
209 iQEcBAEBAgAGBQJUjLWCAAoJEAC2l2xjkdNxPPUIAK7AkzXhtzZvblz29RnvmiNU
\r
210 FDTpf3RxmqDNCuUcQ6ZumPZbyrgHTtIPAiOVEv+KFH2oIZDbJDGmwKl6bAkWqboP
\r
211 S+WJbkLqXK5R4pFqEAuE68sZMXjOc861qpsadHC1RX/Cys4K+ULhNljpcmCTkUpL
\r
212 AVUJcPOdigjYANlqA+4TwAHMnfOONVLHJfv/K5r9E/D1vqW3cVCg2acD2v1mZOma
\r
213 3y1aR6OA2JPd0tZZxB13emHCr89QFYOF3O5yPvk4lr1mApUt7leZZJpfZTjS6N6+
\r
214 2Jc7KZY8jjagB6j5jl6LT/XMahXa4v//tQTh+FTCoPLkenee9PFxgS3iAm6ZiWI=
\r
216 -----END PGP SIGNATURE-----
\r
218 --ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno--
\r