6f/8708757b1cbdb8b69c4cdf2f33af9c73fc3702

   1 Return-Path: <davidben@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 8FE264196F0\r
   6         for <notmuch@notmuchmail.org>; Thu,  3 Jun 2010 17:29:48 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0.8\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_50=0.8]\r
  12         autolearn=ham\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id VPvcA0852iE9 for <notmuch@notmuchmail.org>;\r
  16         Thu,  3 Jun 2010 17:29:38 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 54717431FC1\r
  20         for <notmuch@notmuchmail.org>; Thu,  3 Jun 2010 17:29:38 -0700 (PDT)\r
  21 X-AuditID: 12074423-b7c0bae0000030f0-ed-4c0848f1ba27\r
  22 Received: from mailhub-auth-4.mit.edu (MAILHUB-AUTH-4.MIT.EDU [18.7.62.39])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Brightmail Gateway) with\r
  24         SMTP id 1E.E8.12528.1F8480C4; Thu,  3 Jun 2010 20:29:37 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id o540TaSO028733\r
  27         for <notmuch@notmuchmail.org>; Thu, 3 Jun 2010 20:29:36 -0400\r
  28 Received: from localhost.localdomain (ET-SIXTY.MIT.EDU [18.208.1.60])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as davidben@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id o540TWgG011376\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)\r
  33         for <notmuch@notmuchmail.org>; Thu, 3 Jun 2010 20:29:36 -0400 (EDT)\r
  34 From: David Benjamin <davidben@MIT.EDU>\r
  35 To: notmuch@notmuchmail.org\r
  36 Subject: [PATCH] Don't involve the shell in notmuch searches\r
  37 Date: Thu,  3 Jun 2010 20:29:32 -0400\r
  38 Message-Id: <1275611372-5810-1-git-send-email-davidben@mit.edu>\r
  39 X-Mailer: git-send-email 1.7.1.1.gee92\r
  40 X-Brightmail-Tracker: AAAAAA==\r
  41 X-BeenThere: notmuch@notmuchmail.org\r
  42 X-Mailman-Version: 2.1.13\r
  43 Precedence: list\r
  44 List-Id: "Use and development of the notmuch mail system."\r
  45         <notmuch.notmuchmail.org>\r
  46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  47         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  49 List-Post: <mailto:notmuch@notmuchmail.org>\r
  50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  52         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  53 X-List-Received-Date: Fri, 04 Jun 2010 00:29:48 -0000\r
  54 \r
  55 The shell isn't needed to interpret any of the arguments, so don't\r
  56 bother using it at all.\r
  57 \r
  58 Signed-off-by: David Benjamin <davidben@mit.edu>\r
  59 ---\r
  60  emacs/notmuch.el |    4 ++--\r
  61  1 files changed, 2 insertions(+), 2 deletions(-)\r
  62 \r
  63 diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
  64 index 57e1140..874ccb9 100644\r
  65 --- a/emacs/notmuch.el\r
  66 +++ b/emacs/notmuch.el\r
  67 @@ -710,10 +710,10 @@ The optional parameters are used as follows:\r
  68        (erase-buffer)\r
  69        (goto-char (point-min))\r
  70        (save-excursion\r
  71 -       (let ((proc (start-process-shell-command\r
  72 +       (let ((proc (start-process\r
  73                      "notmuch-search" buffer notmuch-command "search"\r
  74                      (if oldest-first "--sort=oldest-first" "--sort=newest-first")\r
  75 -                    (shell-quote-argument query))))\r
  76 +                    query)))\r
  77           (set-process-sentinel proc 'notmuch-search-process-sentinel)\r
  78           (set-process-filter proc 'notmuch-search-process-filter))))\r
  79      (run-hooks 'notmuch-search-hook)))\r
  80 -- \r
  81 1.7.1.1.gee92\r
  82 \r