1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 37DC5429E25
\r
6 for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:34:57 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id OQlkweQgBCTm for <notmuch@notmuchmail.org>;
\r
17 Sun, 11 Dec 2011 02:34:56 -0800 (PST)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9E6CE431FB6
\r
22 for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:34:56 -0800 (PST)
\r
23 Received: by bkat8 with SMTP id t8so4707026bka.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:34:53 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=VNP2MMS6gPDFhxq3/X8GIr0NjM9p+nwX2SVxYJfhB5M=;
\r
29 b=MgOkMw8/P9FtlmDHmd0ub/GcLI4dLuCRl9J5FKb4Mzpl9mVVcmAWL00H6rwxP8gZlR
\r
30 0WjxcIeuduAHbnUmxCyQkj26qRnMTEYsWxIHCDCc5WJEL4yPY8MrL+QYGXxseycy6ebh
\r
31 P1n4qrDo3WplW8PZeqkBGJM+m2uyZsH5qLmT4=
\r
32 Received: by 10.204.155.150 with SMTP id s22mr1401922bkw.140.1323599693718;
\r
33 Sun, 11 Dec 2011 02:34:53 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id d2sm22884304bky.11.2011.12.11.02.34.51
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sun, 11 Dec 2011 02:34:52 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree
\r
42 In-Reply-To: <1323460468-4030-5-git-send-email-amdragon@mit.edu>
\r
43 References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>
\r
44 <1323460468-4030-1-git-send-email-amdragon@mit.edu>
\r
45 <1323460468-4030-5-git-send-email-amdragon@mit.edu>
\r
46 User-Agent: Notmuch/0.10.2+82~g96a629c (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Sun, 11 Dec 2011 14:34:18 +0400
\r
49 Message-ID: <87ehwb75xx.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Sun, 11 Dec 2011 10:34:57 -0000
\r
68 I enjoyed reviewing this patch. It is a pleasure to see how complex and
\r
69 confusing code becomes much smaller and cleaner.
\r
71 I still have some questions with the new code. It seems confusing to me
\r
72 that part_content is called first and then go envelope headers. But I
\r
73 this is just the first step of the rewrite, right? :)
\r
75 The only comment I have:
\r
77 + format->part_content (part);
\r
79 For all other format members that are function pointers, we have a check
\r
80 for NULL. Perhaps we should add it here as well?
\r