[PATCH v2 04/14] cli/reply: unify reply format functions

[notmuch-archives.git] / 6d / d04cadb33d5ba78f7b7a9e9016a5134ad39c5b

Return-Path: <pieter@praet.org>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id DB801431FAF\r
        for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 12:37:25 -0800 (PST)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: -0.7\r
X-Spam-Level: \r
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
        tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id nb2ESdGolk3p for <notmuch@notmuchmail.org>;\r
        Wed,  1 Feb 2012 12:37:25 -0800 (PST)\r
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
        [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
        (No client certificate requested)\r
        by olra.theworths.org (Postfix) with ESMTPS id 03574431FAE\r
        for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 12:37:24 -0800 (PST)\r
Received: by wibhi8 with SMTP id hi8so1320789wib.26\r
        for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 12:37:22 -0800 (PST)\r
Received: by 10.180.24.105 with SMTP id t9mr99507wif.19.1328128642555;\r
        Wed, 01 Feb 2012 12:37:22 -0800 (PST)\r
Received: from localhost ([109.131.39.11])\r
        by mx.google.com with ESMTPS id q2sm35342124wiy.7.2012.02.01.12.37.21\r
        (version=TLSv1/SSLv3 cipher=OTHER);\r
        Wed, 01 Feb 2012 12:37:21 -0800 (PST)\r
From: Pieter Praet <pieter@praet.org>\r
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
Subject: Re: emacs: quote MML tags in replies\r
In-Reply-To: <87d39ymyb4.fsf@gmail.com>\r
References: <1326998589-37187-1-git-send-email-aaronecay@gmail.com>\r
        <1328064581-13949-1-git-send-email-dmitry.kurochkin@gmail.com>\r
        <87vcnq64ra.fsf@praet.org> <87d39ymyb4.fsf@gmail.com>\r
User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1\r
        (x86_64-unknown-linux-gnu)\r
Date: Wed, 01 Feb 2012 21:35:26 +0100\r
Message-ID: <87ipjqb8c1.fsf@praet.org>\r
MIME-Version: 1.0\r
Content-Type: text/plain; charset=us-ascii\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Wed, 01 Feb 2012 20:37:26 -0000\r
\r
On Wed, 01 Feb 2012 18:18:55 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
> On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet <pieter@praet.org> wrote:\r
> > On Wed,  1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
> > > Hi Aaron.\r
> > > \r
> > > Thanks for your work!  I took the liberty to do some cleanups for your\r
> > > patch.  Below is a detailed list of changes.\r
> > > \r
> > \r
> > Thanks to the both of you!\r
> > \r
> > \r
> > > Hope this helps.\r
> > > \r
> > > Changes since v2:\r
> > > \r
> > > * change patch names to be consistent with others:\r
> > > \r
> > >   - s/emacs:/test:/ for the test patch\r
> > > \r
> > >   - lower case the first word after colon in the patch title\r
> > > \r
> > > * polish NEWS wording, move it to 0.12 section\r
> > > \r
> > > * add comment to `mml-quote-region' call, as suggested by Tomi [1]\r
> > > \r
> > > * fix and clean up the test:\r
> > > \r
> > >   - set `notmuch-fcc-dirs' to nil to avoid adding the Fcc header,\r
> > >     otherwise it breaks the test on other systems as pointed by\r
> > >     David [2]\r
> > > \r
> > \r
> > Could also have been avoided by adding the expected result inline,\r
> > and using "Fcc: $(pwd)/mail/sent".  I'll send an updated patch to\r
> > that effect.\r
> > \r
> \r
> I do not understand how this is better.  [...]\r
\r
Well, the expected output is only 7 lines, so we might as well keep it\r
inside the test itself (of which the advantages need no reiteration),\r
and doing so would allow us to get the Fcc path in a more future-proof way;\r
`notmuch-fcc-dirs' is more susceptible to deprecation than $MAIL_DIR et al.\r
\r
\r
> [...] But please do not use $(pwd)\r
> here.  I know that other tests do that in the same case, but it is\r
> wrong.  There is $MAIL_DIR variable for this.  See "notmuch-fcc-dirs set\r
> to a string" test for an example.\r
> \r
\r
Good point!  Patch follows.\r
\r
\r
> Regards,\r
>   Dmitry\r
> \r
> > \r
> > >   - use default values for add_message parameters where possible\r
> > > \r
> > >   - use a sane subject value in add_message\r
> > > \r
> > >   - use shorter MML tag as produced by (mml-insert-part)\r
> > > \r
> > >   - indenting and other minor cleanups\r
> > > \r
> > > Regards,\r
> > >   Dmitry\r
> > > \r
> > > [1] id:"m2wr89ioos.fsf@guru.guru-group.fi"\r
> > > [2] id:"87ehugzycb.fsf@zancas.localnet"\r
> > > \r
> > > _______________________________________________\r
> > > notmuch mailing list\r
> > > notmuch@notmuchmail.org\r
> > > http://notmuchmail.org/mailman/listinfo/notmuch\r
> > \r
> > Despite my comment re Fcc, both LGTM.\r
> > \r
> > \r
> > Peace\r
> > \r
> > -- \r
> > Pieter\r
\r
\r
Peace\r
\r
-- \r
Pieter\r