1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C8E7A431E64
\r
6 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 01:16:33 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Z6MjTOqkvwnj for <notmuch@notmuchmail.org>;
\r
16 Mon, 30 Jan 2012 01:16:33 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 3F7F3431FBC
\r
21 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 01:16:33 -0800 (PST)
\r
22 Received: by wibhi8 with SMTP id hi8so3393731wib.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 01:16:32 -0800 (PST)
\r
24 Received: by 10.180.85.105 with SMTP id g9mr7338379wiz.12.1327914992141;
\r
25 Mon, 30 Jan 2012 01:16:32 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id n5sm50401947wiw.7.2012.01.30.01.16.30
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Mon, 30 Jan 2012 01:16:30 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id DDD43A05FB; Mon, 30 Jan 2012 09:16:28 +0000 (GMT)
\r
33 To: Austin Clements <amdragon@MIT.EDU>
\r
34 Subject: Re: [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.
\r
35 In-Reply-To: <20120128050958.GA17991@mit.edu>
\r
36 References: <1327496913-4946-1-git-send-email-dme@dme.org>
\r
37 <1327499314-7887-1-git-send-email-dme@dme.org>
\r
38 <1327499314-7887-2-git-send-email-dme@dme.org>
\r
39 <20120128050958.GA17991@mit.edu>
\r
40 User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 From: David Edmondson <dme@dme.org>
\r
43 Date: Mon, 30 Jan 2012 09:16:24 +0000
\r
44 Message-ID: <cunr4yhim8n.fsf@hotblack-desiato.hh.sledj.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
48 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Mon, 30 Jan 2012 09:16:33 -0000
\r
64 Content-Type: text/plain
\r
65 Content-Transfer-Encoding: quoted-printable
\r
67 On Sat, 28 Jan 2012 00:09:58 -0500, Austin Clements <amdragon@MIT.EDU> wrot=
\r
69 > Quoth David Edmondson on Jan 25 at 1:48 pm:
\r
70 > > There's no need to call `truncate-string-to-width' twice in this code
\r
73 > LGTM if what I point out below is okay. Technically this changes the
\r
74 > behavior of this code, but what it did before was obviously wrong (if
\r
75 > you do roll a new version, I'd mention this in the commit message; but
\r
76 > no need to do that just for this).
\r
79 > > emacs/notmuch.el | 14 ++++++--------
\r
80 > > 1 files changed, 6 insertions(+), 8 deletions(-)
\r
82 > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
83 > > index 3ec0816..3f6b977 100644
\r
84 > > --- a/emacs/notmuch.el
\r
85 > > +++ b/emacs/notmuch.el
\r
86 > > @@ -441,18 +441,16 @@ Complete list of currently available key bindings:
\r
87 > > (interactive "P")
\r
88 > > (let ((thread-id (notmuch-search-find-thread-id))
\r
89 > > (subject (notmuch-search-find-subject)))
\r
91 > > + (if (string-match "^[ \t]*$" subject)
\r
92 > > + (setq subject "[No Subject]"))
\r
95 > Is subject necessarily a string at this point? Previously this only
\r
96 > ran if the code determined there was a thread at point.
\r
98 No, it's a bug. It's fixed in the third patch, but should be fixed here
\r
102 Content-Type: application/pgp-signature
\r
104 -----BEGIN PGP SIGNATURE-----
\r
105 Version: GnuPG v1.4.11 (GNU/Linux)
\r
107 iEYEARECAAYFAk8mX+gACgkQaezQq/BJZRbPSACfdMZJjKihAzVShy5d+6ayyxVU
\r
108 KqwAnjMzV9EQXm52jm9wJDPDbZ/nPceg
\r
110 -----END PGP SIGNATURE-----
\r