1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C590F431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 15:13:09 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id LPzL4B6Z2v3h for <notmuch@notmuchmail.org>;
\r
16 Mon, 10 Dec 2012 15:13:09 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 52D74431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 15:13:09 -0800 (PST)
\r
21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by fire-doxen-postvirus (Postfix) with ESMTP id 5FEF1328009;
\r
23 Mon, 10 Dec 2012 15:13:08 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
\r
25 Received: from finestructure.net (gwave-89.ligo.caltech.edu [131.215.114.89])
\r
26 (Authenticated sender: jrollins)
\r
27 by fire-doxen-submit (Postfix) with ESMTP id E82BE328182;
\r
28 Mon, 10 Dec 2012 15:13:00 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id C3DB661725; Mon, 10 Dec 2012 10:26:44 -0800 (PST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] contrib: pick: bugfix for pick splitting the window
\r
35 In-Reply-To: <1355084249-17523-1-git-send-email-markwalters1009@gmail.com>
\r
36 References: <1355084249-17523-1-git-send-email-markwalters1009@gmail.com>
\r
37 User-Agent: Notmuch/0.14+157~g146ede5 (http://notmuchmail.org) Emacs/24.2.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Mon, 10 Dec 2012 10:26:42 -0800
\r
40 Message-ID: <87fw3dbw65.fsf@servo.finestructure.net>
\r
42 Content-Type: multipart/signed; boundary="=-=-=";
\r
43 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Mon, 10 Dec 2012 23:13:09 -0000
\r
59 Content-Type: text/plain
\r
60 Content-Transfer-Encoding: quoted-printable
\r
62 On Sun, Dec 09 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
63 > Previously if you carried on past the last message in a pick view pick
\r
64 > would get confused and `forget' about the split pane and would try and
\r
65 > re-split when moving up again. This was due to faulty logic in
\r
66 > notmuch-pick-show-message: something that should have been in the (when m=
\r
70 > Thanks to jrollins for the bug report.
\r
73 > A simple bugfix: I can reproduce the bug that jrollins found and this
\r
74 > fixes it for both of us.
\r
80 > contrib/notmuch-pick/notmuch-pick.el | 4 ++--
\r
81 > 1 files changed, 2 insertions(+), 2 deletions(-)
\r
83 > diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/=
\r
85 > index 63776d5..a46ef6e 100644
\r
86 > --- a/contrib/notmuch-pick/notmuch-pick.el
\r
87 > +++ b/contrib/notmuch-pick/notmuch-pick.el
\r
88 > @@ -402,8 +402,8 @@ Does NOT change the database."
\r
89 > (with-selected-window notmuch-pick-message-window
\r
90 > (setq current-prefix-arg '(4))
\r
91 > (setq buffer (notmuch-show id nil nil nil)))
\r
92 > - (notmuch-pick-tag-update-display (list "-unread")))
\r
93 > - (setq notmuch-pick-message-buffer buffer)))
\r
94 > + (notmuch-pick-tag-update-display (list "-unread"))
\r
95 > + (setq notmuch-pick-message-buffer buffer))))
\r
97 > (defun notmuch-pick-show-message-out ()
\r
98 > "Show the current message (in whole window)."
\r
100 Sorry, I should have responded to this immediately. This is a bug fix,
\r
101 and I've tested it and it works perfectly.
\r
106 Content-Type: application/pgp-signature
\r
108 -----BEGIN PGP SIGNATURE-----
\r
109 Version: GnuPG v1.4.12 (GNU/Linux)
\r
111 iQIcBAEBCAAGBQJQxiliAAoJEO00zqvie6q8VPkP/1l82GOEFf+d2SGEVRiw+3h4
\r
112 md3z+SJfcagY1XpGdxo2/Q0UqkrjZ8m4rJdmkCYOseBosGqaF6nXNCKoikE/4a2b
\r
113 pY1ryqZIK4dtsiUF5UuQxRJ6ppWPKDrycyoEQtxR0nzD6grSfYvsLeUXDoNn8CDL
\r
114 SziONi1L18hCvLoNeMQ/uZEbX2C0dRbvn+tOwtDrjJeGPu8TsN3rqDkg0/ihekil
\r
115 oRaFd4nxVrqRhOTi9RS8VsCQFZsl+vfG2og5d8RFvUWTvSDdlAVKCKBGt0LRseS5
\r
116 4ZL2bTcvxzaeBe3b5vV2224RPxNsTPh6yzJHJGmbe2LEmYUuzlteniuikW4pBz0G
\r
117 fW+DNesTSUCHmjWsq4hTEe4LTiJes1QQ+nm0Yt59hR8l0FIOyixZH8Gj8BuoL7Zw
\r
118 8dGV27nBdE2gPt+TSAzEMMQEBXMnGHmu/CAnO8bK4uXNDGpDKoTaaVOWhh4h1NBN
\r
119 07zelTM6GOtmpPFBGh/zjV2lbqujTeq3kTetiNmpFryfvRYCXk3TeOEBz6bUUl29
\r
120 LHvCHdqkBj3hP3dTk1KbZvEW9A4bwjEkiJBHs4oCDPE5xXlHk3Lf8qsM38tEmiKH
\r
121 gC7iT3VCjt7AICfeAm80qcAUUwAX0dSLqgGRMHHPgLBHGJGht5iIWWp4kn2Xwl8c
\r
122 MxdNGDNTQWe2f/POkEVK
\r
124 -----END PGP SIGNATURE-----
\r