1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5E03541ED91
\r
6 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 08:19:32 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8KbbO9zephL6 for <notmuch@notmuchmail.org>;
\r
16 Tue, 31 Jan 2012 08:19:31 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 963E2429E5B
\r
20 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 08:19:31 -0800 (PST)
\r
21 X-AuditID: 1209190e-b7f7c6d0000008c3-97-4f28149115a0
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 07.D0.02243.194182F4; Tue, 31 Jan 2012 11:19:29 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0VGJTD7024293;
\r
27 Tue, 31 Jan 2012 11:19:29 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0VGJSv9026689
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Tue, 31 Jan 2012 11:19:28 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RsGPj-0004BU-4J; Tue, 31 Jan 2012 11:18:35 -0500
\r
37 Date: Tue, 31 Jan 2012 11:18:35 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search.
\r
41 Message-ID: <20120131161835.GD10898@mit.edu>
\r
42 References: <8762fu4aqt.fsf@qmul.ac.uk>
\r
43 <1327862394-14334-1-git-send-email-markwalters1009@gmail.com>
\r
44 <20120131041732.GY17991@mit.edu> <871uqgdrsf.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <871uqgdrsf.fsf@qmul.ac.uk>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT150oouFvcOi8tcXquTwW12/OZHZg
\r
52 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mp4tu8RW8IWvYt28bWwNjIe5uxg5OSQETCRm
\r
53 r7vDCmGLSVy4t56ti5GLQ0hgH6PEokUvmCCcDYwSz2bOZYdwTjJJPHt6AyqzhFHibMcaRpB+
\r
54 FgFViV1/+8BsNgENiW37l4PZIgI6ErcPLWAHsZkFpCW+/W5mArGFBfwkPj+fwAxi8wLVzD4/
\r
55 F8wWEljBKDHpqBhEXFDi5MwnLBC9WhI3/r0E6uUAm7P8HwdImBNo1e2Z/8BaRQVUJKac3MY2
\r
56 gVFoFpLuWUi6ZyF0L2BkXsUom5JbpZubmJlTnJqsW5ycmJeXWqRrrJebWaKXmlK6iREU1pyS
\r
57 fDsYvx5UOsQowMGoxMO7672avxBrYllxZe4hRkkOJiVR3u+CGv5CfEn5KZUZicUZ8UWlOanF
\r
58 hxglOJiVRHjfrAYq501JrKxKLcqHSUlzsCiJ86ppvfMTEkhPLEnNTk0tSC2CycpwcChJ8JYK
\r
59 Aw0VLEpNT61Iy8wpQUgzcXCCDOcBGn5TCKiGt7ggMbc4Mx0if4pRUUqcdzdIswBIIqM0D64X
\r
60 lnZeMYoDvSLMexqkigeYsuC6XwENZgIa/JxBFWRwSSJCSqqB0Zf1VceXmVVL/dx9f3dduvn5
\r
61 359k9kPLz74srPtvL/Gh8VdHtvnWvv/aNX/NpzxhjD/m/XXRn1+KLhtf3hd6F3L1eIq76nL2
\r
62 Snebx03/fnWf3iH58OsXTrc58nzT/s3ef6z730/HyrsMwZ81tk70znwdtqJo1oWezLTEIwc3
\r
63 G4n12aX/nPyqL1+JpTgj0VCLuag4EQCYta9bFgMAAA==
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Tue, 31 Jan 2012 16:19:32 -0000
\r
79 Quoth Mark Walters on Jan 31 at 11:40 am:
\r
81 > Thanks for the review. Almost all of it (for all all the patches) I
\r
82 > agree with and will just fix but I do have a couple of queries.
\r
84 > On Mon, 30 Jan 2012 23:17:32 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
85 > > Quoth Mark Walters on Jan 29 at 6:39 pm:
\r
86 > > > This option turns off the exclusion so all matching messages are
\r
87 > > > returned. We do not need to add this to show as notmuch-show does not
\r
88 > > > (yet) exclude.
\r
90 > > > notmuch-count.c | 12 ++++++++----
\r
91 > > > notmuch-search.c | 12 ++++++++----
\r
92 > > > 2 files changed, 16 insertions(+), 8 deletions(-)
\r
94 > > > diff --git a/notmuch-count.c b/notmuch-count.c
\r
95 > > > index 63459fb..c88975e 100644
\r
96 > > > --- a/notmuch-count.c
\r
97 > > > +++ b/notmuch-count.c
\r
98 > > > @@ -37,6 +37,7 @@ notmuch_count_command (void *ctx, int argc, char *argv[])
\r
99 > > > int output = OUTPUT_MESSAGES;
\r
100 > > > const char **search_exclude_tags;
\r
101 > > > size_t search_exclude_tags_length;
\r
102 > > > + notmuch_bool_t do_not_exclude = FALSE;
\r
103 > > > unsigned int i;
\r
105 > > > notmuch_opt_desc_t options[] = {
\r
106 > > > @@ -44,6 +45,7 @@ notmuch_count_command (void *ctx, int argc, char *argv[])
\r
107 > > > (notmuch_keyword_t []){ { "threads", OUTPUT_THREADS },
\r
108 > > > { "messages", OUTPUT_MESSAGES },
\r
109 > > > { 0, 0 } } },
\r
110 > > > + { NOTMUCH_OPT_BOOLEAN, &do_not_exclude, "do-not-exclude", 'd', 0 },
\r
112 > > Maybe just "no-exclude"? "do-not-exclude" seems needlessly verbose.
\r
114 > The reason I went for verbose do-not-exclude was to try and avoid the
\r
115 > double negative ambiguity: does no-exclude mean do-not-exclude or
\r
116 > do-note-return-excluded-messages. Possibly I am worrying needlessly, and
\r
117 > obviously I am quite happy to change.
\r
119 Oh. Hmm. --no-exclusions? --unexcluded? --all?
\r
120 --include-excludes? Maybe --do-not-exclude is best.
\r