1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6A055429E33
\r
6 for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 00:27:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id b9AQd8wTXhfi for <notmuch@notmuchmail.org>;
\r
16 Fri, 6 Jan 2012 00:27:26 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 74F4C429E32
\r
21 for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 00:27:26 -0800 (PST)
\r
22 Received: by werm12 with SMTP id m12so1121267wer.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 06 Jan 2012 00:27:23 -0800 (PST)
\r
24 Received: by 10.216.131.141 with SMTP id m13mr2657354wei.30.1325838443696;
\r
25 Fri, 06 Jan 2012 00:27:23 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id em4sm67411213wbb.20.2012.01.06.00.27.20
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Fri, 06 Jan 2012 00:27:21 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id 5E091A1734; Fri, 6 Jan 2012 08:27:19 +0000 (GMT)
\r
33 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] emacs: Helpers for notmuch developers.
\r
35 In-Reply-To: <878vllxzwt.fsf@zancas.localnet>
\r
36 References: <1325685678-12710-1-git-send-email-dme@dme.org>
\r
37 <878vllxzwt.fsf@zancas.localnet>
\r
38 User-Agent: Notmuch/0.10.2+151~gbf1dc2b (http://notmuchmail.org)
\r
39 Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
\r
40 From: David Edmondson <dme@dme.org>
\r
41 Date: Fri, 06 Jan 2012 08:27:15 +0000
\r
42 Message-ID: <cunhb0944nw.fsf@hotblack-desiato.hh.sledj.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Fri, 06 Jan 2012 08:27:27 -0000
\r
61 Content-Type: text/plain
\r
62 Content-Transfer-Encoding: quoted-printable
\r
64 On Thu, 05 Jan 2012 23:39:30 -0400, David Bremner <david@tethera.net> wrote:
\r
65 > > General management (i.e. keeping up to date) of the repository it uses
\r
66 > > is your responsibility, as is cleaning out old branches. You can, of
\r
67 > > course, just delete the temporary repository after using it - the code
\r
68 > > will re-create it next time.
\r
70 > maybe the branches could be under some namespace that makes this easy?
\r
72 Just a prefix? 'review/' or something?
\r
74 > > +(defvar notmuch-dev-temporary-repository-name (concat "notmuch-dev-" (=
\r
76 > > + "The name of the temporary repository.")
\r
78 > Do we care about security at all in this context? I'm always a bit
\r
79 > nervous about creating predictably named files/directories in publicly
\r
82 I presume that you'd already have set `temporary-file-directory' if you
\r
83 worry about this generally, or `notmuch-dev-temporary-directory' if just
\r
86 > > + ;; Causes us to switch to the magit buffer - is that unfortunate in
\r
87 > > + ;; some situations?
\r
88 > > + (magit-status notmuch-dev-temporary-repository-path))
\r
90 > I found it to be a pleasant surprise.
\r
92 Ending there when the whole sequence completes, I agree. The question is
\r
93 really about whether displaying the magit-status buffer after simply
\r
94 creating the repository is good.
\r
96 > > + (shell-command
\r
98 > > + notmuch-command " show --format=3Dmbox " (shell-quote-argument search=
\r
101 > > + "git am --quiet"))
\r
104 > Hmm. A knee jerk reaction is not to like this, like seeing system in C
\r
105 > code. But I don't have a better solution off hand.
\r
107 Agreed. I think that I'll split it into two parts:
\r
108 - running notmuch to create a mailbox (or perhaps directory of
\r
110 - running git-am to apply the patches.
\r
112 A bigger problem is that magit appears to be ignorant of git-am, with
\r
113 the result that if applying the patches fails magit doesn't provide any
\r
114 help (or even notification) that there are outstanding things to do. It
\r
115 also blocks a future git-am.
\r
117 Currently thinking about an alternative to using git-am that is more
\r
121 Content-Type: application/pgp-signature
\r
123 -----BEGIN PGP SIGNATURE-----
\r
124 Version: GnuPG v1.4.11 (GNU/Linux)
\r
126 iEYEARECAAYFAk8GsGMACgkQaezQq/BJZRaAqQCeLWxt7y5MAPU5Mnpkphg0co/G
\r
127 1pcAn10Mk7G7H+DqL1RzuHmI4/teWxJ1
\r
129 -----END PGP SIGNATURE-----
\r