6a/d87fd5d34776a41a468762c3b5491734074b69

   1 Return-Path: <jrollins@finestructure.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id B912E4196F0\r
   6         for <notmuch@notmuchmail.org>; Wed, 28 Apr 2010 14:33:23 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -4.19\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-4.19 tagged_above=-999 required=5\r
  12         tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01]\r
  13         autolearn=ham\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id hMH1Ovt7K+nf for <notmuch@notmuchmail.org>;\r
  17         Wed, 28 Apr 2010 14:33:22 -0700 (PDT)\r
  18 Received: from brinza.cc.columbia.edu (brinza.cc.columbia.edu [128.59.29.8])\r
  19         by olra.theworths.org (Postfix) with ESMTP id CE17B431FC1\r
  20         for <notmuch@notmuchmail.org>; Wed, 28 Apr 2010 14:33:22 -0700 (PDT)\r
  21 Received: from servo.finestructure.net (cpe-72-227-128-66.nyc.res.rr.com\r
  22         [72.227.128.66])\r
  23         (user=jgr2110 author=jrollins@finestructure.net mech=PLAIN bits=0)\r
  24         by brinza.cc.columbia.edu (8.14.3/8.14.3) with ESMTP id o3SLXMUu012333\r
  25         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT)\r
  26         for <notmuch@notmuchmail.org>; Wed, 28 Apr 2010 17:33:22 -0400 (EDT)\r
  27 Received: from jrollins by servo.finestructure.net with local (Exim 4.71)\r
  28         (envelope-from <jrollins@finestructure.net>) id 1O7Esj-0000Yf-SL\r
  29         for notmuch@notmuchmail.org; Wed, 28 Apr 2010 17:33:21 -0400\r
  30 From: Jameson Rollins <jrollins@finestructure.net>\r
  31 To: Notmuch Mail list <notmuch@notmuchmail.org>\r
  32 Subject: Re: [PATCH] Remove bcc header from notmuch reply.\r
  33 In-Reply-To: <87r5pcad5v.fsf@servo.finestructure.net>\r
  34 References: <87r5pcad5v.fsf@servo.finestructure.net>\r
  35 User-Agent: Notmuch/0.3-12-g78345c5 (http://notmuchmail.org) Emacs/23.1.1\r
  36         (i486-pc-linux-gnu)\r
  37 Date: Wed, 28 Apr 2010 17:33:18 -0400\r
  38 Message-ID: <87d3xjxnxd.fsf@servo.finestructure.net>\r
  39 MIME-Version: 1.0\r
  40 Content-Type: multipart/signed; boundary="=-=-=";\r
  41         micalg=pgp-sha256; protocol="application/pgp-signature"\r
  42 X-No-Spam-Score: Local\r
  43 X-Scanned-By: MIMEDefang 2.68 on 128.59.29.8\r
  44 X-BeenThere: notmuch@notmuchmail.org\r
  45 X-Mailman-Version: 2.1.13\r
  46 Precedence: list\r
  47 List-Id: "Use and development of the notmuch mail system."\r
  48         <notmuch.notmuchmail.org>\r
  49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  50         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  52 List-Post: <mailto:notmuch@notmuchmail.org>\r
  53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  55         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  56 X-List-Received-Date: Wed, 28 Apr 2010 21:33:23 -0000\r
  57 \r
  58 --=-=-=\r
  59 Content-Transfer-Encoding: quoted-printable\r
  60 \r
  61 Notmuch reply should not be Bcc'ing the sender by default.  This is\r
  62 not the appropriate way to save copies of sent mail (which should\r
  63 probably be handled by an Fcc header) and it doesn't give the user the\r
  64 option to not be bcc'd.  This is really something that should be\r
  65 handled by the reader UI.  For instance, emacs message-mode can easily\r
  66 be configured to add Bcc's if the user wishes.\r
  67 =2D--\r
  68 Now that we finally have good built-in fcc support, we can finally get\r
  69 rid of the annoying bcc in notmuch-reply.\r
  70 \r
  71 This is a resubmit of an old patch that has been rebased against the\r
  72 current head of cworth/master.\r
  73 \r
  74  notmuch-reply.c |    9 +--------\r
  75  1 files changed, 1 insertions(+), 8 deletions(-)\r
  76 \r
  77 diff --git a/notmuch-reply.c b/notmuch-reply.c\r
  78 index fd1de3b..856d5e9 100644\r
  79 =2D-- a/notmuch-reply.c\r
  80 +++ b/notmuch-reply.c\r
  81 @@ -267,8 +267,7 @@ add_recipients_from_message (GMimeMessage *reply,\r
  82      } reply_to_map[] =3D {\r
  83         { "reply-to", "from", GMIME_RECIPIENT_TYPE_TO  },\r
  84         { "to",         NULL, GMIME_RECIPIENT_TYPE_TO  },\r
  85 =2D     { "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  },\r
  86 =2D     { "bcc",        NULL, GMIME_RECIPIENT_TYPE_BCC }\r
  87 +       { "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  }\r
  88      };\r
  89      const char *from_addr =3D NULL;\r
  90      unsigned int i;\r
  91 @@ -481,9 +480,6 @@ notmuch_reply_format_default(void *ctx, notmuch_config_=\r
  92 t *config, notmuch_query_\r
  93         g_mime_object_set_header (GMIME_OBJECT (reply),\r
  94                                   "From", from_addr);\r
  95 =20\r
  96 =2D     g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",\r
  97 =2D                        notmuch_config_get_user_primary_email (config));\r
  98 =2D\r
  99         in_reply_to =3D talloc_asprintf (ctx, "<%s>",\r
 100                              notmuch_message_get_message_id (message));\r
 101 =20\r
 102 @@ -558,9 +554,6 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_co=\r
 103 nfig_t *config, notmuch_q\r
 104 =20\r
 105         (void)add_recipients_from_message (reply, config, message);\r
 106 =20\r
 107 =2D     g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",\r
 108 =2D                        notmuch_config_get_user_primary_email (config));\r
 109 =2D\r
 110         reply_headers =3D g_mime_object_to_string (GMIME_OBJECT (reply));\r
 111         printf ("%s", reply_headers);\r
 112         free (reply_headers);\r
 113 =2D-=20\r
 114 1.7.0\r
 115 \r
 116 --=-=-=\r
 117 Content-Type: application/pgp-signature\r
 118 \r
 119 -----BEGIN PGP SIGNATURE-----\r
 120 Version: GnuPG v1.4.10 (GNU/Linux)\r
 121 \r
 122 iQIcBAEBCAAGBQJL2KmeAAoJEO00zqvie6q8V3YP/2DTdhIE8/T9gXgplKVpvVNw\r
 123 G+YthrYTZN0yzLTJiU16zXIIYxsXVpn+Qf1wdDYKck341sWnTxSBY/F6DWzFBB3B\r
 124 Ubq7pRHjUmaz/JmSes6uwSdgb/dLBz+dVmZEPkeg36IFLasMNoEinWjXdfgDT8+C\r
 125 h4qlzj7XCkU6Et6bi+SIztgCa5P89+CEcAAVFalxqt02JmMw5tJNNGacucCdAcFv\r
 126 VbgghjQYaXE4Jw5n8mT+IazZJg/O98prV5kgGJisnKGfTVizaipD/4UJ82fnSlI8\r
 127 ovdBbaZWFEgrK0+OEGkVlhSn5aj6dTckbKw83Sm/2jBgQqn4gF1CDDS2G+f0kg4X\r
 128 Z/QKm523pAiay2AU9BIUlT2yKO0gKDWtdEPZJzBvUWo8Mml/DviSgL9UbZSNAUK7\r
 129 ajHLUBRVW60rhNiSPUEyzSppikBMsgtsKrbxuo5FTRLRU9NG1ty0oqXCvqyP/h3Z\r
 130 DoaXWDe6BX/LlzpZ8oDkw5G8LDOkGKeyHYow24nEhYRviUWq3hrMP3p2LJZSXFj3\r
 131 THx7g3HxlX+BbP8dY65dR08tXBAYY+xoOIYKl6kTY0ngkkKDje1doce686G5ghuw\r
 132 wo//LmOsPuCLYcv953KUoFLzEGhJfAG7reeM/8Qgta3B9BQu6cTb38JKLQygjUTw\r
 133 rc7o6QTIsFTNcQzemAa6\r
 134 =klOe\r
 135 -----END PGP SIGNATURE-----\r
 136 --=-=-=--\r