1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7CDA1429E5F
\r
6 for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 01:09:56 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id GURif5Ut-t8C for <notmuch@notmuchmail.org>;
\r
16 Wed, 18 Jan 2012 01:09:55 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 49BBD429E27
\r
21 for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 01:09:55 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0I98tVr010590
\r
24 for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:09:53 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs18vmu-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT)
\r
28 for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:09:53 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
32 for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:09:53 +0200
\r
33 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
34 To: <notmuch@notmuchmail.org>
\r
35 Subject: Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.
\r
36 In-Reply-To: <cund3aipdr1.fsf@hotblack-desiato.hh.sledj.net>
\r
37 References: <87pqei327k.fsf@gmail.com>
\r
38 <1326809224-22673-1-git-send-email-dme@dme.org>
\r
39 <1326809224-22673-2-git-send-email-dme@dme.org>
\r
40 <87zkdmwfi7.fsf@gmail.com>
\r
41 <cund3aipdr1.fsf@hotblack-desiato.hh.sledj.net>
\r
42 User-Agent: Notmuch/0.11+71~gefa5d6c (http://notmuchmail.org) Emacs/23.3.1
\r
44 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
45 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
46 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
47 Date: Wed, 18 Jan 2012 11:09:52 +0200
\r
48 Message-ID: <yf6wr8p4brz.fsf@taco2.nixu.fi>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
52 1.0.211, 0.0.0000 definitions=2012-01-18_04:2012-01-17, 2012-01-18,
\r
53 1970-01-01 signatures=0
\r
54 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
55 ipscore=0 suspectscore=1
\r
56 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
58 scancount=1 engine=6.0.2-1012030000 definitions=main-1201180018
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Wed, 18 Jan 2012 09:09:56 -0000
\r
73 On Tue, 17 Jan 2012 15:09:22 +0000, David Edmondson <dme@dme.org> wrote:
\r
74 > On Tue, 17 Jan 2012 18:49:36 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
75 > > > + # We cannot call 'test_emacs' in a subshell, because
\r
76 > > > + # the setting of EMACS_SERVER would not persist
\r
77 > > > + # throughout a sequence of tests, so we use a
\r
78 > > > + # temporary file.
\r
79 > > > + tmp="$TMPDIR"; if [ -z "$tmp" ]; then tmp=/tmp; fi
\r
80 > > > + output="$tmp/test_emacs_output.$$"
\r
81 > > > + test_emacs "$1" > "${output}"
\r
82 > > > + result=$(cat "${output}")
\r
83 > > > + rm -f "${output}"
\r
85 > > I wonder if there is any bash trick which can help here?
\r
87 > I'm not aware of one, but I'm not a bash expert.
\r
89 No shell trick possible there.
\r
92 > > Another option is to start emacs server before using test_emacs in
\r
93 > > subshell. See emacs-subject-to-filename for an example. I think this
\r
94 > > is a better option than using a temporary file.
\r
96 > I think that's a very poor option. Forcing knowledge the breakage into
\r
97 > all of the users may make applying any future fix more difficult.
\r
99 The alternative would be to replace
\r
100 emacsclient --socket-name="$EMACS_SERVER" --eval "(progn $@)"
\r
102 with something like:
\r
104 case $1 in --stdout-to-output)
\r
106 output=$(emacsclient --socket-name="$EMACS_SERVER" --eval "(progn $@)")
\r
109 emacsclient --socket-name="$EMACS_SERVER" --eval "(progn $@)"
\r