1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AF1D4431FAE
\r
6 for <notmuch@notmuchmail.org>; Sun, 12 Feb 2012 13:50:02 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id mH2M9GAb+7kz for <notmuch@notmuchmail.org>;
\r
17 Sun, 12 Feb 2012 13:50:02 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D8CDE429E52
\r
22 for <notmuch@notmuchmail.org>; Sun, 12 Feb 2012 13:50:01 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1RwhJ2-0006wo-9M; Sun, 12 Feb 2012 21:50:00 +0000
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1RwhJ2-0003EA-0n; Sun, 12 Feb 2012 21:50:00 +0000
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
34 notmuch@notmuchmail.org
\r
35 Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view
\r
37 In-Reply-To: <878vk73hxq.fsf@servo.finestructure.net>
\r
38 References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com>
\r
39 <878vk73hxq.fsf@servo.finestructure.net>
\r
40 User-Agent: Notmuch/0.11.1+192~g23e894e (http://notmuchmail.org) Emacs/23.2.1
\r
42 Date: Sun, 12 Feb 2012 21:51:20 +0000
\r
43 Message-ID: <87zkcnra93.fsf@qmul.ac.uk>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 X-Sender-Host-Address: 94.192.233.223
\r
47 X-QM-SPAM-Info: Sender has good ham record. :)
\r
48 X-QM-Body-MD5: 40fbea20fc0f6804767c4a549cc463f6 (of first 20000 bytes)
\r
49 X-SpamAssassin-Score: -1.8
\r
50 X-SpamAssassin-SpamBar: -
\r
51 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
53 spam. We require at least 5.0 points to mark a message as spam.
\r
54 This message scored -1.8 points.
\r
55 Summary of the scoring:
\r
56 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
58 * [138.37.6.40 listed in list.dnswl.org]
\r
59 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
60 provider * (markwalters1009[at]gmail.com)
\r
61 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
63 * 0.5 AWL AWL: From: address is in the auto white-list
\r
64 X-QM-Scan-Virus: ClamAV says the message is clean
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Sun, 12 Feb 2012 21:50:02 -0000
\r
79 On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
80 > On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
81 > > Here is a rebased version of the notmuch-pick patch set
\r
82 > > id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly
\r
83 > > to master since Jani's notmuch-show command line parsing
\r
84 > > has been pushed.
\r
86 > Hey, Mark. Thanks for working on this. However, none of the patches
\r
87 > have commit messages, so there's no explanation for what any of the
\r
88 > patches are supposed to do. This is particularly bothersome for the
\r
89 > first patch, which introduces a lot of unexplained changes to the cli.
\r
91 > I think I would like to review this patch set, since I think I'm
\r
92 > interested in the functionality it may be introducing, but without any
\r
93 > commit messages or explanation what the patches are meant to do it's
\r
94 > kind of a non starter for me.
\r
98 At the moment I was mostly looking for feedback on whether people like
\r
99 the final outcome (i.e., whether people liked it enough to be worth
\r
100 tidying). I will add comments on the first two patches.
\r