1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EF920431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 11:41:35 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id weRxJIocihnp for <notmuch@notmuchmail.org>;
\r
16 Thu, 19 Jan 2012 11:41:35 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 48E69431FAE
\r
20 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 11:41:35 -0800 (PST)
\r
21 X-AuditID: 1209190d-b7fbf6d0000008ba-75-4f1871ee7925
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id D2.FB.02234.EE1781F4; Thu, 19 Jan 2012 14:41:34 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0JJfYTw015024;
\r
27 Thu, 19 Jan 2012 14:41:34 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0JJfXWS013778
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Thu, 19 Jan 2012 14:41:33 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@MIT.EDU>)
\r
36 id 1RnxrH-00045q-OP; Thu, 19 Jan 2012 14:41:15 -0500
\r
37 Date: Thu, 19 Jan 2012 14:41:15 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Pieter Praet <pieter@praet.org>
\r
40 Subject: Re: [PATCH 1/4] search: rename auto_exclude_tags to
\r
41 {search,}exclude_tags
\r
42 Message-ID: <20120119194115.GO16740@mit.edu>
\r
43 References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
\r
44 <1327000744-25463-1-git-send-email-pieter@praet.org>
\r
45 <1327000744-25463-2-git-send-email-pieter@praet.org>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <1327000744-25463-2-git-send-email-pieter@praet.org>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1n1XKOFvcH2uucX1mzOZLX6/vsHs
\r
53 wOTxbNUtZo+OfZdZA5iiuGxSUnMyy1KL9O0SuDLWdc1gKnjBWXH18jaWBsYb7F2MnBwSAiYS
\r
54 t+e+ZISwxSQu3FvP1sXIxSEksI9R4uOPSewQzgZGiZnP/jJDOCeZJGY/aGeBcJYwSpw8/was
\r
55 n0VAVWL+jTMsIDabgIbEtv3LweIiAsoSp5/8BNvHLKAlsXXjB7C4sECIxJXVU8HivAI6Ej+m
\r
56 90GtW8co8Wj+WTaIhKDEyZlPWGCab/x7ydTFyAFkS0ss/8cBYnIKOEqc3SACUiEqoCIx5eQ2
\r
57 tgmMQrOQNM9C0jwLoXkBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXSO93MwSvdSU0k2M4MCW
\r
58 5N3B+O6g0iFGAQ5GJR7eRHcJfyHWxLLiytxDjJIcTEqivN0FQCG+pPyUyozE4oz4otKc1OJD
\r
59 jBIczEoivPNygHK8KYmVValF+TApaQ4WJXFeVa13fkIC6YklqdmpqQWpRTBZGQ4OJQneHmAE
\r
60 CwkWpaanVqRl5pQgpJk4OEGG8wANbwep4S0uSMwtzkyHyJ9iVJQS560FSQiAJDJK8+B6YYnn
\r
61 FaM40CvCvGUgVTzApAXX/QpoMBPQYI8mMZDBJYkIKakGxownuuIXpI6VBytFfla9M/FWikiL
\r
62 YuHj5nsVZ4qO7ox6Utik9F7gb8O59cIb5vS1rQ2d9/l4ScD6Jt5qzuq+te9+TLZa+KVG0e9f
\r
63 3e+4ne7tLi3XWTLrJzfYahzuPn7H9Ozhb/Mn+LzaxCd3YV2dT218puCs5UGLVvQ9WjTtmodS
\r
64 y2s2g1WmPkosxRmJhlrMRcWJAJEOwKMXAwAA
\r
65 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Thu, 19 Jan 2012 19:41:36 -0000
\r
80 Quoth Pieter Praet on Jan 19 at 8:19 pm:
\r
81 > All other config-related functions and args include the section
\r
82 > title in their name, so for the sake of consistency, mirror that.
\r
84 > Also, the "auto"matic part is a given, so that was dropped.
\r
86 LGTM other than one nit, below.
\r
88 > --- a/notmuch-config.c
\r
89 > +++ b/notmuch-config.c
\r
90 > @@ -89,9 +89,9 @@ static const char search_config_comment[] =
\r
92 > " The following option is supported here:\n"
\r
94 > - "\tauto_exclude_tags A ;-separated list of tags that will be\n"
\r
95 > - "\t excluded from search results by default. Using an excluded tag\n"
\r
96 > - "\t in a query will override that exclusion.\n";
\r
97 > + "\texclude_tags A list (separated by ';') of the tags that will be\n"
\r
98 > + "\t\texcluded from search results by default. Using an excluded tag in a\n"
\r
99 > + "\t\tquery will override that exclusion.\n";
\r
101 I'd propose that any tag whose name is more than seven characters long
\r
102 should have its description start under it, indented by a tab, like I
\r
103 did in id:"1326920205-31296-1-git-send-email-amdragon@mit.edu". That
\r
104 looks nice and keeps the description indented consistently without
\r
105 ridiculous amounts of negative space and narrow wrapping.
\r