1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1923A431FDA
\r
6 for <notmuch@notmuchmail.org>; Mon, 2 Sep 2013 22:19:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id bfXjYHtr0agA for <notmuch@notmuchmail.org>;
\r
16 Mon, 2 Sep 2013 22:19:10 -0700 (PDT)
\r
17 Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com
\r
18 [74.125.83.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 79063431FDB for <notmuch@notmuchmail.org>; Mon, 2 Sep 2013 22:19:09 -0700
\r
22 Received: by mail-ee0-f42.google.com with SMTP id b45so2732535eek.29
\r
23 for <notmuch@notmuchmail.org>; Mon, 02 Sep 2013 22:19:08 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
\r
28 bh=2MVD0kfw/VpEHl2Bt7NOqEu9VwGCzas/tlONel/gNfE=;
\r
29 b=BX+Eqwo9eucrpqSXfimSianj7FvUiT+V92Q3TVbDoZAxwcbDZ31eW/libHvTrNthH5
\r
30 iVaCgji7edZXhwBJT0jhjdBxPcAzS6ib7YITamFowY1AkLAGNrBqBaihuE4mcD29dw50
\r
31 zTaDqd+cTUoQsQPpperhTiD9RQr9kNbDapIY+Mx3GqhYbmJ9/xUeqbU6CmCdK6Ojh5CD
\r
32 NgFbMmCsjuDmtUyKQoj0/uIKmbKWSQSXevC9CENnYeE0wCepBz4VUDjO0JJdfoJF8buD
\r
33 RR6l6DQ7zvqTyrFH3rF0vGhhqdGQbX1I0OIQ/IjikGbmD489T0ivUEJ9V5SzG9l+Obv4
\r
36 ALoCoQmEyt12CYxYE0/cI4N4axLCVde+9z9YTVMftqx/WkcpRaQRe+OtMlXrOH3h0WHkN9qtnBfG
\r
37 X-Received: by 10.14.3.9 with SMTP id 9mr319544eeg.72.1378185548250;
\r
38 Mon, 02 Sep 2013 22:19:08 -0700 (PDT)
\r
39 Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.
\r
41 by mx.google.com with ESMTPSA id a1sm28245286eem.1.1969.12.31.16.00.00
\r
42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
43 Mon, 02 Sep 2013 22:19:07 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: notmuch@notmuchmail.org
\r
46 Subject: [PATCH 2/2] test: improve insert test reliability by checking
\r
47 message-id instead of count
\r
48 Date: Tue, 3 Sep 2013 08:19:03 +0300
\r
49 Message-Id: <1378185543-25271-2-git-send-email-jani@nikula.org>
\r
50 X-Mailer: git-send-email 1.8.4.rc3
\r
51 In-Reply-To: <1378185543-25271-1-git-send-email-jani@nikula.org>
\r
52 References: <1378170613-3584-1-git-send-email-david@tethera.net>
\r
53 <1378185543-25271-1-git-send-email-jani@nikula.org>
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Tue, 03 Sep 2013 05:19:18 -0000
\r
68 There isn't a reported issue this would fix. Spotted by reading the
\r
71 test/insert | 12 ++++++------
\r
72 1 file changed, 6 insertions(+), 6 deletions(-)
\r
74 diff --git a/test/insert b/test/insert
\r
75 index 9b448e5..550b413 100755
\r
78 @@ -68,14 +68,14 @@ test_expect_equal_json "$output" '["inbox", "unread"]'
\r
79 test_begin_subtest "Insert message, add tag"
\r
81 notmuch insert +custom < "$gen_msg_filename"
\r
82 -output=$(notmuch count tag:custom)
\r
83 -test_expect_equal "$output" "1"
\r
84 +output=$(notmuch search --output=messages tag:custom)
\r
85 +test_expect_equal "$output" "id:$gen_msg_id"
\r
87 test_begin_subtest "Insert message, add/remove tags"
\r
89 notmuch insert +custom -unread < "$gen_msg_filename"
\r
90 -output=$(notmuch count tag:custom NOT tag:unread)
\r
91 -test_expect_equal "$output" "1"
\r
92 +output=$(notmuch search --output=messages tag:custom NOT tag:unread)
\r
93 +test_expect_equal "$output" "id:$gen_msg_id"
\r
95 test_begin_subtest "Insert message with default tags stays in new/"
\r
97 @@ -123,8 +123,8 @@ test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new"
\r
98 test_begin_subtest "Insert message into folder, add/remove tags"
\r
100 notmuch insert --folder=Drafts +draft -unread < "$gen_msg_filename"
\r
101 -output=$(notmuch count folder:Drafts tag:draft NOT tag:unread)
\r
102 -test_expect_equal "$output" "1"
\r
103 +output=$(notmuch search --output=messages folder:Drafts tag:draft NOT tag:unread)
\r
104 +test_expect_equal "$output" "id:$gen_msg_id"
\r
107 test_expect_code 1 "Insert message into non-existent folder" \
\r