Re: [PATCH] emacs: wash: make word-wrap bound message width
[notmuch-archives.git] / 66 / 9d1fbc8e02bc3609add0ba00da4bc0e43a605d
1 Return-Path: <amdragon@mit.edu>\r
2 X-Original-To: notmuch@notmuchmail.org\r
3 Delivered-To: notmuch@notmuchmail.org\r
4 Received: from localhost (localhost [127.0.0.1])\r
5         by olra.theworths.org (Postfix) with ESMTP id 1CE18431FAF\r
6         for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 19:15:50 -0700 (PDT)\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
8 X-Spam-Flag: NO\r
9 X-Spam-Score: -0.7\r
10 X-Spam-Level: \r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
13 Received: from olra.theworths.org ([127.0.0.1])\r
14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
15         with ESMTP id LUp6ZCVRwzAh for <notmuch@notmuchmail.org>;\r
16         Sun,  9 Jun 2013 19:15:42 -0700 (PDT)\r
17 Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
18         [18.9.25.13])\r
19         by olra.theworths.org (Postfix) with ESMTP id 155FB431FAE\r
20         for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 19:15:42 -0700 (PDT)\r
21 X-AuditID: 1209190d-b7fa26d000004bab-10-51b536cbec4c\r
22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
24         id D7.75.19371.BC635B15; Sun,  9 Jun 2013 22:15:39 -0400 (EDT)\r
25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r5A2Fbb7016505; \r
27         Sun, 9 Jun 2013 22:15:38 -0400\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
29         (authenticated bits=0)\r
30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
31         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5A2FYPm029938\r
32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
33         Sun, 9 Jun 2013 22:15:36 -0400\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
35         (envelope-from <amdragon@mit.edu>)\r
36         id 1Ulrdu-00061y-Ix; Sun, 09 Jun 2013 22:15:34 -0400\r
37 Date: Sun, 9 Jun 2013 22:15:34 -0400\r
38 From: Austin Clements <amdragon@MIT.EDU>\r
39 To: Mark Walters <markwalters1009@gmail.com>\r
40 Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error\r
41 Message-ID: <20130610021534.GB22196@mit.edu>\r
42 References: <1370753138-15021-1-git-send-email-amdragon@mit.edu>\r
43         <1370753138-15021-3-git-send-email-amdragon@mit.edu>\r
44         <87hah7od8b.fsf@qmul.ac.uk>\r
45 MIME-Version: 1.0\r
46 Content-Type: text/plain; charset=us-ascii\r
47 Content-Disposition: inline\r
48 In-Reply-To: <87hah7od8b.fsf@qmul.ac.uk>\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)\r
50 X-Brightmail-Tracker:\r
51  H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1j1ttjXQYMpBTovVc3ksrt+cyezA\r
52         5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZaw91c5WcJa9YuNvwwbGbrYuRk4OCQETiSXn\r
53         +5kgbDGJC/fWA8W5OIQE9jFKTJm2BiwhJLCBUeLBwVyIxCkmib6PK1khnCWMEte7P4JVsQio\r
54         SJxZeooZxGYT0JDYtn85I4gtIqAjcfvQAnYQm1lAWuLb72awemEBV4m+M1fBaniBahrnXGCE\r
55         GDqVUeL9r4usEAlBiZMzn7BANGtJ3Pj3EqiZA2zQ8n8cIGFOoF3dq/rAykWBbphychvbBEah\r
56         WUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGukV5uZoleakrpJkZwUEvy7mB8\r
57         d1DpEKMAB6MSD++DX1sChVgTy4orcw8xSnIwKYny5ptuDRTiS8pPqcxILM6ILyrNSS0+xCjB\r
58         wawkwlvQBFTOm5JYWZValA+TkuZgURLnvZJy019IID2xJDU7NbUgtQgmK8PBoSTBuxZkqGBR\r
59         anpqRVpmTglCmomDE2Q4D9BwD5Aa3uKCxNzizHSI/ClGRSlx3l0gCQGQREZpHlwvLOm8YhQH\r
60         ekWYdwpIFQ8wYcF1vwIazAQ0eIo6yNXFJYkIKakGRt6bGvo3A2+xzHqpKnXO8s/l2Q+qLn0P\r
61         dN4Ze001YGJpXlrn//7HzkxHD9Rs0vhzi4WjOVqxM7Xyzbn6jUaOG5Inr7uRJaWtHSWt91La\r
62         LuHprJ+3Nl2L3GZZ32jkGjB3kpBClf1pw+uX3s1zmtPO+3LGpCv5i2fedT4ltOqfecFK3xDe\r
63         SYu0I5VYijMSDbWYi4oTAdMCsfMVAwAA\r
64 Cc: notmuch@notmuchmail.org\r
65 X-BeenThere: notmuch@notmuchmail.org\r
66 X-Mailman-Version: 2.1.13\r
67 Precedence: list\r
68 List-Id: "Use and development of the notmuch mail system."\r
69         <notmuch.notmuchmail.org>\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
73 List-Post: <mailto:notmuch@notmuchmail.org>\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
77 X-List-Received-Date: Mon, 10 Jun 2013 02:15:50 -0000\r
78 \r
79 Quoth Mark Walters on Jun 09 at 10:16 am:\r
80\r
81 > Both of these patches look good to me +1. I was able to reproduce both\r
82 > bugs pretty reliably (the first one always unless masked by the second\r
83 > one which occurred about half the time). With these patches I cannot\r
84 > trigger either. Also all tests pass.\r
85\r
86 > My only tiny concern is I couldn't find any documentation on whether the\r
87 > return value of the filter-function matters at all. Austin's original\r
88 > fix (via irc) returned t and this returns nil in the failing case (i.e.,\r
89 > when results-buf is dead).\r
90 \r
91 Mm, interesting.  To be fair, my choice of "t" for the original fix\r
92 was completely arbitrary.  I think you're right that the Emacs\r
93 documentation doesn't have anything to say about the return values of\r
94 filter functions.  Furthermore, the example filter functions they give\r
95 don't have meaningful return values, so I'm pretty sure this is safe.\r
96 Also the code that calls the filter discards its result.\r