66/5dbc8d2b6c1116e345233d355d19600835cdd2

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5  by arlo.cworth.org (Postfix) with ESMTP id 1273B6DE362A\r
   6  for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 04:40:55 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at cworth.org\r
   8 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References"\r
   9 X-Spam-Flag: NO\r
  10 X-Spam-Score: 0.263\r
  11 X-Spam-Level: \r
  12 X-Spam-Status: No, score=0.263 tagged_above=-999 required=5 tests=[AWL=0.983, \r
  13  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
  14  RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled\r
  15 Received: from arlo.cworth.org ([127.0.0.1])\r
  16  by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
  17  with ESMTP id YT4BtQA3brrt for <notmuch@notmuchmail.org>;\r
  18  Sat, 13 Aug 2016 04:40:47 -0700 (PDT)\r
  19 Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com\r
  20  [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id B97FD6DE396B for\r
  21  <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 04:39:18 -0700 (PDT)\r
  22 Received: by mail-wm0-f68.google.com with SMTP id i138so2004561wmf.3\r
  23  for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 04:39:18 -0700 (PDT)\r
  24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  25  d=nikula-org.20150623.gappssmtp.com; s=20150623;\r
  26  h=from:to:cc:subject:date:message-id:in-reply-to:references\r
  27  :in-reply-to:references;\r
  28  bh=7tsiGkg0FFMzDlQ3hfJSIFhyiHhCYGrgYwx2Ox7gEOc=;\r
  29  b=UVhi+QUjwZw1SZqSrybZOrF0QUN6p93rPTqsnwRVxoSuyRczSn/mAuUUV+ZSSYLLzb\r
  30  zVEd11PFwLpjke4FlbKT7hkP60/fo1SZvUBW4RYs9igqEeYtPLr+FEZBvvdJqvCFNe63\r
  31  de2HWomCUx0Azv7LJFPNgjDfoRvvqp1Gktn2xBq7Dt5EhxGRouyXUlNyFUhQ4pvA+aT2\r
  32  jTbfp+1zv6j5eiwaQk/zW8Wnq8luoyjX8WhRxvrVqjlA52260IG5p1fspCWEqN23WNB+\r
  33  /ycEiLHHBIbPNxkiMr9b/LHFdNPOhmLB30vwKbzzlujBlxp1GBl5gV8j3RNQAFNMAzP6\r
  34  pftw==\r
  35 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  36  d=1e100.net; s=20130820;\r
  37  h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\r
  38  :references:in-reply-to:references;\r
  39  bh=7tsiGkg0FFMzDlQ3hfJSIFhyiHhCYGrgYwx2Ox7gEOc=;\r
  40  b=cIcYV2ZFIRw25/cs1B8N/2U89BHnV4FDLIqZy1BHfLAOhN5L8FrhnqevNHusYInZGC\r
  41  YW5mM+oS1+Yxl9tMUL9JO9kEV/essV1dsoRYNYHycLSQFrbl9IYXKRHxGdWTfb9/yb+P\r
  42  A/lZPMOMMu/eAWbGCZ27652B4l4DGZ9rkUKotzboK+zp0ayJFM7e2kXuh/5LdVtwiP4L\r
  43  U8DxBHM/IXApAyYyPvrnLHknJ89BG/btmE0i7WUgyvCWEol2aKnezE/OnQdp+9/HeD2+\r
  44  ayLwmcs2+069nMHLRbIjnX2JvTpXAnGpnYF4lfyFKShBKSqAPGBio+DO5SkbKvzi4DKv\r
  45  xX/Q==\r
  46 X-Gm-Message-State:\r
  47  AEkoousiAGDDQHyncnqKV9D2U5FdHyQto9YtjrNgJzbQhJdDMuSYzxTyWxSDUzhFHDOJ0w==\r
  48 X-Received: by 10.28.111.4 with SMTP id k4mr3821636wmc.94.1471088357407;\r
  49  Sat, 13 Aug 2016 04:39:17 -0700 (PDT)\r
  50 Received: from localhost (dsl-hkibrasgw2-58c368-70.dhcp.inet.fi.\r
  51  [88.195.104.70])\r
  52  by smtp.gmail.com with ESMTPSA id gg10sm11785883wjd.4.2016.08.13.04.39.16\r
  53  (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  54  Sat, 13 Aug 2016 04:39:17 -0700 (PDT)\r
  55 From: Jani Nikula <jani@nikula.org>\r
  56 To: notmuch@notmuchmail.org\r
  57 Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
  58         jani@nikula.org\r
  59 Subject: [PATCH v2 10/14] cli/reply: check for NULL list first in\r
  60  scan_address_list()\r
  61 Date: Sat, 13 Aug 2016 14:37:34 +0300\r
  62 Message-Id:\r
  63  <275a85feea6afa5226d362f73e193694ea25e0b0.1471088022.git.jani@nikula.org>\r
  64 X-Mailer: git-send-email 2.1.4\r
  65 In-Reply-To: <cover.1471088022.git.jani@nikula.org>\r
  66 References: <cover.1471088022.git.jani@nikula.org>\r
  67 In-Reply-To: <cover.1471088022.git.jani@nikula.org>\r
  68 References: <cover.1471088022.git.jani@nikula.org>\r
  69 X-BeenThere: notmuch@notmuchmail.org\r
  70 X-Mailman-Version: 2.1.20\r
  71 Precedence: list\r
  72 List-Id: "Use and development of the notmuch mail system."\r
  73  <notmuch.notmuchmail.org>\r
  74 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
  75  <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  76 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
  77 List-Post: <mailto:notmuch@notmuchmail.org>\r
  78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  79 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
  80  <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  81 X-List-Received-Date: Sat, 13 Aug 2016 11:40:55 -0000\r
  82 \r
  83 Support passing NULL list later on. Also use it to simplify the\r
  84 recursion.\r
  85 ---\r
  86  notmuch-reply.c | 6 +++---\r
  87  1 file changed, 3 insertions(+), 3 deletions(-)\r
  88 \r
  89 diff --git a/notmuch-reply.c b/notmuch-reply.c\r
  90 index 9b78ea2c2b20..d90f46f9bed3 100644\r
  91 --- a/notmuch-reply.c\r
  92 +++ b/notmuch-reply.c\r
  93 @@ -192,6 +192,9 @@ scan_address_list (InternetAddressList *list,\r
  94      int i;\r
  95      unsigned int n = 0;\r
  96  \r
  97 +    if (list == NULL)\r
  98 +       return 0;\r
  99 +\r
 100      for (i = 0; i < internet_address_list_length (list); i++) {\r
 101         address = internet_address_list_get_address (list, i);\r
 102         if (INTERNET_ADDRESS_IS_GROUP (address)) {\r
 103 @@ -200,9 +203,6 @@ scan_address_list (InternetAddressList *list,\r
 104  \r
 105             group = INTERNET_ADDRESS_GROUP (address);\r
 106             group_list = internet_address_group_get_members (group);\r
 107 -           if (group_list == NULL)\r
 108 -               continue;\r
 109 -\r
 110             n += scan_address_list (group_list, config, message, type, user_from);\r
 111         } else {\r
 112             InternetAddressMailbox *mailbox;\r
 113 -- \r
 114 2.1.4\r
 115 \r