1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 21ECD431FC0
\r
6 for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:39:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id HEA9LtkB++t0 for <notmuch@notmuchmail.org>;
\r
17 Tue, 20 Mar 2012 18:39:58 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 24C07431FAF
\r
22 for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:39:58 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SAAWq-0000jJ-3w; Wed, 21 Mar 2012 01:39:56 +0000
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SAAWp-0001mI-Pp; Wed, 21 Mar 2012 01:39:55 +0000
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,
\r
34 Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
35 Subject: Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{,
\r
37 In-Reply-To: <1330122640-18895-6-git-send-email-pieter@praet.org>
\r
38 References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>
\r
39 <1330122640-18895-1-git-send-email-pieter@praet.org>
\r
40 <1330122640-18895-6-git-send-email-pieter@praet.org>
\r
41 User-Agent: Notmuch/0.12+67~g3bd579a (http://notmuchmail.org) Emacs/23.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Wed, 21 Mar 2012 01:40:08 +0000
\r
44 Message-ID: <87pqc6wx3b.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 X-Sender-Host-Address: 94.192.233.223
\r
48 X-QM-SPAM-Info: Sender has good ham record. :)
\r
49 X-QM-Body-MD5: 36f7c22242a3cc96081baed0ad393f18 (of first 20000 bytes)
\r
50 X-SpamAssassin-Score: -1.8
\r
51 X-SpamAssassin-SpamBar: -
\r
52 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
54 spam. We require at least 5.0 points to mark a message as spam.
\r
55 This message scored -1.8 points.
\r
56 Summary of the scoring:
\r
57 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
59 * [138.37.6.40 listed in list.dnswl.org]
\r
60 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
61 provider * (markwalters1009[at]gmail.com)
\r
62 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
64 * 0.5 AWL AWL: From: address is in the auto white-list
\r
65 X-QM-Scan-Virus: ClamAV says the message is clean
\r
66 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Wed, 21 Mar 2012 01:39:59 -0000
\r
81 On Fri, 24 Feb 2012 23:30:39 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
82 > * emacs/notmuch-show.el
\r
84 > (notmuch-show-get-messages-ids):
\r
85 > If provided with optional arg SEPARATOR, return a string consisting
\r
86 > of all Message-Id's, separated by SEPARATOR. Also improve original
\r
87 > docstring wrt default return value.
\r
89 > (notmuch-show-get-messages-ids-search):
\r
90 > Removed, as its functionality is now in `notmuch-show-get-messages-ids'.
\r
92 > (notmuch-show-tag-all):
\r
93 > Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of
\r
94 > `notmuch-show-get-messages-ids-search'.
\r
96 > emacs/notmuch-show.el | 18 +++++++++---------
\r
97 > 1 files changed, 9 insertions(+), 9 deletions(-)
\r
99 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
100 > index 6adbdc0..05606fc 100644
\r
101 > --- a/emacs/notmuch-show.el
\r
102 > +++ b/emacs/notmuch-show.el
\r
103 > @@ -1339,17 +1339,17 @@ (defun notmuch-show-get-message-id ()
\r
104 > "Return the message id of the current message."
\r
105 > (concat "id:\"" (notmuch-show-get-prop :id) "\""))
\r
107 > -(defun notmuch-show-get-messages-ids ()
\r
108 > - "Return all message ids of messages in the current thread."
\r
109 > +(defun notmuch-show-get-messages-ids (&optional separator)
\r
110 > + "Return a list of Message-Id's of all messages in the current buffer.
\r
112 > +If provided with optional argument SEPARATOR, return a string
\r
113 > +instead, consisting of all Message-Id's separated by SEPARATOR."
\r
114 > (let ((message-ids))
\r
115 > (notmuch-show-mapc
\r
116 > (lambda () (push (notmuch-show-get-message-id) message-ids)))
\r
119 > -(defun notmuch-show-get-messages-ids-search ()
\r
120 > - "Return a search string for all message ids of messages in the
\r
121 > -current thread."
\r
122 > - (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))
\r
124 > + (mapconcat 'identity message-ids separator)
\r
127 > ;; dme: Would it make sense to use a macro for many of these?
\r
129 > @@ -1638,7 +1638,7 @@ (defun notmuch-show-tag-all (&rest tag-changes)
\r
131 > TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
132 > (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))
\r
133 > - (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)
\r
134 > + (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes)
\r
135 > (notmuch-show-mapc
\r
137 > (let* ((current-tags (notmuch-show-get-tags))
\r
139 Oh and I forgot to add that this patch doesn't seem to apply anymore.
\r