1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6184F431FBD
\r
6 for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 00:15:14 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.502 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id WntroLkq75I9 for <notmuch@notmuchmail.org>;
\r
17 Tue, 15 Jul 2014 00:15:07 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id AF983431FBC
\r
22 for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 00:15:07 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1X6wx7-0005wt-BC; Tue, 15 Jul 2014 08:15:05 +0100
\r
27 Received: from [194.42.225.51] (helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1X6wx7-0005vz-0K; Tue, 15 Jul 2014 08:15:05 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] emacs: tree/show remove duplicate function
\r
34 In-Reply-To: <87a98bbfab.fsf@maritornes.cs.unb.ca>
\r
35 References: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com>
\r
36 <87a98bbfab.fsf@maritornes.cs.unb.ca>
\r
37 User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Tue, 15 Jul 2014 08:14:46 +0100
\r
40 Message-ID: <87zjgbw0t5.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 194.42.225.51
\r
44 X-QM-Geographic: According to ripencc,
\r
45 this message was delivered by a machine in Britain (UK) (GB).
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: f364f0d887bda182cce0fdd94454745d (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: -0.1
\r
49 X-SpamAssassin-SpamBar: /
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored -0.1 points.
\r
54 Summary of the scoring:
\r
55 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
56 provider * (markwalters1009[at]gmail.com)
\r
57 * -0.1 AWL AWL: From: address is in the auto white-list
\r
58 X-QM-Scan-Virus: ClamAV says the message is clean
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Tue, 15 Jul 2014 07:15:14 -0000
\r
73 On Tue, 15 Jul 2014, David Bremner <david@tethera.net> wrote:
\r
74 > Mark Walters <markwalters1009@gmail.com> writes:
\r
75 >> + (cond ((eq major-mode 'notmuch-show-mode)
\r
76 >> + (notmuch-show-get-message-properties))
\r
77 >> + ((eq major-mode 'notmuch-tree-mode)
\r
78 >> + (notmuch-tree-get-message-properties))))
\r
80 > I see this already existed, but it looks weird to me to have a two test
\r
81 > cond with no else. Is it intentional to have the code drop through and
\r
82 > do nothing if neither case matches? It seems like it might be better to
\r
85 I can definitely do that. But as a comparison
\r
86 notmuch-search-get-result and notmuch-search-find-thread-id "work" in
\r
87 any buffer in the sense of returning nil but not complaining so perhaps
\r
88 the current version is more consistent.
\r
90 Plausibly a comment and an explicit nil case would be clearer for the other modes.
\r