1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D1AB6429E25
\r
6 for <notmuch@notmuchmail.org>; Tue, 1 Nov 2011 12:55:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MG5X2ccrCGhQ for <notmuch@notmuchmail.org>;
\r
16 Tue, 1 Nov 2011 12:55:37 -0700 (PDT)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 C76AC431FB6 for <notmuch@notmuchmail.org>; Tue, 1 Nov 2011 12:55:36 -0700
\r
22 Received: by wwe6 with SMTP id 6so2311809wwe.2
\r
23 for <notmuch@notmuchmail.org>; Tue, 01 Nov 2011 12:55:35 -0700 (PDT)
\r
24 Received: by 10.216.229.94 with SMTP id g72mr4951117weq.74.1320177333223;
\r
25 Tue, 01 Nov 2011 12:55:33 -0700 (PDT)
\r
26 Received: from localhost ([109.131.187.47])
\r
27 by mx.google.com with ESMTPS id ff6sm81724wbb.10.2011.11.01.12.55.31
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Tue, 01 Nov 2011 12:55:32 -0700 (PDT)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests
\r
33 In-Reply-To: <1317660447-27520-1-git-send-email-schnouki@schnouki.net>
\r
34 References: <871uuuywtt.fsf@convex-new.cs.unb.ca>
\r
35 <1317660447-27520-1-git-send-email-schnouki@schnouki.net>
\r
36 User-Agent: Notmuch/0.9+33~gadde72d (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-unknown-linux-gnu)
\r
38 Date: Tue, 01 Nov 2011 20:54:49 +0100
\r
39 Message-ID: <87ehxrvcs6.fsf@praet.org>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Tue, 01 Nov 2011 19:55:38 -0000
\r
56 On Mon, 3 Oct 2011 18:47:14 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
\r
57 > Here it is: a rebased version of Pieter's patch series adding prereqs for the
\r
58 > emacs and crypto tests [1], and Dmitry's patches for running emacs inside screen
\r
59 > in the test suite [2]. (Please note that this one also includes fixes to improve
\r
60 > hidden signatures handling in notmuch-show-advance-and-archive.)
\r
63 I'm pleased to see these patches haven't moved to binary oblivion yet!
\r
65 > I had to do several changes to the original patches:
\r
66 > - prereqs are not tested using test_expect_success as they were in Pieter's
\r
67 > original patches, but using a new function called test_set_bin_prereq. I wrote
\r
68 > this before the gdb prereq was added, hence the different way to set it.
\r
71 Indeed preferrable to using `test_expect_success' due to no longer
\r
72 overzealously reporting missing prereqs as failures, as well as getting
\r
73 rid of some duplication; This should also be used in the atomicity tests.
\r
75 > - some fixes in Pieter's patches so that it actually works when gpg is not
\r
76 > installed. Can't exactly remember what (...but you can just check his original
\r
77 > patches), but in the end it was working fine in a chroot without gpg.
\r
80 Correct. I only added prereqs to actual tests (i.e. calls to
\r
81 `test_expect_success', `test_expect_equal', and
\r
82 `test_expect_equal_file'), while they should also have been added to
\r
83 both the `add_gnupg_home' function and the initialization of
\r
86 > - I added a little patch to smtp-dummy that makes the test suite work again in
\r
87 > Emacs 24 (tested with emacs-pretest 24.0.90).
\r
89 > Here are the results when running the test suite on my computer:
\r
90 > - without GNU Screen:
\r
91 > All 247 tests behaved as expected (1 expected failure).
\r
93 > - with GNU Screen:
\r
94 > 242/247 tests passed.
\r
95 > 2 broken tests failed as expected.
\r
98 > (The 3 failed tests come from some trouble with Emacs 24, I'll try to fix this
\r
101 > *Many* thanks to Dmitry Kurochkin and Pieter Praet for their work!
\r
104 Thanks to you as well! All this duplication of effort is a real shame
\r
105 though. I'd also have preferred your fixes being in separate commits.
\r
107 I'll be commenting on these modified commits where needed, and have
\r
108 re-submitted my original series (rebased to current master) in a new
\r
114 > [1] id:"1307016220-17509-1-git-send-email-pieter@praet.org"
\r
115 > [2] id:"1309496122-4965-1-git-send-email-dmitry.kurochkin@gmail.com"
\r
117 > Dmitry Kurochkin (7):
\r
118 > test: run emacs inside screen
\r
119 > test: avoid using screen(1) configuration files
\r
120 > test: do not set frame width in emacs
\r
121 > test: `notmuch-show-advance-and-archive' with invisible signature
\r
122 > emacs: improve hidden signatures handling in
\r
123 > notmuch-show-advance-and-archive
\r
124 > emacs: remove no longer used functions from notmuch-show.el
\r
125 > emacs: remove unused `point-invisible-p' function
\r
127 > Pieter Praet (4):
\r
128 > test: add 'GnuPG' prereq to dependent 'crypto' tests
\r
129 > test: add 'Emacs' prereq to dependent 'crypto' tests
\r
130 > test: add 'Emacs' prereq to dependent 'emacs' tests
\r
131 > test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer'
\r
135 > test: define a helper function for defining prereqs on executables
\r
136 > test: make smtp-dummy work with Emacs 24
\r
138 > emacs/notmuch-lib.el | 15 -------
\r
139 > emacs/notmuch-show.el | 25 ++++-------
\r
140 > test/crypto | 46 ++++++++++++++-------
\r
141 > test/emacs | 85 ++++++++++++++++++++++++---------------
\r
142 > test/emacs-large-search-buffer | 9 +++-
\r
143 > test/smtp-dummy.c | 2 +-
\r
144 > test/test-lib.el | 3 -
\r
145 > test/test-lib.sh | 31 +++++++++++++--
\r
146 > 8 files changed, 127 insertions(+), 89 deletions(-)
\r
151 > _______________________________________________
\r
152 > notmuch mailing list
\r
153 > notmuch@notmuchmail.org
\r
154 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
162 [1] id:"1320176954-4897-1-git-send-email-pieter@praet.org"
\r