Re: [PATCH] emacs: wash: make word-wrap bound message width

[notmuch-archives.git] / 64 / 9a2b5d29460ef722c318f3d3fca78017056cb9

Return-Path: <tomi.ollila@iki.fi>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id AB3DE431FBC\r
        for <notmuch@notmuchmail.org>; Wed,  4 Mar 2015 22:57:20 -0800 (PST)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: 2.438\r
X-Spam-Level: **\r
X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
        tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id H0sK-AKcY+-t for <notmuch@notmuchmail.org>;\r
        Wed,  4 Mar 2015 22:57:16 -0800 (PST)\r
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
        by olra.theworths.org (Postfix) with ESMTP id 7D1FE431FAE\r
        for <notmuch@notmuchmail.org>; Wed,  4 Mar 2015 22:57:16 -0800 (PST)\r
Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
        by guru.guru-group.fi (Postfix) with ESMTP id 7D3781000E7;\r
        Thu,  5 Mar 2015 08:56:11 +0200 (EET)\r
From: Tomi Ollila <tomi.ollila@iki.fi>\r
To: "J. Lewis Muir" <jlmuir@imca-cat.org>, notmuch@notmuchmail.org\r
Subject: Re: [PATCH v2] lib: make notmuch shared library install_name be full\r
        path    on Mac OS X\r
In-Reply-To: <1425508369-28448-1-git-send-email-jlmuir@imca-cat.org>\r
References: <1425508369-28448-1-git-send-email-jlmuir@imca-cat.org>\r
User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1\r
        (x86_64-unknown-linux-gnu)\r
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
        $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
        !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
Date: Thu, 05 Mar 2015 08:56:11 +0200\r
Message-ID: <m24mq0nd9w.fsf@guru.guru-group.fi>\r
MIME-Version: 1.0\r
Content-Type: text/plain\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Thu, 05 Mar 2015 06:57:21 -0000\r
\r
On Thu, Mar 05 2015, "J. Lewis Muir" <jlmuir@imca-cat.org> wrote:\r
\r
> The install_name of libnotmuch.dylib on Mac OS X is what is written\r
> into a program that links against it.  If it is just the name of the\r
> shared library file, as opposed to the full path, the program won't be\r
> able to find it when it runs and will abort.  Instead, the install_name\r
> should be the full path to the shared library (in its final installed\r
> location).\r
>\r
> Why does Notmuch work without this patch when installed via Homebrew?\r
> The answer is twofold.  One, /usr/local/lib is a special location in\r
> which the dynamic linker will look by default to find shared libraries.\r
> Homebrew highly recommends installing to /usr/local, and, assuming it\r
> has been configured this way, the Notmuch library will end up installed\r
> in /usr/local/lib, and the dynamic linker will find it.  Two, Homebrew\r
> globally corrects all install names in dynamically shared libraries and\r
> binaries for each package it installs.  So, even if the install names in\r
> a package's binaries and libraries are incorrect, Homebrew corrects them\r
> automatically, and no one ever knows.\r
>\r
> Why does Notmuch work without this patch when installed via MacPorts?\r
> The answer is that MacPorts applies a patch just like this patch to fix\r
> the same problem.\r
\r
looks ok to me...\r
\r
Tomi\r
\r
> ---\r
>  lib/Makefile.local | 2 +-\r
>  1 file changed, 1 insertion(+), 1 deletion(-)\r
>\r
> diff --git a/lib/Makefile.local b/lib/Makefile.local\r
> index 7278f46..f9ecd50 100644\r
> --- a/lib/Makefile.local\r
> +++ b/lib/Makefile.local\r
> @@ -27,7 +27,7 @@ LIBRARY_SUFFIX = dylib\r
>  LINKER_NAME = libnotmuch.$(LIBRARY_SUFFIX)\r
>  SONAME = libnotmuch.$(LIBNOTMUCH_VERSION_MAJOR).$(LIBRARY_SUFFIX)\r
>  LIBNAME = libnotmuch.$(LIBNOTMUCH_VERSION_MAJOR).$(LIBNOTMUCH_VERSION_MINOR).$(LIBNOTMUCH_VERSION_RELEASE).$(LIBRARY_SUFFIX)\r
> -LIBRARY_LINK_FLAG = -dynamiclib -install_name $(SONAME) -compatibility_version $(LIBNOTMUCH_VERSION_MAJOR).$(LIBNOTMUCH_VERSION_MINOR) -current_version $(LIBNOTMUCH_VERSION_MAJOR).$(LIBNOTMUCH_VERSION_MINOR).$(LIBNOTMUCH_VERSION_RELEASE)\r
> +LIBRARY_LINK_FLAG = -dynamiclib -install_name $(libdir)/$(SONAME) -compatibility_version $(LIBNOTMUCH_VERSION_MAJOR).$(LIBNOTMUCH_VERSION_MINOR) -current_version $(LIBNOTMUCH_VERSION_MAJOR).$(LIBNOTMUCH_VERSION_MINOR).$(LIBNOTMUCH_VERSION_RELEASE)\r
>  else\r
>  LIBRARY_SUFFIX = so\r
>  LINKER_NAME = libnotmuch.$(LIBRARY_SUFFIX)\r
> -- \r
> 1.9.3 (Apple Git-50)\r
>\r
> This version of the patch has a better commit message as suggested\r
> by David Bremner on the mailing list.  The steps for reproducing the\r
> problem and the steps showing the analysis of the problem have been\r
> removed.  Added is an answer to the question of why Notmuch works\r
> without this patch when installed via Homebrew and MacPorts.\r
>\r
> The message-id of the previous version of this patch is\r
> 1409541227-38895-1-git-send-email-jlmuir@imca-cat.org.\r
> _______________________________________________\r
> notmuch mailing list\r
> notmuch@notmuchmail.org\r
> http://notmuchmail.org/mailman/listinfo/notmuch\r