1 Return-Path: <felipe.contreras@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7A069431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 2 Apr 2013 12:53:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id M0mwgzWC5fpl for <notmuch@notmuchmail.org>;
\r
17 Tue, 2 Apr 2013 12:53:00 -0700 (PDT)
\r
18 Received: from mail-ye0-f177.google.com (mail-ye0-f177.google.com
\r
19 [209.85.213.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E7ABD431FAE
\r
22 for <notmuch@notmuchmail.org>; Tue, 2 Apr 2013 12:52:59 -0700 (PDT)
\r
23 Received: by mail-ye0-f177.google.com with SMTP id l14so123368yen.22
\r
24 for <notmuch@notmuchmail.org>; Tue, 02 Apr 2013 12:52:59 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=x-received:date:from:to:cc:message-id:in-reply-to:references
\r
27 :subject:mime-version:content-type:content-transfer-encoding;
\r
28 bh=TEpx7c5/V04LuuhQCRorljhZxRivZtV/9s4zObmHDkA=;
\r
29 b=pO6BqYpsGbIydnjEz+lOpBd04T1aKEE32F1/D9VUXEJN6Uzuli1IP7EV678pp+qIm1
\r
30 re9va5CGC1UtfxV6gGmLSWe5vi34V3WbH8DIb4AywZh9iBuHTEGxXopb2MnBB0cskLQu
\r
31 Mr2E2XP8aXzbufW4qzjLWsQZiYf89gxLHp7EUgygh9cqdxWO3fTtWXxqNexcA9x6EyrP
\r
32 yRASU1uzv6WTM3AZNwS8TIIZ/J+AQKJ8wRB+N77stckeekDl9Q0SztHNtp2lRJs4oQp8
\r
33 bcy03vlMgE9is779iaAp5nZiG4zDYILGBpkdpNh9lEQezps62UI1SEM4fws5u1crk/vG
\r
35 X-Received: by 10.236.16.202 with SMTP id h50mr16621895yhh.39.1364932379469;
\r
36 Tue, 02 Apr 2013 12:52:59 -0700 (PDT)
\r
37 Received: from localhost (187-163-100-70.static.axtel.net. [187.163.100.70])
\r
38 by mx.google.com with ESMTPS id w69sm5170223yhe.4.2013.04.02.12.52.57
\r
39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
40 Tue, 02 Apr 2013 12:52:58 -0700 (PDT)
\r
41 Date: Tue, 02 Apr 2013 13:46:25 -0600
\r
42 From: Felipe Contreras <felipe.contreras@gmail.com>
\r
43 To: "Kirill A. Shutemov" <kirill@shutemov.name>,
\r
44 Felipe Contreras <felipe.contreras@gmail.com>
\r
45 Message-ID: <515b359189b29_146e1045e1093948@nysa.mail>
\r
46 In-Reply-To: <1359388340-27136-6-git-send-email-kirill@shutemov.name>
\r
47 References: <1359388340-27136-1-git-send-email-kirill@shutemov.name>
\r
48 <1359388340-27136-6-git-send-email-kirill@shutemov.name>
\r
49 Subject: RE: [PATCH 5/5] Drop harmful reply buffer preparation
\r
51 Content-Type: text/plain;
\r
53 Content-Transfer-Encoding: 7bit
\r
54 Cc: notmuch@notmuchmail.org
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Tue, 02 Apr 2013 19:53:00 -0000
\r
69 Kirill A. Shutemov wrote:
\r
70 > From: "Kirill A. Shutemov" <kirill@shutemov.name>
\r
72 > Inserting empty lines at the end of reply buffer and switching to insert
\r
73 > mode are not what user want on reply. It's only annoying if you try to
\r
76 > If a user really wants this kind of preparation it should be implemented
\r
77 > as an user-specific hook.
\r
79 Insert mode, maybe, but the empty lines don't hurt. See, with your patch I end up in:
\r
81 > part = orig.find_first_text
\r
82 > part.convert.each_line do |l|
\r
83 > body_lines << "> %s" % l.chomp
\r
89 I cannot type there, and in any case I have to remove those lines, so I end
\r
90 selecting the text upwards and remove them.
\r
92 With the current code:
\r
94 > part = orig.find_first_text
\r
95 > part.convert.each_line do |l|
\r
96 > body_lines << "> %s" % l.chomp
\r
104 Not much of a difference, I still have to select the lines upwards and remove them.
\r
106 That is of course if you reply *inline*. You might want to reply to the whole
\r
107 thing without modifications, in which case the original behavior is more
\r
110 I'm not strongly opposed to this, but I don't see why those extra lines would hurt.
\r