1 Return-Path: <too@guru-group.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 5232F6DE01BE
\r
6 for <notmuch@notmuchmail.org>; Thu, 9 Jun 2016 12:21:26 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.242 tagged_above=-999 required=5 tests=[AWL=0.251,
\r
12 HEADER_FROM_DIFFERENT_DOMAINS=0.001, T_RP_MATCHES_RCVD=-0.01]
\r
14 Received: from arlo.cworth.org ([127.0.0.1])
\r
15 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id NCDgWdn_tVkt for <notmuch@notmuchmail.org>;
\r
17 Thu, 9 Jun 2016 12:21:18 -0700 (PDT)
\r
18 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
19 by arlo.cworth.org (Postfix) with ESMTP id CFBC86DE01C2
\r
20 for <notmuch@notmuchmail.org>; Thu, 9 Jun 2016 12:21:17 -0700 (PDT)
\r
21 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
22 id 9F3801001E5; Thu, 9 Jun 2016 22:20:57 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: notmuch@notmuchmail.org
\r
25 Cc: tomi.ollila@iki.fi
\r
26 Subject: [PATCH] test/notmuch-test: simple streamlining
\r
27 Date: Thu, 9 Jun 2016 22:20:56 +0300
\r
28 Message-Id: <1465500056-25510-1-git-send-email-tomi.ollila@iki.fi>
\r
29 X-Mailer: git-send-email 2.8.2
\r
30 X-BeenThere: notmuch@notmuchmail.org
\r
31 X-Mailman-Version: 2.1.20
\r
33 List-Id: "Use and development of the notmuch mail system."
\r
34 <notmuch.notmuchmail.org>
\r
35 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
36 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
37 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
38 List-Post: <mailto:notmuch@notmuchmail.org>
\r
39 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
40 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
41 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
42 X-List-Received-Date: Thu, 09 Jun 2016 19:21:26 -0000
\r
44 A few simple things that applies well to test/notmuch-test.sh
\r
46 - Shell does pathname expansion also without doing `echo ...` in subshell.
\r
48 - Redirections >/dev/null 2>/dev/null hide (improbable but) potential
\r
49 serious errors; adding -f to rm instead.
\r
51 - Inter-file capitalization consistency in comments.
\r
53 - Unnecesary space removal.
\r
55 test/notmuch-test | 8 ++++----
\r
56 1 file changed, 4 insertions(+), 4 deletions(-)
\r
58 diff --git a/test/notmuch-test b/test/notmuch-test
\r
59 index 988dce6c59cb..e7d3151ce8cb 100755
\r
60 --- a/test/notmuch-test
\r
61 +++ b/test/notmuch-test
\r
62 @@ -17,14 +17,14 @@ fi
\r
64 cd "$(dirname "$0")"
\r
66 -TESTS=${NOTMUCH_TESTS:-`echo T[0-9][0-9][0-9]-*.sh`}
\r
67 +TESTS=${NOTMUCH_TESTS:-T[0-9][0-9][0-9]-*.sh}
\r
69 # Clean up any results from a previous run
\r
70 -rm -r test-results >/dev/null 2>/dev/null
\r
71 +rm -rf test-results
\r
73 -# test for timeout utility
\r
74 +# Test for timeout utility
\r
75 if command -v timeout >/dev/null; then
\r
76 - TEST_TIMEOUT_CMD="timeout 2m "
\r
77 + TEST_TIMEOUT_CMD="timeout 2m"
\r
78 echo "INFO: using 2 minute timeout for tests"
\r