1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 49418431FBC
\r
6 for <notmuch@notmuchmail.org>; Sun, 4 Mar 2012 23:24:36 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id rz6mRokxkK92 for <notmuch@notmuchmail.org>;
\r
16 Sun, 4 Mar 2012 23:24:34 -0800 (PST)
\r
17 Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com
\r
18 [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 5B459431FAE
\r
21 for <notmuch@notmuchmail.org>; Sun, 4 Mar 2012 23:24:34 -0800 (PST)
\r
22 Received: by dadp14 with SMTP id p14so3268881dad.18
\r
23 for <notmuch@notmuchmail.org>; Sun, 04 Mar 2012 23:24:33 -0800 (PST)
\r
24 Received-SPF: pass (google.com: domain of jani@nikula.org designates
\r
25 10.68.225.73 as permitted sender) client-ip=10.68.225.73;
\r
26 Authentication-Results: mr.google.com;
\r
27 spf=pass (google.com: domain of jani@nikula.org
\r
28 designates 10.68.225.73 as permitted sender)
\r
29 smtp.mail=jani@nikula.org
\r
30 Received: from mr.google.com ([10.68.225.73])
\r
31 by 10.68.225.73 with SMTP id ri9mr45614452pbc.70.1330932273515
\r
32 (num_hops = 1); Sun, 04 Mar 2012 23:24:33 -0800 (PST)
\r
34 Received: by 10.68.225.73 with SMTP id ri9mr39027932pbc.70.1330932273252; Sun,
\r
35 04 Mar 2012 23:24:33 -0800 (PST)
\r
36 Received: by 10.68.12.103 with HTTP; Sun, 4 Mar 2012 23:24:33 -0800 (PST)
\r
37 Received: by 10.68.12.103 with HTTP; Sun, 4 Mar 2012 23:24:33 -0800 (PST)
\r
39 <CAB+hUn8J=Hd1ASOw9oga=2L1Au4nCjc3FszjP6SnK438tPXj8A@mail.gmail.com>
\r
40 References: <1330811724-30901-1-git-send-email-jani@nikula.org>
\r
41 <87d38r6i0s.fsf@qmul.ac.uk>
\r
42 <CAB+hUn8J=Hd1ASOw9oga=2L1Au4nCjc3FszjP6SnK438tPXj8A@mail.gmail.com>
\r
43 Date: Mon, 5 Mar 2012 09:24:33 +0200
\r
45 <CAB+hUn9PmZE_Yc83ojnhAdLBoob_aLb5_rufSxL_0z4eDms_JQ@mail.gmail.com>
\r
46 Subject: Re: [PATCH] emacs: keep customizations in groups
\r
47 From: Jani Nikula <jani@nikula.org>
\r
48 To: Mark Walters <markwalters1009@gmail.com>
\r
49 Content-Type: multipart/alternative; boundary=e89a8ff2437d5e0a0104ba79d128
\r
51 ALoCoQkLYo+ro36GpsM3JvNRB1ex3ukiIigt2/QICYrFte9qR6/zcP0y9Sj0k1H0t79fpaXV7HR3
\r
52 Cc: notmuch@notmuchmail.org
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Mon, 05 Mar 2012 07:24:36 -0000
\r
67 --e89a8ff2437d5e0a0104ba79d128
\r
68 Content-Type: text/plain; charset=UTF-8
\r
70 On Mar 5, 2012 1:50 AM, "Mark Walters" <markwalters1009@gmail.com> wrote:
\r
72 > On Sat, 3 Mar 2012 23:55:24 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
73 > > Move hello section customization to notmuch-hello group and printing
\r
74 > > customization to notmuch-show group from the top level customization
\r
79 > This is an clear improvement but I wonder about the positioning of these
\r
80 > two options inside the subgroups. It makes
\r
82 > notmuch-hello-sections the last option under notmuch-hello and
\r
84 > notmuch-print-mechanism the first option under notmuch-show
\r
86 > both of which seem slightly strange positions.
\r
88 > (Personally I would place notmuch-hello-sections towards the top, and
\r
89 > notmuch-print-mechanism towards the bottom. If you decided on this
\r
90 > ordering then I am happy to go with it: I am only commenting in case it
\r
91 > is just accidental.)
\r
93 I just changed the groups, and that's where the options landed... I don't
\r
94 know how to change the order.
\r
104 > > emacs/notmuch-hello.el | 2 +-
\r
105 > > emacs/notmuch-print.el | 2 +-
\r
106 > > 2 files changed, 2 insertions(+), 2 deletions(-)
\r
108 > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
109 > > index e089290..0cf613f 100644
\r
110 > > --- a/emacs/notmuch-hello.el
\r
111 > > +++ b/emacs/notmuch-hello.el
\r
112 > > @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count
\r
114 > > displayed next to the buttons can be generated by applying a
\r
115 > > different filter to the tag query. These filters are also
\r
116 > > supported for \"Customized queries section\" items."
\r
117 > > - :group 'notmuch
\r
118 > > + :group 'notmuch-hello
\r
121 > > (choice (function-item notmuch-hello-insert-header)
\r
122 > > diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
\r
123 > > index 6653d97..8c18f4b 100644
\r
124 > > --- a/emacs/notmuch-print.el
\r
125 > > +++ b/emacs/notmuch-print.el
\r
126 > > @@ -25,7 +25,7 @@
\r
128 > > (defcustom notmuch-print-mechanism 'notmuch-print-lpr
\r
129 > > "How should printing be done?"
\r
130 > > - :group 'notmuch
\r
131 > > + :group 'notmuch-show
\r
133 > > (function :tag "Use lpr" notmuch-print-lpr)
\r
134 > > (function :tag "Use ps-print" notmuch-print-ps-print)
\r
138 > > _______________________________________________
\r
139 > > notmuch mailing list
\r
140 > > notmuch@notmuchmail.org
\r
141 > > http://notmuchmail.org/mailman/listinfo/notmuch
\r
143 --e89a8ff2437d5e0a0104ba79d128
\r
144 Content-Type: text/html; charset=UTF-8
\r
145 Content-Transfer-Encoding: quoted-printable
\r
148 On Mar 5, 2012 1:50 AM, "Mark Walters" <<a href=3D"mailto:mark=
\r
149 walters1009@gmail.com">markwalters1009@gmail.com</a>> wrote:<br>
\r
151 > On Sat, =C2=A03 Mar 2012 23:55:24 +0200, Jani Nikula <<a href=3D"ma=
\r
152 ilto:jani@nikula.org">jani@nikula.org</a>> wrote:<br>
\r
153 > > Move hello section customization to notmuch-hello group and print=
\r
155 > > customization to notmuch-show group from the top level customizat=
\r
157 > > group.<br>
\r
161 > This is an clear improvement but I wonder about the positioning of the=
\r
163 > two options inside the subgroups. It makes<br>
\r
165 > notmuch-hello-sections the last option under notmuch-hello and<br>
\r
167 > notmuch-print-mechanism the first option under notmuch-show<br>
\r
169 > both of which seem slightly strange positions.<br>
\r
171 > (Personally I would place notmuch-hello-sections towards the top, and<=
\r
173 > notmuch-print-mechanism towards the bottom. If you decided on this<br>
\r
174 > ordering then I am happy to go with it: I am only commenting in case i=
\r
176 > is just accidental.)</p>
\r
177 <p>I just changed the groups, and that's where the options landed... I =
\r
178 don't know how to change the order.</p>
\r
180 > Best wishes<br>
\r
187 > > =C2=A0emacs/notmuch-hello.el | =C2=A0 =C2=A02 +-<br>
\r
188 > > =C2=A0emacs/notmuch-print.el | =C2=A0 =C2=A02 +-<br>
\r
189 > > =C2=A02 files changed, 2 insertions(+), 2 deletions(-)<br>
\r
191 > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el<br>
\r
192 > > index e089290..0cf613f 100644<br>
\r
193 > > --- a/emacs/notmuch-hello.el<br>
\r
194 > > +++ b/emacs/notmuch-hello.el<br>
\r
195 > > @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the=
\r
196 count of messages<br>
\r
197 > > =C2=A0displayed next to the buttons can be generated by applying =
\r
199 > > =C2=A0different filter to the tag query. These filters are also<b=
\r
201 > > =C2=A0supported for \"Customized queries section\" item=
\r
203 > > - =C2=A0:group 'notmuch<br>
\r
204 > > + =C2=A0:group 'notmuch-hello<br>
\r
205 > > =C2=A0 =C2=A0:type<br>
\r
206 > > =C2=A0 =C2=A0'(repeat<br>
\r
207 > > =C2=A0 =C2=A0 =C2=A0(choice (function-item notmuch-hello-insert-h=
\r
209 > > diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el<br>
\r
210 > > index 6653d97..8c18f4b 100644<br>
\r
211 > > --- a/emacs/notmuch-print.el<br>
\r
212 > > +++ b/emacs/notmuch-print.el<br>
\r
213 > > @@ -25,7 +25,7 @@<br>
\r
215 > > =C2=A0(defcustom notmuch-print-mechanism 'notmuch-print-lpr<b=
\r
217 > > =C2=A0 =C2=A0"How should printing be done?"<br>
\r
218 > > - =C2=A0:group 'notmuch<br>
\r
219 > > + =C2=A0:group 'notmuch-show<br>
\r
220 > > =C2=A0 =C2=A0:type '(choice<br>
\r
221 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 (function :tag "Use lpr" no=
\r
222 tmuch-print-lpr)<br>
\r
223 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 (function :tag "Use ps-print&quo=
\r
224 t; notmuch-print-ps-print)<br>
\r
226 > > 1.7.5.4<br>
\r
228 > > _______________________________________________<br>
\r
229 > > notmuch mailing list<br>
\r
230 > > <a href=3D"mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.or=
\r
232 > > <a href=3D"http://notmuchmail.org/mailman/listinfo/notmuch">http:=
\r
233 //notmuchmail.org/mailman/listinfo/notmuch</a><br>
\r
236 --e89a8ff2437d5e0a0104ba79d128--
\r