1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6803C429E5B
\r
6 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 07:14:03 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.612 tagged_above=-999 required=5
\r
12 tests=[GAPPY_SUBJECT=1.312, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id dY1P03uOaeyu for <notmuch@notmuchmail.org>;
\r
16 Tue, 31 Jan 2012 07:14:02 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 165FC429E25
\r
20 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 07:14:02 -0800 (PST)
\r
21 X-AuditID: 1209190c-b7fad6d000000920-ef-4f2805382222
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 19.B3.02336.835082F4; Tue, 31 Jan 2012 10:14:00 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q0VFDxo3029330;
\r
27 Tue, 31 Jan 2012 10:14:00 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0VFDw0b008596
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Tue, 31 Jan 2012 10:13:59 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RsFOL-00047S-6h; Tue, 31 Jan 2012 10:13:05 -0500
\r
37 Date: Tue, 31 Jan 2012 10:13:05 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Jani Nikula <jani@nikula.org>
\r
40 Subject: Re: [RFC PATCH] emacs: make show view a/A/x/X key bindings more
\r
42 Message-ID: <20120131151305.GB10898@mit.edu>
\r
43 References: <1328022235-8400-1-git-send-email-jani@nikula.org>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <1328022235-8400-1-git-send-email-jani@nikula.org>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IRYrdT0bVg1fA3OPDOwKJpurPF9ZszmR2Y
\r
51 PG7df83u8WzVLeYApigum5TUnMyy1CJ9uwSujG0fD7IVfJGraNzwjbmBcbJkFyMnh4SAicTR
\r
52 9pfMELaYxIV769m6GLk4hAT2MUr8mnaHEcLZwCjRsr2DGcI5ySTxZ8t7VghnCaPEyT3X2ED6
\r
53 WQRUJU63HwWbxSagIbFt/3JGEFtEQFFi88n9YDazgLTEt9/NTCC2sECoxMJHx4HiHBy8AjoS
\r
54 b48FgoSFBOwkWhu6wMbwCghKnJz5hAWiVUvixr+XTCDlIGOW/+MACXMK2Eu0HFoCViIqoCIx
\r
55 5eQ2tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXUO93MwSvdSU0k2M
\r
56 oKDmlOTZwfjmoNIhRgEORiUe3p3v1fyFWBPLiitzDzFKcjApifLKsmj4C/El5adUZiQWZ8QX
\r
57 leakFh9ilOBgVhLhfbMaqJw3JbGyKrUoHyYlzcGiJM6rovXOT0ggPbEkNTs1tSC1CCYrw8Gh
\r
58 JMGbDTJUsCg1PbUiLTOnBCHNxMEJMpwHaPg1ZqAa3uKCxNzizHSI/ClGXY72t7vPMwqx5OXn
\r
59 pUqJ8xaCDBIAKcoozYObA0tGrxjFgd4S5g0AqeIBJjK4Sa+AljABLXnOoAqypCQRISXVwOiu
\r
60 PYG1794v4cZZbQtlGxfpVr95JrJBveveEhYuTdma3cuzy0K1fDrbHl/J/9H4lU/jyE13JtFg
\r
61 jSdH8tJVlzZ93JtdZXBvc4dlpZWP3gufs3xG05XP7v+bfn+HrZVUonAm3yfWoocqAV1fvh54
\r
62 sXaLwjnNjstPFRPr7/pt3uSy1myWEYveZCWW4oxEQy3mouJEADJXbuwhAwAA
\r
63 Cc: notmuch@notmuchmail.org
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Tue, 31 Jan 2012 15:14:03 -0000
\r
78 Quoth Jani Nikula on Jan 31 at 5:03 pm:
\r
79 > Proposal for show view a/A/x/X key bindings, according to
\r
80 > http://titanpad.com/SA39EbNezU and IRC discussion:
\r
82 > 'a' = Archive current message, then move to next message, or show next
\r
83 > thread from search if at the last message in thread.
\r
85 > 'A' = Archive each message in thread, then show next thread from
\r
88 > 'x' = Archive current message, then move to next message, or exit back
\r
89 > to search results if at the last message in thread.
\r
91 > 'X' = Archive each message in thread, then exit back to search
\r
94 > IMHO these changes would make the current implementation more
\r
95 > consistent in two ways: 1) 'a'/'A' would advance to next thread like
\r
96 > 'a' used to do, 2) 'x' would operate on messages and 'X' on threads
\r
97 > like 'a'/'A' do now.
\r
99 +1 to the proposal. I don't know the maze of twisty little passages
\r
100 that implement the show bindings well enough to say if the code is
\r
103 > The implementation here is hacky at best, and I agree with dme that
\r
104 > notmuch-show.el could use some code cleanup and provide
\r
105 > non-interactive primitives. However I won't have the time and energy
\r
106 > for that right now.
\r
108 > emacs/notmuch-show.el | 26 ++++++++++++++++++++------
\r
109 > 1 files changed, 20 insertions(+), 6 deletions(-)
\r
111 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
112 > index de9421e..62f3664 100644
\r
113 > --- a/emacs/notmuch-show.el
\r
114 > +++ b/emacs/notmuch-show.el
\r
115 > @@ -1075,9 +1075,10 @@ thread id. If a prefix is given, crypto processing is toggled."
\r
116 > (define-key map "h" 'notmuch-show-toggle-headers)
\r
117 > (define-key map "-" 'notmuch-show-remove-tag)
\r
118 > (define-key map "+" 'notmuch-show-add-tag)
\r
119 > - (define-key map "x" 'notmuch-show-archive-thread-then-exit)
\r
120 > - (define-key map "a" 'notmuch-show-archive-message-then-next)
\r
121 > + (define-key map "X" 'notmuch-show-archive-thread-then-exit)
\r
122 > + (define-key map "x" 'notmuch-show-archive-message-then-next-then-exit)
\r
123 > (define-key map "A" 'notmuch-show-archive-thread-then-next)
\r
124 > + (define-key map "a" 'notmuch-show-archive-message-then-next-then-next)
\r
126 notmuch-show-archive-message-then-next-then-next-thread? I like the
\r
127 very explicit names, but "then-next-then-next" is rather opaque.
\r
129 > (define-key map "N" 'notmuch-show-next-message)
\r
130 > (define-key map "P" 'notmuch-show-previous-message)
\r
131 > (define-key map "n" 'notmuch-show-next-open-message)
\r
132 > @@ -1425,10 +1426,12 @@ buffer."
\r
135 > (notmuch-show-mark-read)
\r
136 > - (notmuch-show-message-adjust))
\r
137 > + (notmuch-show-message-adjust)
\r
140 > (notmuch-show-next-thread)
\r
141 > - (goto-char (point-max))))))
\r
142 > + (goto-char (point-max))
\r
145 > (defun notmuch-show-previous-open-message ()
\r
146 > "Show the previous open message."
\r
147 > @@ -1645,12 +1648,23 @@ removed)."
\r
148 > (notmuch-show-add-tag "inbox")
\r
149 > (notmuch-show-remove-tag "inbox")))
\r
151 > -(defun notmuch-show-archive-message-then-next ()
\r
152 > - "Archive the current message, then show the next open message in the current thread."
\r
153 > +(defun notmuch-show-archive-message-then-next-then-exit ()
\r
154 > + "Archive the current message, then show the next open message in the current thread.
\r
156 > +If at the last message in thread, then exit back to search results."
\r
158 > (notmuch-show-archive-message)
\r
159 > (notmuch-show-next-open-message t))
\r
161 > +(defun notmuch-show-archive-message-then-next-then-next ()
\r
162 > + "Archive the current message, then show the next open message in the current thread.
\r
164 > +If at the last message in thread, then show next thread from search."
\r
166 > + (notmuch-show-archive-message)
\r
167 > + (unless (notmuch-show-next-open-message)
\r
168 > + (notmuch-show-next-thread t)))
\r
170 > (defun notmuch-show-stash-cc ()
\r
171 > "Copy CC field of current message to kill-ring."
\r