1 Return-Path: <aaronecay@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 81E2841488C
\r
6 for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 17:12:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id rg7LERfXxSVe for <notmuch@notmuchmail.org>;
\r
17 Sun, 8 Jan 2012 17:12:17 -0800 (PST)
\r
18 Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com
\r
19 [209.85.213.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 4D9AA414342
\r
22 for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 17:12:15 -0800 (PST)
\r
23 Received: by yhpp34 with SMTP id p34so511937yhp.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 08 Jan 2012 17:12:14 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=BYzlRP6+lbdlVQYRqhPXU0syTFwklmtcj9gx1RYD1qg=;
\r
29 b=KHSPDSH1y6yydVm4qF8hRWW0EjFienOsuC6c1AaeDCIYT4c2Q/kTGpngjqwWABDT9a
\r
30 ibiTAVa5eInwEMUD0KRU8CazO3JyZx4S6jijp2kX0XR1pTPuDaAC7t+bkTDb6egqjggN
\r
31 Oaa0Zy5yBUQFI7Xwj/9FMSTbSe00V7rtKd+po=
\r
32 Received: by 10.236.155.234 with SMTP id j70mr17369773yhk.123.1326071533651;
\r
33 Sun, 08 Jan 2012 17:12:13 -0800 (PST)
\r
34 Received: from localhost (c-68-80-94-73.hsd1.pa.comcast.net. [68.80.94.73])
\r
35 by mx.google.com with ESMTPS id j16sm54097222anm.9.2012.01.08.17.12.11
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sun, 08 Jan 2012 17:12:11 -0800 (PST)
\r
38 From: Aaron Ecay <aaronecay@gmail.com>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
40 Notmuch Mail <notmuch@notmuchmail.org>
\r
41 Subject: Re: [PATCH 2/4] emacs: add option to notmuch-show-next-open-message
\r
42 to pop out to parent buffer if at end
\r
43 In-Reply-To: <1325986015-22510-3-git-send-email-jrollins@finestructure.net>
\r
44 References: <1325975294-646-4-git-send-email-jrollins@finestructure.net>
\r
45 <1325986015-22510-1-git-send-email-jrollins@finestructure.net>
\r
46 <1325986015-22510-2-git-send-email-jrollins@finestructure.net>
\r
47 <1325986015-22510-3-git-send-email-jrollins@finestructure.net>
\r
48 User-Agent: Notmuch/0.10.1+56~gd709fd6 (http://notmuchmail.org)
\r
49 Emacs/24.0.92.3 (i386-apple-darwin10.8.0)
\r
50 Date: Sun, 08 Jan 2012 20:12:08 -0500
\r
51 Message-ID: <m2zkdxisrb.fsf@gmail.com>
\r
53 Content-Type: text/plain
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Mon, 09 Jan 2012 01:12:33 -0000
\r
70 One small, stylistic/nitpicky comment :)
\r
72 On Sat, 7 Jan 2012 17:26:53 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
73 > This will allow for keybindings that achieve a smoother message
\r
74 > processing flow by reducing the number of key presses needed for most
\r
75 > common operations.
\r
77 > emacs/notmuch-show.el | 12 +++++++++---
\r
78 > 1 files changed, 9 insertions(+), 3 deletions(-)
\r
80 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
81 > index 8bb052e..e7bb958 100644
\r
82 > --- a/emacs/notmuch-show.el
\r
83 > +++ b/emacs/notmuch-show.el
\r
84 > @@ -1264,17 +1264,23 @@ any effects from previous calls to
\r
85 > (notmuch-show-mark-read)
\r
86 > (notmuch-show-message-adjust))
\r
88 > -(defun notmuch-show-next-open-message ()
\r
89 > +(defun notmuch-show-next-open-message (&optional pop-at-end)
\r
90 > "Show the next message."
\r
94 > + (parent-buffer notmuch-show-parent-buffer))
\r
96 No second set of parentheses is needed around r. Also, it is more
\r
97 idiomatic to put the initialized variable (i.e. parent-buffer) before
\r
98 the uninitialized one (r).
\r
100 > (while (and (setq r (notmuch-show-goto-message-next))
\r
101 > (not (notmuch-show-message-visible-p))))
\r
104 > (notmuch-show-mark-read)
\r
105 > (notmuch-show-message-adjust))
\r
106 > - (goto-char (point-max)))))
\r
107 > + (if (and parent-buffer pop-at-end)
\r
109 > + (kill-this-buffer)
\r
110 > + (switch-to-buffer parent-buffer)
\r
111 > + (forward-line 1))
\r
112 > + (goto-char (point-max))))))
\r
114 > (defun notmuch-show-previous-open-message ()
\r
115 > "Show the previous message."
\r
119 > _______________________________________________
\r
120 > notmuch mailing list
\r
121 > notmuch@notmuchmail.org
\r
122 > http://notmuchmail.org/mailman/listinfo/notmuch
\r