1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A1B80431FBD;
\r
6 Thu, 10 Dec 2009 17:35:04 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id HeQDraplFiyg; Thu, 10 Dec 2009 17:35:03 -0800 (PST)
\r
11 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
12 by olra.theworths.org (Postfix) with ESMTP id 43E33431FAE;
\r
13 Thu, 10 Dec 2009 17:35:02 -0800 (PST)
\r
14 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
15 id 9D7F6254312; Thu, 10 Dec 2009 16:57:01 -0800 (PST)
\r
16 From: Carl Worth <cworth@cworth.org>
\r
17 To: Keith Amidon <keith@nicira.com>, notmuch@notmuchmail.org
\r
18 In-Reply-To: <1260053640-10034-3-git-send-email-keith@nicira.com>
\r
19 References: <1260053640-10034-1-git-send-email-keith@nicira.com>
\r
20 <1260053640-10034-2-git-send-email-keith@nicira.com>
\r
21 <1260053640-10034-3-git-send-email-keith@nicira.com>
\r
22 Date: Thu, 10 Dec 2009 16:57:01 -0800
\r
23 Message-ID: <878wda49b6.fsf@yoom.home.cworth.org>
\r
25 Content-Type: multipart/signed; boundary="=-=-=";
\r
26 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
27 Cc: Keith Amidon <keith@nicira.com>
\r
28 Subject: Re: [notmuch] [PATCH 2/2] Save all attachments to a directory
\r
29 X-BeenThere: notmuch@notmuchmail.org
\r
30 X-Mailman-Version: 2.1.12
\r
32 List-Id: "Use and development of the notmuch mail system."
\r
33 <notmuch.notmuchmail.org>
\r
34 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
35 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
36 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
37 List-Post: <mailto:notmuch@notmuchmail.org>
\r
38 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
39 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
40 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
41 X-List-Received-Date: Fri, 11 Dec 2009 01:35:04 -0000
\r
45 On Sat, 5 Dec 2009 14:54:00 -0800, Keith Amidon <keith@nicira.com> wrote:
\r
46 > Prompt for a directory and write all attachments of the current
\r
47 > message to that directory, prompting for a filename for each with a
\r
48 > default value of the filename specified in the attachment.
\r
50 I really like the idea of this function. I'd just like to see a few,
\r
51 little improvements.
\r
53 > The behavior of this function differs in two ways from the existing
\r
54 > notmuch-show-save-attachments function:
\r
56 First, I'm not sure whether we need two different variations of what's
\r
57 effectively the same operation here ("save all attachments").
\r
59 What I would like is one command to save a single attachment, and then
\r
60 one command to save all attachments. So if we assume that the current
\r
61 'w' keybinding is really for "write one attachment" (with a lame
\r
62 implementation currently), and 'W' is for "write all attachments", then
\r
63 I think I'd be OK with that.
\r
65 As for the changes we need here, the prompting for the directory needs
\r
66 a string telling the user what's being prompted for. Something like
\r
67 "Save all attachments to: ", which should just be another argument to
\r
68 the interactive call, right?
\r
70 Second, the command needs to provide a little bit of feedback as to what
\r
71 was saved. I ended up running this command a couple of times before I
\r
72 realized it was never going to save the inline patch with no filename
\r
73 that I was looking at[*].
\r
75 So it at least needs to message something like "N files written to DIR"
\r
78 Should be fairly trivial improvements to the current patch I think.
\r
82 [*] So there's something else I think we need here. I was seeing a patch
\r
83 in a message, but wanted to get it into a file before piping it off to
\r
84 something, (so '|' didn't work). The patch wasn't an attachment so 'w'
\r
85 didn't work as described above. I tried using 'V' to view the raw
\r
86 message, but then found that the MIME part I wanted was actually encoded
\r
87 as quoted-printable, so just saving the raw message wasn't useful
\r
90 So do we need a command to write the current "cooked" message to a file?
\r
91 I suppose I could have just used:
\r
93 | cat > /some/filename
\r
95 but that feels a little bit like cat abuse.
\r
98 Content-Type: application/pgp-signature
\r
100 -----BEGIN PGP SIGNATURE-----
\r
101 Version: GnuPG v1.4.10 (GNU/Linux)
\r
103 iD8DBQFLIZjd6JDdNq8qSWgRAhCkAJ95AkjH1ya1tLW0CZfg8GyLqHrtlACfdaon
\r
104 +6RMkn9ZVx5NFBpzPRpIFec=
\r
106 -----END PGP SIGNATURE-----
\r