1 Return-Path: <adrien@bustany.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9A3BE431FC0
\r
6 for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:41:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id xAD6SFFjUq1j for <notmuch@notmuchmail.org>;
\r
16 Thu, 25 Oct 2012 11:41:37 -0700 (PDT)
\r
17 Received: from mail.bustany.org (bustany.org [176.31.244.208])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 2885F431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:41:37 -0700 (PDT)
\r
20 Received: from [192.168.1.147] (91-158-5-86.elisa-laajakaista.fi
\r
21 [91.158.5.86]) by mail.bustany.org (Postfix) with ESMTPSA id 3DCAE140230;
\r
22 Thu, 25 Oct 2012 20:45:31 +0200 (CEST)
\r
23 Message-ID: <508987DD.9010405@bustany.org>
\r
24 Date: Thu, 25 Oct 2012 21:41:33 +0300
\r
25 From: Adrien Bustany <adrien@bustany.org>
\r
26 User-Agent: Mozilla/5.0 (X11; Linux x86_64;
\r
27 rv:16.0) Gecko/20121009 Thunderbird/16.0
\r
29 To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
30 Subject: Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected
\r
31 References: <1342636475-16057-1-git-send-email-adrien@bustany.org>
\r
32 <1342636475-16057-4-git-send-email-adrien@bustany.org>
\r
33 <87wqyn6rpf.fsf@betacantrips.com>
\r
34 In-Reply-To: <87wqyn6rpf.fsf@betacantrips.com>
\r
35 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
\r
36 Content-Transfer-Encoding: 8bit
\r
37 Cc: notmuch@notmuchmail.org
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Thu, 25 Oct 2012 18:41:37 -0000
\r
52 Le 19/10/2012 06:55, Ethan Glasser-Camp a écrit :
\r
53 > Adrien Bustany <adrien@bustany.org> writes:
\r
55 >> This makes notmuch appropriately free the underlying notmuch C objects
\r
56 >> when garbage collecting their Go wrappers. To make sure we don't break
\r
57 >> the underlying links between objects (for example, a notmuch_messages_t
\r
58 >> being GC'ed before a notmuch_message_t belonging to it), we add for each
\r
59 >> wraper struct a pointer to the owner object (Go objects with a reference
\r
60 >> pointing to them don't get garbage collected).
\r
62 > Hi Adrien! This whole series is marked moreinfo, but I don't think
\r
63 > that's just. It looks like there were some unresolved issues about
\r
64 > reference tracking and garbage collection, and some suggestions to use
\r
65 > the C values of enums instead of regenerating them with iota, but
\r
66 > there's definitely valid code that I assume would be useful if anyone
\r
67 > ever wanted to write in Go ;). Are you figuring to clean this series up?
\r
69 > This comment should s/wraper/wrapper/.
\r
76 thanks for the heads up, I still have this on my table, and yes there is
\r
77 additional work to do for the patches to be really clean. I can't give
\r
78 an estimate for now, let's hope sooner than later :/
\r