1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 16040431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 16:42:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 3F9z5P2azsbN for <notmuch@notmuchmail.org>;
\r
16 Fri, 24 Jan 2014 16:42:06 -0800 (PST)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id CFFB4431FB6
\r
21 for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 16:42:06 -0800 (PST)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1W6rJx-0006uc-Di; Fri, 24 Jan 2014 20:42:01 -0400
\r
25 Received: (nullmailer pid 31424 invoked by uid 1000); Sat, 25 Jan 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH 3/3] notmuch-show: detect xapian exception in query
\r
30 In-Reply-To: <87txctf5ip.fsf@nikula.org>
\r
31 References: <m2r47zrkkc.fsf@guru.guru-group.fi>
\r
32 <1390479841-17045-1-git-send-email-david@tethera.net>
\r
33 <1390479841-17045-4-git-send-email-david@tethera.net>
\r
34 <87txctf5ip.fsf@nikula.org>
\r
35 User-Agent: Notmuch/0.17+35~g3b36898 (http://notmuchmail.org) Emacs/24.3.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Fri, 24 Jan 2014 20:41:57 -0400
\r
38 Message-ID: <87zjmkopt6.fsf@zancas.localnet>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Sat, 25 Jan 2014 00:42:14 -0000
\r
55 Jani Nikula <jani@nikula.org> writes:
\r
57 > This should just return 1 or something. See how the function eventually
\r
58 > returns res != NOTMUCH_STATUS_SUCCESS instead of notmuch_status_t. And
\r
59 > threads == NULL is not guaranteed to mean an exception occurred anyway.
\r
61 > Otherwise the patch LGTM, and is in line with the error handling in
\r
62 > notmuch search, which does not segfault on similar queries.
\r
64 pushed a version amended as suggested.
\r