5e/4dac4d971e112da69401bad4124f4986f10bd4

   1 Return-Path: <five9a2@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id C618B431FBD\r
   6         for <notmuch@notmuchmail.org>; Fri,  5 Feb 2010 00:58:38 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.07\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.07 tagged_above=-999 required=5 tests=[AWL=-0.071,\r
  12         BAYES_50=0.001] autolearn=unavailable\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id RDtfuflNo7Ez for <notmuch@notmuchmail.org>;\r
  16         Fri,  5 Feb 2010 00:58:36 -0800 (PST)\r
  17 Received: from mail-fx0-f223.google.com (mail-fx0-f223.google.com\r
  18         [209.85.220.223])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 778AA431FAE\r
  20         for <notmuch@notmuchmail.org>; Fri,  5 Feb 2010 00:58:36 -0800 (PST)\r
  21 Received: by fxm23 with SMTP id 23so509516fxm.2\r
  22         for <notmuch@notmuchmail.org>; Fri, 05 Feb 2010 00:58:35 -0800 (PST)\r
  23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  24         h=domainkey-signature:received:received:sender:from:to:cc:subject\r
  25         :in-reply-to:references:date:message-id:mime-version:content-type;\r
  26         bh=xYiupAGIEOTz1GILmFkupj3wirp7Vx1y+KUXqHwGY1I=;\r
  27         b=aunP1VU7E7GwgZFkJU9pIsNbIAcFk4JamDopZu9Wk9z4luMDKhH/atEYulN9bd1oSN\r
  28         SC0dFd039bq/zS0wWLv8aANLk2hgrtTXMnWGbMrvJpSwn2CHzQ4yMPSIo6PTIQeEatt2\r
  29         w0uktE2Jo31GaHSnDK/oK5iv2n8Iw304IG1Dg=\r
  30 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
  31         h=sender:from:to:cc:subject:in-reply-to:references:date:message-id\r
  32         :mime-version:content-type;\r
  33         b=UFYrcvk+DzUflNROjNrX3Dox/bBXcuOBNvcGkyJlyTmAKgRKZHmAFSKAntbGYyzZqu\r
  34         peSb/fpEqJMAiF7PWJHhXeNhKN2qTbzFgHZgCFUL2p7PflqAoHMxAqi1kDa4Js+NhwBz\r
  35         8AbCLTCizRaK8ig4Jm+UXhSSN+6ozcQ78Jj3A=\r
  36 Received: by 10.223.15.133 with SMTP id k5mr2255393faa.39.1265360315710;\r
  37         Fri, 05 Feb 2010 00:58:35 -0800 (PST)\r
  38 Received: from kunyang (vawpc43.ethz.ch [129.132.59.11])\r
  39         by mx.google.com with ESMTPS id b17sm1822219fka.46.2010.02.05.00.58.33\r
  40         (version=TLSv1/SSLv3 cipher=RC4-MD5);\r
  41         Fri, 05 Feb 2010 00:58:34 -0800 (PST)\r
  42 Sender: Jed Brown <five9a2@gmail.com>\r
  43 From: Jed Brown <jed@59A2.org>\r
  44 To: Carl Worth <cworth@cworth.org>\r
  45 In-Reply-To: <87k4uspvr7.fsf@yoom.home.cworth.org>\r
  46 References: <87r5ripfy2.fsf@yoom.home.cworth.org>\r
  47         <1259450376-24523-1-git-send-email-jed@59A2.org>\r
  48         <1259450376-24523-2-git-send-email-jed@59A2.org>\r
  49         <87k4uspvr7.fsf@yoom.home.cworth.org>\r
  50 Date: Fri, 05 Feb 2010 10:00:31 +0100\r
  51 Message-ID: <873a1gys40.fsf@59A2.org>\r
  52 MIME-Version: 1.0\r
  53 Content-Type: text/plain; charset=us-ascii\r
  54 Cc: notmuch@notmuchmail.org\r
  55 Subject: Re: [notmuch] [PATCH 2/2] notmuch-reply.c: Handle munged `Reply-To'\r
  56         headers.\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Fri, 05 Feb 2010 08:58:39 -0000\r
  70 \r
  71 On Thu, 04 Feb 2010 12:54:20 -0800, Carl Worth <cworth@cworth.org> wrote:\r
  72 > And I'm glad I did because that turned up a bug in the patch, (using\r
  73 > == instead of != for the return value of strcasestr resulted in *all*\r
  74 > messages with a Reply-To header being considered as munged).\r
  75 \r
  76 Yikes, I've been using this thing for two months and hadn't noticed.\r
  77 \r
  78 > Here's one cleanup I made which you might find interesting as a style\r
  79 > issue (where I prefer naming a function based on what it *does* rather\r
  80 > than on what it's being *used* for):\r
  81 \r
  82 Yup, I do the same, but must have been too lazy to think of a decent name.\r
  83 \r
  84 Jed\r