1 Return-Path: <schnouki@schnouki.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 331D0429E21
\r
6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 12:17:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id DCWJMFo5RyaQ for <notmuch@notmuchmail.org>;
\r
17 Wed, 16 Nov 2011 12:17:57 -0800 (PST)
\r
18 Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])
\r
19 by olra.theworths.org (Postfix) with ESMTP id 40F33431FD0
\r
20 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 12:17:57 -0800 (PST)
\r
21 Received: from odin.local (4va54-1-87-88-247-156.dsl.sta.abo.bbox.fr
\r
23 by ks3536.kimsufi.com (Postfix) with ESMTPSA id E4CE96A0026;
\r
24 Wed, 16 Nov 2011 21:17:55 +0100 (CET)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;
\r
26 s=key-schnouki; t=1321474676;
\r
27 bh=MJ0WxhgBvokOeMHfg5h5P3W6fvH2SpzCXN4IcT1lqnc=;
\r
28 h=From:To:Subject:In-Reply-To:References:Date:Message-ID:
\r
29 MIME-Version:Content-Type;
\r
30 b=SpCgzxu+j3XUmyIqiH6+xzUWdKWG0VmGgqyfl8IwdmR679EW8HqgCu4OvxLBikRip
\r
31 H1iKkK3TPbW4ZeP5rDc+xWBuUf9jtDAHmYdfkPnShRnPpPzo0LNHhLJTCqOeFTF4jf
\r
32 U75Sx2RS3xrlL0rwCKZT7ISl0xJdiuw/RDD97yXc=
\r
33 From: Thomas Jost <schnouki@schnouki.net>
\r
34 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
35 notmuch@notmuchmail.org
\r
36 Subject: Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs"
\r
37 In-Reply-To: <87lirf99vt.fsf@servo.finestructure.net>
\r
38 References: <1320176954-4897-1-git-send-email-pieter@praet.org>
\r
39 <1321454035-22023-1-git-send-email-schnouki@schnouki.net>
\r
40 <87lirf99vt.fsf@servo.finestructure.net>
\r
41 User-Agent: Notmuch/0.10_rc1+21~gaf76c55 (http://notmuchmail.org)
\r
42 Emacs/24.0.90.1 (x86_64-unknown-linux-gnu)
\r
43 Date: Wed, 16 Nov 2011 21:17:48 +0100
\r
44 Message-ID: <87zkfv95zn.fsf@schnouki.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Wed, 16 Nov 2011 20:17:58 -0000
\r
63 Content-Type: text/plain
\r
64 Content-Transfer-Encoding: quoted-printable
\r
66 On Wed, 16 Nov 2011 10:53:42 -0800, Jameson Graef Rollins <jrollins@finestr=
\r
68 > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost <schnouki@schnouki.net> w=
\r
72 > > This is another rebased version of Pieter's series to add GPG and Emacs=
\r
74 > > prereqs, plus some additions on my own. (Rebased and posted as requeste=
\r
78 > > Changes as compared to Pieter's patches (including parts from [2]):
\r
79 > > - prereqs are not tested using test_expect_success as they were in Piet=
\r
81 > > original patches, but using a new function called test_set_bin_prereq=
\r
83 > > this before the gdb prereq was added, hence the different way to set =
\r
86 > Hey, Thomas. Thanks so much for this work. This sounds like a better
\r
89 > However, in the patches you send I see a lot of changes of the form
\r
91 > -test_expect_success 'emacs delivery of encrypted message with attachme=
\r
93 > +test_expect_success GPG 'emacs delivery of encrypted message with atta=
\r
98 > -test_expect_equal \
\r
99 > +test_expect_equal GPG \
\r
101 > which seems to contradict what you've said above. Not to mention that I
\r
102 > don't see anything that modifies calls to the test_expect_ functions.
\r
103 > Basically I see a lot more in the diffs than I would have expected in a
\r
104 > cursory look. Is this just a rebase flub, or is there something I'm
\r
111 I guess I wasn't clear in my explanations :)
\r
113 Pieter's patches use this to detect the presence of GPG/Emacs and set
\r
116 +# GnuPG is a prereq.
\r
117 +test_expect_success "prereq: GnuPG is present" "which gpg" \
\r
118 + && test_set_prereq GPG
\r
120 There are 2 problems with this approach:=20
\r
122 =2D test_expect_success returns 0 regardless of the actual result of the
\r
123 command it runs. So even if gpg is not installed,=20
\r
124 text_expect_success "..." "which gpg"
\r
125 will succeed, and "test_set_prereq GPG" will be run.
\r
126 This, however, has been fixed in commit 003e7180 -- which had not been
\r
127 pushed when I wrote this in the first place :)
\r
129 =2D using test_expect_* to set a prereq does not make sense. If emacs is
\r
130 absent, the test suite would report a failed test. But a missing
\r
131 prereq is *not* a notmuch issue, so this should *not* be reported as a
\r
134 Hence my first patch, which defines test_set_bin_prereq, a new helper
\r
135 function to set a prereq without using any test_expect_*.
\r
137 After that we can use the normal prereq syntax from the test suite:
\r
138 =2D test_expect_success COMMAND --> run COMMAND, expecting it to succeed
\r
139 =2D test_expect_success PREREQ COMMAND --> skip if PREREQ is not set, else
\r
140 run the test as before
\r
141 (and same thing with the other test_expect_* functions)
\r
143 Does it make more sense now?
\r
151 Content-Type: application/pgp-signature
\r
153 -----BEGIN PGP SIGNATURE-----
\r
154 Version: GnuPG v1.4.11 (GNU/Linux)
\r
156 iQEcBAEBAgAGBQJOxBptAAoJEMPdciX+bh5IabgH/3voa/YJjklax+LokiZr2B/J
\r
157 BcqVAsT5D1pcNPdO+P4LFppIepjxmR6GnLJbX3kzmjb8/p9eV39qGzrGlK2VDs8v
\r
158 h6aLZ9jx5UkSMHRBEZxwRD2yeJkiv3KsCj37pvhtH39gEoinEpCZqtimSCZMahNm
\r
159 /rM+IB8Y4ZNOuz1S/l3v47XSOltoHUgy8WGwjQKiihcb0aJmw30QREdNiYMqaT0v
\r
160 PM8MiVmRHeuv56pbSFqh1IHCNemb0XzU/TeZD1rW2Y0wzMQcbKyiTpw5sHtxhZuD
\r
161 NgpW/vsjaOLGIiWL+1Z8NIbIXfanOaYST5MQZ6uqfKWbpqrB2nZ4w/D3Qxr7B10=
\r
163 -----END PGP SIGNATURE-----
\r