1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AC371431FC7
\r
6 for <notmuch@notmuchmail.org>; Sun, 1 Sep 2013 20:37:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id hOZv1xM6SvsY for <notmuch@notmuchmail.org>;
\r
17 Sun, 1 Sep 2013 20:36:54 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 63152431FC3
\r
22 for <notmuch@notmuchmail.org>; Sun, 1 Sep 2013 20:36:54 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1VGKwc-00044R-OP; Mon, 02 Sep 2013 04:36:51 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1VGKwc-0004UQ-Hk; Mon, 02 Sep 2013 04:36:50 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 0/4] contrib: pick: allow more general format lines
\r
34 In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>
\r
35 References: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>
\r
36 User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Mon, 02 Sep 2013 04:36:49 +0100
\r
39 Message-ID: <87ob8bgai6.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-Sender-Host-Address: 93.97.24.31
\r
43 X-QM-SPAM-Info: Sender has good ham record. :)
\r
44 X-QM-Body-MD5: 67ba04f8689df6164b4426ec2eeb35f6 (of first 20000 bytes)
\r
45 X-SpamAssassin-Score: 0.0
\r
46 X-SpamAssassin-SpamBar: /
\r
47 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
49 spam. We require at least 5.0 points to mark a message as spam.
\r
50 This message scored 0.0 points. Summary of the scoring:
\r
51 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
52 provider * (markwalters1009[at]gmail.com)
\r
53 * 0.0 AWL AWL: From: address is in the auto white-list
\r
54 X-QM-Scan-Virus: ClamAV says the message is clean
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Mon, 02 Sep 2013 03:37:01 -0000
\r
70 On Mon, 02 Sep 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
71 > Currently pick makes the tree box graphics part of the "subject". This
\r
72 > is rather unsatisfactory: the tree graphics should be a field in their
\r
75 > However, there is no mechanism in the current setup for allowing 2
\r
76 > fields to have fixed combined width but variable individual
\r
77 > width. Thus making the tree graphics a seperate field means that we
\r
78 > cannot keep the current display which is
\r
80 > date (12 characters) authors (20 characters) tree+subject (54 characters) tags
\r
82 > We solve this by extending the format specifier. Previously this was a
\r
83 > list of cons cells (field-name . format-string) We now allow the
\r
84 > left-side (the field-name) itself to be a list of cons cells in which case we
\r
85 > apply the formatting recursively.
\r
87 > This means we can separate the tree box graphics into their own field
\r
88 > while maintaining the current format.
\r
90 > Note that this will mean that people who have customised the
\r
91 > result-format will need to update their customisation.
\r
93 > The patch is larger but relatively simple.
\r
95 > Patch 1/4 is unrelated except I found it while doing this update: we
\r
96 > consistency we should print () for messages with no tags.
\r
98 > Patch 2/4 is large but trivial: it moves the insertion up a level in
\r
99 > preparation for the recursive formatting.
\r
101 > Patch 3/4 is also simple: it just allows the recursive formatting.
\r
103 > Patch 4/4 separates out the tree field. This patch is large as
\r
104 > it allows separate tree faces (matching and non-matching). The
\r
105 > "genuine code" part of the patch is relatively small.
\r
107 I should have added that everything works at each intermediate stage
\r
108 (and I think each patch makes sense incrementally): so
\r
109 the patches do not need to be reviewed as a batch.
\r
116 > Finally, this is the last series (apart from some extra tests and
\r
117 > keeping up with mainline progress) that I think pick needs before it's
\r
118 > ready for consideration in non-contrib mainline.
\r
126 > Mark Walters (4):
\r
127 > contrib: pick: print () for a message with no tags
\r
128 > contrib: pick: move the insertion of fields up a level
\r
129 > contrib: pick: allow recursive message field formats
\r
130 > contrib: pick: make the tree graphics a proper part of the format
\r
132 > contrib/notmuch-pick/notmuch-pick.el | 93 ++++++++++++++++++++++++---------
\r
133 > 1 files changed, 67 insertions(+), 26 deletions(-)
\r