1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 83B8241445E
\r
6 for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 07:08:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id yvMwVKlb6Bf4 for <notmuch@notmuchmail.org>;
\r
17 Sun, 8 Jan 2012 07:08:27 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id C3E3941445D
\r
22 for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 07:08:26 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1RjuM9-0000JH-Tg; Sun, 08 Jan 2012 15:08:22 +0000
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1RjuM9-0004Wo-Ka; Sun, 08 Jan 2012 15:08:21 +0000
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org, david@tethera.net
\r
34 Subject: Re: [PATCH 1/4] Add the option "--reply-to" to notmuch reply.
\r
35 In-Reply-To: <871urafjiy.fsf@nikula.org>
\r
36 References: <8739btdkir.fsf@qmul.ac.uk>
\r
37 <1325856857-15969-1-git-send-email-markwalters1009@gmail.com>
\r
38 <871urafjiy.fsf@nikula.org>
\r
39 User-Agent: Notmuch/0.10.2+183~g99cd7be (http://notmuchmail.org) Emacs/23.3.1
\r
41 Date: Sun, 08 Jan 2012 15:08:20 +0000
\r
42 Message-ID: <87y5tiqljv.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 94.192.233.223
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: b86516ba7f88ce87c7fb30efe38b71eb (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: -1.7
\r
49 X-SpamAssassin-SpamBar: -
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored -1.7 points.
\r
54 Summary of the scoring:
\r
55 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
57 * [138.37.6.40 listed in list.dnswl.org]
\r
58 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
59 provider * (markwalters1009[at]gmail.com)
\r
60 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
62 * 0.6 AWL AWL: From: address is in the auto white-list
\r
63 X-QM-Scan-Virus: ClamAV says the message is clean
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Sun, 08 Jan 2012 15:08:27 -0000
\r
79 On Sun, 08 Jan 2012 14:47:33 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
80 > > + /* We add the addresses if we are replying to all or we have not yet found
\r
81 > > + * a non-user address. We have to keep parsing to make sure we do find the
\r
82 > > + * correct from address for the user, but we pass a NULL message
\r
84 > > + if ((reply_to_all) || (g_mime_message_get_all_recipients (reply) == NULL))
\r
86 > Looking into this, it occurred to me g_mime_message_get_all_recipients()
\r
87 > allocates a new InternetAddressList when the return value is
\r
88 > non-NULL. Thus this leaks memory. OTOH allocating and deallocating for
\r
89 > this purpose seems suboptimal. I'll think this over.
\r
91 If we are happy with reply-to-sender stopping at the to: line
\r
92 (so if you reply-to-sender to an email which you sent and has no-one
\r
93 (apart from possibly you) on the to: line it would not give any
\r
94 recipients) then we only have two cases and we could do something like
\r
96 add_recipients_for_string for reply-to:/from:
\r
98 if return value is non-null then we were the sender so then
\r
100 add_recipients_for_string for to:
\r
102 and then stop regardless (well we want to carry on parsing headers to
\r
103 find the correct from: address to use but not adding any more
\r
106 It feels a bit hackish (it relies on the fact that if we found our
\r
107 address in the Reply-to:/From: line we didn't find anyone else's
\r
110 I think replying to an email which we sent and which does not have any
\r
111 other person on the to: line is sufficiently rare that it doesn't really
\r
112 matter what we do in this case.
\r