1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6A9FE431FC3
\r
6 for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 09:07:45 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id w1v3eigrSL6O for <notmuch@notmuchmail.org>;
\r
17 Wed, 23 Oct 2013 09:07:39 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 52B75431FBC
\r
22 for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 09:07:39 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1VZ0y4-0001TK-Ri; Wed, 23 Oct 2013 17:07:33 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1VZ0y4-0001kp-A7; Wed, 23 Oct 2013 17:07:32 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v2 0/8] Improve tag change completion
\r
34 In-Reply-To: <1382487721-31776-1-git-send-email-amdragon@mit.edu>
\r
35 References: <1382487721-31776-1-git-send-email-amdragon@mit.edu>
\r
36 User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Wed, 23 Oct 2013 17:06:27 +0100
\r
39 Message-ID: <87k3h40y64.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain
\r
42 X-Sender-Host-Address: 93.97.24.31
\r
43 X-QM-SPAM-Info: Sender has good ham record. :)
\r
44 X-QM-Body-MD5: 3f5ceb6e7a115b9b128abc699ab9c329 (of first 20000 bytes)
\r
45 X-SpamAssassin-Score: 0.0
\r
46 X-SpamAssassin-SpamBar: /
\r
47 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
49 spam. We require at least 5.0 points to mark a message as spam.
\r
50 This message scored 0.0 points. Summary of the scoring:
\r
51 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
52 provider * (markwalters1009[at]gmail.com)
\r
53 * 0.0 AWL AWL: From: address is in the auto white-list
\r
54 X-QM-Scan-Virus: ClamAV says the message is clean
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Wed, 23 Oct 2013 16:07:45 -0000
\r
70 In might of id:20131023154404.GE20337@mit.edu I am now happy with this
\r
78 On Wed, 23 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
79 > This is v2 of id:1382471457-26056-1-git-send-email-amdragon@mit.edu.
\r
80 > It improves some documentation strings, fixes one bug, and elimintes
\r
81 > some redundant code. The diff from v1 is below.
\r
83 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
84 > index ef77839..f66d669 100644
\r
85 > --- a/emacs/notmuch-show.el
\r
86 > +++ b/emacs/notmuch-show.el
\r
87 > @@ -1800,7 +1800,6 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
89 > (notmuch-show-mapc
\r
90 > (lambda () (setq tags (append (notmuch-show-get-tags) tags))))
\r
91 > - (delete-dups tags)
\r
92 > (notmuch-read-tag-changes tags "Tag thread"))))
\r
93 > (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)
\r
94 > (notmuch-show-mapc
\r
95 > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
\r
96 > index feee17c..7b21006 100644
\r
97 > --- a/emacs/notmuch-tag.el
\r
98 > +++ b/emacs/notmuch-tag.el
\r
99 > @@ -189,6 +189,9 @@ the messages that were tagged"
\r
100 > `notmuch-read-tag-changes' function.")
\r
102 > (defun notmuch-tag-completions (&rest search-terms)
\r
103 > + "Return a list of tags for messages matching SEARCH-TERMS.
\r
105 > +Returns all tags if no search terms are given."
\r
106 > (if (null search-terms)
\r
107 > (setq search-terms (list "*")))
\r
109 > @@ -199,7 +202,7 @@ the messages that were tagged"
\r
112 > (defun notmuch-select-tag-with-completion (prompt &rest search-terms)
\r
113 > - (let ((tag-list (notmuch-tag-completions search-terms)))
\r
114 > + (let ((tag-list (apply #'notmuch-tag-completions search-terms)))
\r
115 > (completing-read prompt tag-list nil nil nil 'notmuch-select-tag-history)))
\r
117 > (defun notmuch-read-tag-changes (current-tags &optional prompt initial-input)
\r
118 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
119 > index 5492e1b..53e9826 100644
\r
120 > --- a/emacs/notmuch.el
\r
121 > +++ b/emacs/notmuch.el
\r
122 > @@ -584,7 +584,10 @@ Returns (TAG-CHANGES REGION-BEGIN REGION-END)."
\r
123 > "Change tags for the currently selected thread or region.
\r
125 > See `notmuch-tag' for information on the format of TAG-CHANGES.
\r
126 > -If BEG or END are nil, applies to the thread at point."
\r
127 > +When called interactively, this uses the region if the region is
\r
128 > +active. When called directly, BEG and END provide the region.
\r
129 > +If these are nil or not provided, this applies to the thread at
\r
131 > (interactive (notmuch-search-interactive-tag-changes))
\r
132 > (unless (and beg end) (setq beg (point) end (point)))
\r
133 > (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
\r