1 Return-Path: <Vladimir.Marek@Oracle.COM>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B76BD431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 2 May 2013 06:47:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id GGxPf0EJVozU for <notmuch@notmuchmail.org>;
\r
17 Thu, 2 May 2013 06:47:40 -0700 (PDT)
\r
18 Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 8B7BF431FAF
\r
22 for <notmuch@notmuchmail.org>; Thu, 2 May 2013 06:47:40 -0700 (PDT)
\r
23 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237])
\r
24 by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with
\r
25 ESMTP id r42DlS1g018481
\r
26 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
\r
27 Thu, 2 May 2013 13:47:29 GMT
\r
28 Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85])
\r
29 by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
\r
31 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);
\r
32 Thu, 2 May 2013 13:47:28 GMT
\r
33 Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66])
\r
34 by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
\r
35 r42DlRNj003864; Thu, 2 May 2013 13:47:27 GMT
\r
36 Received: from pub.cz.oracle.com (/10.163.101.122)
\r
37 by default (Oracle Beehive Gateway v4.0)
\r
38 with ESMTP ; Thu, 02 May 2013 06:47:27 -0700
\r
39 Date: Thu, 2 May 2013 15:45:30 +0200
\r
40 From: Vladimir Marek <Vladimir.Marek@Oracle.COM>
\r
41 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
42 Subject: Re: [PATCH 01/24] lib/message.cc: stale pointer bug
\r
43 Message-ID: <20130502134530.GB23259@pub.cz.oracle.com>
\r
44 Mail-Followup-To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org,
\r
45 Vladimir Marek <vlmarek@volny.cz>
\r
46 References: <1367444021-2757-1-git-send-email-Vladimir.Marek@oracle.com>
\r
47 <m2sj25snsk.fsf@guru.guru-group.fi>
\r
49 Content-Type: text/plain; charset=utf-8
\r
50 Content-Disposition: inline
\r
51 In-Reply-To: <m2sj25snsk.fsf@guru.guru-group.fi>
\r
52 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
53 X-Source-IP: acsinet21.oracle.com [141.146.126.237]
\r
54 Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Thu, 02 May 2013 13:47:47 -0000
\r
69 > > int prefix_len = strlen (prefix);
\r
70 > > - const char *term = NULL;
\r
71 > > + std::string term;
\r
74 > > i.skip_to (prefix);
\r
77 > > - term = (*i).c_str ();
\r
81 > > - if (!term || strncmp (term, prefix, prefix_len))
\r
84 > ... hmm, a raii(?) solution above would be std::string term = *i;
\r
86 I'm not sure what's raii (I'm not very good at c++ ...), but I guess you
\r
87 mean to use 'std::string term = *i;' to avoid copy constructor. That
\r
88 surely is a good idea. Let me rework the patch!
\r