1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 19585429E30
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:20:30 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id TWGOd6uvZErD for <notmuch@notmuchmail.org>;
\r
16 Thu, 12 Jan 2012 09:20:29 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 5FAD9429E29
\r
21 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:20:29 -0800 (PST)
\r
22 Received: by wibhr12 with SMTP id hr12so1510658wib.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:20:28 -0800 (PST)
\r
24 Received: by 10.180.97.73 with SMTP id dy9mr7764187wib.11.1326388828162;
\r
25 Thu, 12 Jan 2012 09:20:28 -0800 (PST)
\r
26 Received: from localhost ([109.131.126.209])
\r
27 by mx.google.com with ESMTPS id q7sm947678wix.5.2012.01.12.09.20.26
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 12 Jan 2012 09:20:27 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
32 Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,
\r
33 Notmuch Mail <notmuch@notmuchmail.org>
\r
34 Subject: Re: Code Style Bikeshed 1/n: Break before Brace or Brace before
\r
36 In-Reply-To: <87pqflj1l0.fsf@gmail.com>
\r
37 References: <87vcpeaxwv.fsf@zancas.localnet> <87ty4xj2ub.fsf@gmail.com>
\r
38 <yf6zkepj1to.fsf@taco2.nixu.fi> <87pqflj1l0.fsf@gmail.com>
\r
39 User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1
\r
40 (x86_64-unknown-linux-gnu)
\r
41 Date: Thu, 12 Jan 2012 18:18:42 +0100
\r
42 Message-ID: <87aa5sltzh.fsf@praet.org>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-BeenThere: notmuch@notmuchmail.org
\r
46 X-Mailman-Version: 2.1.13
\r
48 List-Id: "Use and development of the notmuch mail system."
\r
49 <notmuch.notmuchmail.org>
\r
50 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
52 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
53 List-Post: <mailto:notmuch@notmuchmail.org>
\r
54 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
55 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
57 X-List-Received-Date: Thu, 12 Jan 2012 17:20:30 -0000
\r
59 On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
60 > On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
61 > > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
62 > > > +1 for the former.
\r
66 > > > How about indenting with spaces+tabs vs indenting with spaces only? :)
\r
68 > > -1 -- tab-width is 8, anything else is heretic. Everyone enable
\r
69 > > git pre-commit hook :)
\r
72 > Sorry, -1 for what? :)
\r
74 > FWIW tabs make patch review a pain in our favourite interface to our
\r
75 > favourite mail system because of message indenting.
\r
80 Neither the tabs nor the spaces impede patch review from within Notmuch.
\r
82 The real cause of this confusing indentation is that we're using *both*,
\r
83 which -from my point of view- makes absolutely no sense.
\r
85 Personally, I'd like to see
\r
87 ;; -*- tab-width: 2; indent-tabs-mode: nil; -*-
\r
89 ... but frankly, I don't care whether it's tabs or spaces, or whether
\r
90 it's mod-2, mod-4 or mod-8... as long as it's *tabs XOR spaces*.
\r
93 And brace-before-break, of course... :)
\r
96 So, when's this bikeshed due to be delivered ?
\r
97 Also, if I order *now*, do I get a complementary cheese grater ?
\r