1 Return-Path: <flo@chaoflow.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D6A63429E20
\r
6 for <notmuch@notmuchmail.org>; Sun, 8 May 2011 14:54:26 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id w1MnyWmWq0T7 for <notmuch@notmuchmail.org>;
\r
16 Sun, 8 May 2011 14:54:25 -0700 (PDT)
\r
17 Received: from tesla.chaoflow.net (tesla.chaoflow.net [188.40.54.22])
\r
18 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id C9D7D431FB5
\r
21 for <notmuch@notmuchmail.org>; Sun, 8 May 2011 14:54:25 -0700 (PDT)
\r
22 Received: from eve.chaoflow.net (ppp-93-104-187-151.dynamic.mnet-online.de
\r
24 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
25 (No client certificate requested)
\r
26 (Authenticated sender: flo@chaoflow.net)
\r
27 by tesla.chaoflow.net (Postfix) with ESMTPSA id 1F045C8B4;
\r
28 Sun, 8 May 2011 23:54:24 +0200 (CEST)
\r
29 Received: by eve.chaoflow.net (Postfix, from userid 1000) id DC9762AC;
\r
30 Sun, 8 May 2011 21:54:23 +0000 (Local time zone must be set--see zic
\r
32 From: Florian Friesdorf <flo@chaoflow.net>
\r
33 To: Austin Clements <amdragon@mit.edu>
\r
34 Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain
\r
35 control characters in notmuch-search
\r
36 In-Reply-To: <BANLkTi=ta-abS09Wa7=2_k7Q307u_Y4A0Q@mail.gmail.com>
\r
37 References: <87liyjgvyw.fsf@servo.factory.finestructure.net>
\r
38 <1304889273-24560-1-git-send-email-flo@chaoflow.net>
\r
39 <1304889273-24560-2-git-send-email-flo@chaoflow.net>
\r
40 <BANLkTi=ta-abS09Wa7=2_k7Q307u_Y4A0Q@mail.gmail.com>
\r
41 User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1
\r
42 (x86_64-unknown-linux-gnu)
\r
43 Date: Sun, 08 May 2011 23:54:17 +0200
\r
44 Message-ID: <877ha06epi.fsf@eve.chaoflow.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
48 X-Virus-Scanned: clamav-milter 0.96.5 at tesla
\r
49 X-Virus-Status: Clean
\r
50 Cc: notmuch@notmuchmail.org, Andreas Amann <a.amann@ucc.ie>
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Sun, 08 May 2011 21:54:27 -0000
\r
66 Content-Transfer-Encoding: quoted-printable
\r
68 On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon@mit.edu> wrote:
\r
69 > Cool. This seems very reasonable.
\r
71 > Just some style nits: The three places where you have
\r
72 > "sanitize_string(", there should be a space between the function name
\r
77 > Relatedly, "for(;*loop;loop++){" should be spaced out
\r
78 > like "for (; *loop; loop++) {".
\r
83 > Also, existing code conventionally uses a variable named "local"
\r
84 > for function-level talloc contexts such as your ctx_quote.
\r
86 In notmuch-search.c there is no variable named "local", in the other
\r
87 functions its also named ctx_quote. Should I rename all ctx_quote to
\r
90 Will send style fixes after we cleared this.
\r
93 Florian Friesdorf <flo@chaoflow.net>
\r
94 GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083
\r
95 Jabber/XMPP: flo@chaoflow.net
\r
96 IRC: chaoflow on freenode,ircnet,blafasel,OFTC
\r
99 Content-Type: application/pgp-signature
\r
101 -----BEGIN PGP SIGNATURE-----
\r
102 Version: GnuPG v2.0.17 (GNU/Linux)
\r
104 iQIcBAEBAgAGBQJNxxEPAAoJEDj4maMMRfCDYg8QAK24upQa8Zv1KE2wqszPBkLo
\r
105 P9TBb4nqP0VUU51ZUH4uDr+yyUge0YDRkXpGOk5w3KfLqZNnncMb1IXceHUisbJB
\r
106 C0kjNX2c4ioeqWroyVlTTM4er8qahEnTfaSPRtrbqNuLlJera1H5I0Ux/cMmXaiW
\r
107 f6S4IXH6cfhyx3DuzTEvcwaiEmqcAxbuxrzEjghkmW7N9OqLFEZ8ENbE2/G4YtbD
\r
108 MVG+30kKd2LE4GMJKttcgcXOvdtW8mLuD8i5TY/PsZoJAdCSIgxM9l2MvgMlzkUw
\r
109 umubgeXq6F56jMZNvlqHUVnvHQ1SppmdSBoAIydlWzcmD8onXNukANfHz1S1cvyV
\r
110 DRbGa7LaCImCMgjeoGJBDwnLKR/P05fd/2v1kiq7Q3mDEkSymZTb59pTp4iyXk7h
\r
111 ikpX/IvbMZKFVKBV6kwKCtbp5ba37y0ChnK5DwN2o35U15Cvg1RHpX8X2Wz4lzlT
\r
112 9agVTvYCasxbHwF7c3dBTRq+jjPg93+2oRzh0wqz2KsUW+7DCPzX7T3v0dZoBSBY
\r
113 AF+fKVxYtxnzJQ6JJlhVEh5Hp3ImkiMLWDIvw3072bTI24ECXoNIJOKk9K4GVC+I
\r
114 lFvd69qd4ninHpUm+qNQeoRrKLQZBPs78ZhlK4EdnP8Yo7tonz6JbFDiSVczzpST
\r
115 eaI9DKjrnzytaCFmm99V
\r
117 -----END PGP SIGNATURE-----
\r