1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D61D8431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 8 Sep 2012 04:29:49 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 59kYCxNScpga for <notmuch@notmuchmail.org>;
\r
16 Sat, 8 Sep 2012 04:29:48 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 14316431FAE
\r
19 for <notmuch@notmuchmail.org>; Sat, 8 Sep 2012 04:29:48 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id B871D1000E5;
\r
22 Sat, 8 Sep 2012 14:29:53 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Michal Nazarewicz <mpn@google.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] notmuch-show: include Bcc header in json output
\r
27 <e07afdc98fd9517fba3060970b1150cef4d7ac80.1346881123.git.mina86@mina86.com>
\r
29 <e07afdc98fd9517fba3060970b1150cef4d7ac80.1346881123.git.mina86@mina86.com>
\r
30 User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sat, 08 Sep 2012 14:29:53 +0300
\r
36 Message-ID: <m2zk50oiq6.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 08 Sep 2012 11:29:50 -0000
\r
53 On Thu, Sep 06 2012, Michal Nazarewicz <mpn@google.com> wrote:
\r
55 > From: Michal Nazarewicz <mina86@mina86.com>
\r
59 By looking the code (by applying this patch and looking more context)
\r
60 it looks good to me. If the commit message provided some explanation
\r
61 and use case *why* this patch is needed a casual reviewer who hasn't
\r
62 desired this feature (possibly by not knowing the benefits :) could
\r
63 understand the need better.
\r
65 Now that we have this bcc in json output when is it shown to the user ?
\r
69 > notmuch-show.c | 7 +++++++
\r
70 > 1 files changed, 7 insertions(+), 0 deletions(-)
\r
72 > Actually, I don't understand why json does not include all the
\r
75 > diff --git a/notmuch-show.c b/notmuch-show.c
\r
76 > index 3556293..0b7abf1 100644
\r
77 > --- a/notmuch-show.c
\r
78 > +++ b/notmuch-show.c
\r
79 > @@ -233,6 +233,13 @@ format_headers_json (sprinter_t *sp, GMimeMessage *message,
\r
80 > sp->string (sp, recipients_string);
\r
83 > + recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_BCC);
\r
84 > + recipients_string = internet_address_list_to_string (recipients, 0);
\r
85 > + if (recipients_string) {
\r
86 > + sp->map_key (sp, "Bcc");
\r
87 > + sp->string (sp, recipients_string);
\r
91 > sp->map_key (sp, "In-reply-to");
\r
92 > sp->string (sp, g_mime_object_get_header (GMIME_OBJECT (message), "In-reply-to"));
\r
96 > _______________________________________________
\r
97 > notmuch mailing list
\r
98 > notmuch@notmuchmail.org
\r
99 > http://notmuchmail.org/mailman/listinfo/notmuch
\r